PragmaticRawValueValidator::mustBeStringNotEmpty() - Code Metrics - Inspection of "Move project to ammit-php/ammit" - ammit-php/ammit - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d57f97...544bed )

by Guillaume

created 2018-03-10 13:05 UTC

PragmaticRawValueValidator::mustBeStringNotEmpty() B

↳ Parent: PragmaticRawValueValidator

Complexity

Conditions	4
Paths	1

Size

Total Lines	27
Code Lines	16

Duplication

Lines	27
Ratio	100 %

Code Coverage

Tests	10
CRAP Score	4.074

Importance

Changes

Metric	Value
dl	27
loc	27
rs	8.5806
c	0
b	0
f	0
ccs	10
cts	12
cp	0.8333
cc	4
eloc	16
nc	1
nop	4
crap	4.074

<?php
declare(strict_types = 1);

namespace AmmitPhp\Ammit\UI\Resolver\Validator;

use AmmitPhp\Ammit\UI\Resolver\Validator\Implementation\Pragmatic\StringBetweenLengthValidatorTrait;
use AmmitPhp\Ammit\Domain\MailMxValidation;
use AmmitPhp\Ammit\UI\Resolver\Validator\Implementation\Pragmatic\InArrayValidatorTrait;
use AmmitPhp\Ammit\UI\Resolver\Validator\Implementation\Pragmatic\UuidValidatorTrait;

/**
 * @internal Contains Domain Validation assertions (but class won't be removed in next version)
 *   Domain Validation should be done in Domain
 *   Should be used for prototyping project knowing you are accumulating technical debt
 */
class PragmaticRawValueValidator extends RawValueValidator
{
    use UuidValidatorTrait;
    use InArrayValidatorTrait;
    use StringBetweenLengthValidatorTrait;

    /**
     * Domain should be responsible for string emptiness
     * Exceptions are caught in order to be processed later
     * @param mixed $value String not empty ?
     *
     * @return mixed Untouched value
     */
    public function mustBeStringNotEmpty($value, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null)

    {
        $this->validationEngine->validateFieldValue(
            $parentValidator ?: $this,
            function() use ($value, $propertyPath, $exceptionMessage) {
                if (!empty($value)) {
                    return;
                }

                if (null === $exceptionMessage) {
                    $exceptionMessage = sprintf(
$x = 1;
$callable = function() use ($x) {
    $x = 2; // Not visible in outer scope. If you would like this, how
            // about using a different variable name than $x?
};

$callable();
var_dump($x); // integer(1)
                        'Value "%s" is empty.',
                        $value
                    );
                }

                throw new InvalidArgumentException(
                    $exceptionMessage,
                    0,
                    $propertyPath,
                    $value
                );
            }
        );

        return $value;
    }

    /**
     * Domain should be responsible for email format
     * Exceptions are caught in order to be processed later
     * @param mixed $value Email ?
     *
     * @return mixed Untouched value
     */
    public function mustBeEmailAddress($value, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null)
    {
        $mailMxValidation = new MailMxValidation();
        $this->validationEngine->validateFieldValue(
            $parentValidator ?: $this,
            function() use ($value, $propertyPath, $exceptionMessage, $mailMxValidation) {

                if ($mailMxValidation->isEmailFormatValid($value) && $mailMxValidation->isEmailHostValid($value)) {
                    return;
                }

                if (null === $exceptionMessage) {
                    $exceptionMessage = sprintf(
$x = 1;
$callable = function() use ($x) {
    $x = 2; // Not visible in outer scope. If you would like this, how
            // about using a different variable name than $x?
};

$callable();
var_dump($x); // integer(1)
                        'Mail "%s" is not valid.',
                        $value
                    );
                }

                throw new InvalidArgumentException(
                    $exceptionMessage,
                    0,
                    $propertyPath,
                    $value
                );
            }
        );

        return $value;
    }

    /**
     * Domain should be responsible for regex validation
     * Exceptions are caught in order to be processed later
     * @param mixed  $value   Valid against Regex ?
     * @param string $pattern Regex
     *
     * @return mixed Untouched value
     */
    public function mustBeValidAgainstRegex($value, string $pattern, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null)

    {
        $this->validationEngine->validateFieldValue(
            $parentValidator ?: $this,
            function() use ($value, $pattern, $propertyPath, $exceptionMessage) {
                if (preg_match($pattern, $value)) {
                    return;
                }

                throw new InvalidArgumentException(
                    $exceptionMessage ?: sprintf('Value "%s" not valid against regex "%s".', $value, $pattern),
                    0,
                    $propertyPath,
                    $value
                );
            }
        );

        return $value;
    }
}


Push — master ( d57f97...544bed )

PragmaticRawValueValidator::mustBeStringNotEmpty() B

Complexity

Size

Duplication

Code Coverage

Importance

Change not visible in outer-scope

Change visible in outer-scope

Change not visible in outer-scope

Change visible in outer-scope

1			<?php
2			declare(strict_types = 1);
3
4			namespace AmmitPhp\Ammit\UI\Resolver\Validator;
5
6			use AmmitPhp\Ammit\UI\Resolver\Validator\Implementation\Pragmatic\StringBetweenLengthValidatorTrait;
7			use AmmitPhp\Ammit\Domain\MailMxValidation;
8			use AmmitPhp\Ammit\UI\Resolver\Validator\Implementation\Pragmatic\InArrayValidatorTrait;
9			use AmmitPhp\Ammit\UI\Resolver\Validator\Implementation\Pragmatic\UuidValidatorTrait;
10
11			/**
12			* @internal Contains Domain Validation assertions (but class won't be removed in next version)
13			* Domain Validation should be done in Domain
14			* Should be used for prototyping project knowing you are accumulating technical debt
15			*/
16			class PragmaticRawValueValidator extends RawValueValidator
17			{
18			use UuidValidatorTrait;
19			use InArrayValidatorTrait;
20			use StringBetweenLengthValidatorTrait;
21
22			/**
23			* Domain should be responsible for string emptiness
24			* Exceptions are caught in order to be processed later
25			* @param mixed $value String not empty ?
26			*
27			* @return mixed Untouched value
28			*/
29		View Code Duplication	public function mustBeStringNotEmpty($value, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null)
			0 ignored issues – show Duplication introduced 2018-03-10 13:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
30			{
31	1		$this->validationEngine->validateFieldValue(
32	1		$parentValidator ?: $this,
33	1		function() use ($value, $propertyPath, $exceptionMessage) {
34	1		if (!empty($value)) {
35	1		return;
36			}
37
38	1		if (null === $exceptionMessage) {
39			$exceptionMessage = sprintf(
			0 ignored issues – show Bug introduced 2018-03-10 13:02 UTC by Report Bug Copy Issue Report Consider using a different name than the imported variable `$exceptionMessage`, or did you forget to import by reference? It seems like you are assigning to a variable which was imported through a `use` statement which was not imported by reference. For clarity, we suggest to use a different name or import by reference depending on whether you would like to have the change visibile in outer-scope. Change not visible in outer-scope $x = 1; $callable = function() use ($x) { $x = 2; // Not visible in outer scope. If you would like this, how // about using a different variable name than $x? }; $callable(); var_dump($x); // integer(1) Change visible in outer-scope $x = 1; $callable = function() use (&$x) { $x = 2; }; $callable(); var_dump($x); // integer(2) Loading history...
40			'Value "%s" is empty.',
41			$value
42			);
43			}
44
45	1		throw new InvalidArgumentException(
46			$exceptionMessage,
47	1		0,
48			$propertyPath,
49			$value
50			);
51	1		}
52			);
53
54	1		return $value;
55			}
56
57			/**
58			* Domain should be responsible for email format
59			* Exceptions are caught in order to be processed later
60			* @param mixed $value Email ?
61			*
62			* @return mixed Untouched value
63			*/
64			public function mustBeEmailAddress($value, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null)
65			{
66			$mailMxValidation = new MailMxValidation();
67			$this->validationEngine->validateFieldValue(
68			$parentValidator ?: $this,
69		View Code Duplication	function() use ($value, $propertyPath, $exceptionMessage, $mailMxValidation) {
			0 ignored issues – show Duplication introduced 2018-03-10 13:02 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
70			if ($mailMxValidation->isEmailFormatValid($value) && $mailMxValidation->isEmailHostValid($value)) {
71			return;
72			}
73
74			if (null === $exceptionMessage) {
75			$exceptionMessage = sprintf(
			0 ignored issues – show Bug introduced 2018-03-10 13:02 UTC by Report Bug Copy Issue Report Consider using a different name than the imported variable `$exceptionMessage`, or did you forget to import by reference? It seems like you are assigning to a variable which was imported through a `use` statement which was not imported by reference. For clarity, we suggest to use a different name or import by reference depending on whether you would like to have the change visibile in outer-scope. Change not visible in outer-scope $x = 1; $callable = function() use ($x) { $x = 2; // Not visible in outer scope. If you would like this, how // about using a different variable name than $x? }; $callable(); var_dump($x); // integer(1) Change visible in outer-scope $x = 1; $callable = function() use (&$x) { $x = 2; }; $callable(); var_dump($x); // integer(2) Loading history...
76			'Mail "%s" is not valid.',
77			$value
78			);
79			}
80
81			throw new InvalidArgumentException(
82			$exceptionMessage,
83			0,
84			$propertyPath,
85			$value
86			);
87			}
88			);
89
90			return $value;
91			}
92
93			/**
94			* Domain should be responsible for regex validation
95			* Exceptions are caught in order to be processed later
96			* @param mixed $value Valid against Regex ?
97			* @param string $pattern Regex
98			*
99			* @return mixed Untouched value
100			*/
101		View Code Duplication	public function mustBeValidAgainstRegex($value, string $pattern, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null)
			0 ignored issues – show Duplication introduced 2018-03-10 13:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
102			{
103	1		$this->validationEngine->validateFieldValue(
104	1		$parentValidator ?: $this,
105	1		function() use ($value, $pattern, $propertyPath, $exceptionMessage) {
106	1		if (preg_match($pattern, $value)) {
107	1		return;
108			}
109
110	1		throw new InvalidArgumentException(
111	1		$exceptionMessage ?: sprintf('Value "%s" not valid against regex "%s".', $value, $pattern),
112	1		0,
113			$propertyPath,
114			$value
115			);
116	1		}
117			);
118
119	1		return $value;
120			}
121			}
122

ammit-php / ammit

Push — master ( d57f97...544bed )

PragmaticRawValueValidator::mustBeStringNotEmpty() B

Complexity

Size

Duplication

Code Coverage

Importance

Change not visible in outer-scope

Change visible in outer-scope

Change not visible in outer-scope

Change visible in outer-scope

Duplication Side-by-Side

Filter issues like