IntegerValidatorTrait::mustBeIntegerOrEmpty() - Code Metrics - Inspection of "Move project to ammit-php/ammit" - ammit-php/ammit - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d57f97...544bed )

by Guillaume

created 2018-03-10 13:05 UTC

IntegerValidatorTrait::mustBeIntegerOrEmpty() A

↳ Parent: IntegerValidatorTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	8
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	8
loc	8
rs	9.4285
c	0
b	0
f	0
ccs	0
cts	3
cp	0
cc	2
eloc	4
nc	2
nop	4
crap	6

<?php

namespace AmmitPhp\Ammit\UI\Resolver\Validator\Implementation\Pure;

use AmmitPhp\Ammit\UI\Resolver\Validator\InvalidArgumentException;
use AmmitPhp\Ammit\UI\Resolver\UIValidationEngine;
use AmmitPhp\Ammit\UI\Resolver\Validator\UIValidatorInterface;

trait IntegerValidatorTrait
{
    /** @var UIValidationEngine */
    protected $validationEngine;

    /**
     * Exceptions are caught in order to be processed later
     * @param mixed $value Integer ?
     *
     * @return int|null Value casted into int or -1 or null
     */
    public function mustBeIntegerOrEmpty($value, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null)

    {
        if ($value === '') {
            return null;
        }

        return $this->mustBeInteger($value, $propertyPath, $parentValidator, $exceptionMessage);
    }

    /**
     * Exceptions are caught in order to be processed later
     * @param mixed $value Integer ?
     *
     * @return int Value casted into int or -1
     */
    public function mustBeInteger($value, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null): int

    {
        if (is_numeric($value)) {
            $value = (int) $value;
        }

        $this->validationEngine->validateFieldValue(
            $parentValidator ?: $this,
            function() use ($value, $propertyPath, $exceptionMessage) {
                if (is_int($value)) {
                    return;
                }

                if (null === $exceptionMessage) {
                    $exceptionMessage = sprintf(
$x = 1;
$callable = function() use ($x) {
    $x = 2; // Not visible in outer scope. If you would like this, how
            // about using a different variable name than $x?
};

$callable();
var_dump($x); // integer(1)
                        'Value "%s" is not an integer.',
                        $value
                    );
                }

                throw new InvalidArgumentException(
                    $exceptionMessage,
                    0,
                    $propertyPath,
                    $value
                );
            }
        );

        if (!is_int($value)) {
            return -1;
        }

        return $value;
    }
}


1			<?php
2
3			namespace AmmitPhp\Ammit\UI\Resolver\Validator\Implementation\Pure;
4
5			use AmmitPhp\Ammit\UI\Resolver\Validator\InvalidArgumentException;
6			use AmmitPhp\Ammit\UI\Resolver\UIValidationEngine;
7			use AmmitPhp\Ammit\UI\Resolver\Validator\UIValidatorInterface;
8
9			trait IntegerValidatorTrait
10			{
11			/** @var UIValidationEngine */
12			protected $validationEngine;
13
14			/**
15			* Exceptions are caught in order to be processed later
16			* @param mixed $value Integer ?
17			*
18			* @return int\|null Value casted into int or -1 or null
19			*/
20		View Code Duplication	public function mustBeIntegerOrEmpty($value, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null)
			0 ignored issues – show Duplication introduced 2018-03-10 13:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
21			{
22			if ($value === '') {
23			return null;
24			}
25
26			return $this->mustBeInteger($value, $propertyPath, $parentValidator, $exceptionMessage);
27			}
28
29			/**
30			* Exceptions are caught in order to be processed later
31			* @param mixed $value Integer ?
32			*
33			* @return int Value casted into int or -1
34			*/
35		View Code Duplication	public function mustBeInteger($value, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null): int
			0 ignored issues – show Duplication introduced 2018-03-10 13:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36			{
37	1		if (is_numeric($value)) {
38	1		$value = (int) $value;
39			}
40
41	1		$this->validationEngine->validateFieldValue(
42	1		$parentValidator ?: $this,
43	1		function() use ($value, $propertyPath, $exceptionMessage) {
44	1		if (is_int($value)) {
45	1		return;
46			}
47
48	1		if (null === $exceptionMessage) {
49			$exceptionMessage = sprintf(
			0 ignored issues – show Bug introduced 2018-03-10 13:02 UTC by Report Bug Copy Issue Report Consider using a different name than the imported variable `$exceptionMessage`, or did you forget to import by reference? It seems like you are assigning to a variable which was imported through a `use` statement which was not imported by reference. For clarity, we suggest to use a different name or import by reference depending on whether you would like to have the change visibile in outer-scope. Change not visible in outer-scope $x = 1; $callable = function() use ($x) { $x = 2; // Not visible in outer scope. If you would like this, how // about using a different variable name than $x? }; $callable(); var_dump($x); // integer(1) Change visible in outer-scope $x = 1; $callable = function() use (&$x) { $x = 2; }; $callable(); var_dump($x); // integer(2) Loading history...
50			'Value "%s" is not an integer.',
51			$value
52			);
53			}
54
55	1		throw new InvalidArgumentException(
56			$exceptionMessage,
57	1		0,
58			$propertyPath,
59			$value
60			);
61	1		}
62			);
63
64	1		if (!is_int($value)) {
65	1		return -1;
66			}
67
68	1		return $value;
69			}
70			}
71

ammit-php / ammit

Push — master ( d57f97...544bed )

IntegerValidatorTrait::mustBeIntegerOrEmpty() A

Complexity

Size

Duplication

Code Coverage

Importance

Change not visible in outer-scope

Change visible in outer-scope

Duplication Side-by-Side

Filter issues like