ArrayValidatorTrait::mustBeArray() - Code Metrics - ammit-php/ammit - Measure and Improve Code Quality continuously with Scrutinizer

ArrayValidatorTrait::mustBeArray() B
last analyzed 2018-03-10 13:20 UTC

↳ Parent: ArrayValidatorTrait

Complexity

Conditions	5
Paths	2

Size

Total Lines	31
Code Lines	18

Duplication

Lines	31
Ratio	100 %

Code Coverage

Tests	12
CRAP Score	5.0729

Importance

Changes

Metric	Value
dl	31
loc	31
rs	8.439
c	0
b	0
f	0
ccs	12
cts	14
cp	0.8571
cc	5
eloc	18
nc	2
nop	4
crap	5.0729

<?php

namespace AmmitPhp\Ammit\UI\Resolver\Validator\Implementation\Pure;

use AmmitPhp\Ammit\UI\Resolver\Validator\InvalidArgumentException;
use AmmitPhp\Ammit\UI\Resolver\UIValidationEngine;
use AmmitPhp\Ammit\UI\Resolver\Validator\UIValidatorInterface;

trait ArrayValidatorTrait

{
    /** @var UIValidationEngine */
    protected $validationEngine;

    /**
     * Exceptions are caught in order to be processed later
     * @param mixed $value Array ?
     *
     * @return array Empty array if not array
     */
    public function mustBeArray($value, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null): array
    {
        $this->validationEngine->validateFieldValue(
            $parentValidator ?: $this,
            function() use ($value, $propertyPath, $exceptionMessage) {
                if (is_array($value)) {
                    return;
                }

                if (null === $exceptionMessage) {
                    $exceptionMessage = sprintf(
$x = 1;
$callable = function() use ($x) {
    $x = 2; // Not visible in outer scope. If you would like this, how
            // about using a different variable name than $x?
};

$callable();
var_dump($x); // integer(1)
                        'Value "%s" is not an array.',
                        $value
                    );
                }

                throw new InvalidArgumentException(
                    $exceptionMessage,
                    0,
                    $propertyPath,
                    $value
                );
            }
        );

        if (!is_array($value)) {
            return [];
        }

        return $value;
    }
}


ArrayValidatorTrait::mustBeArray() B
last analyzed 2018-03-10 13:20 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Change not visible in outer-scope

Change visible in outer-scope

1			<?php
2
3			namespace AmmitPhp\Ammit\UI\Resolver\Validator\Implementation\Pure;
4
5			use AmmitPhp\Ammit\UI\Resolver\Validator\InvalidArgumentException;
6			use AmmitPhp\Ammit\UI\Resolver\UIValidationEngine;
7			use AmmitPhp\Ammit\UI\Resolver\Validator\UIValidatorInterface;
8
9		View Code Duplication	trait ArrayValidatorTrait
			0 ignored issues – show Duplication introduced 2018-03-10 13:05 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
10			{
11			/** @var UIValidationEngine */
12			protected $validationEngine;
13
14			/**
15			* Exceptions are caught in order to be processed later
16			* @param mixed $value Array ?
17			*
18			* @return array Empty array if not array
19			*/
20			public function mustBeArray($value, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null): array
21			{
22	1		$this->validationEngine->validateFieldValue(
23	1		$parentValidator ?: $this,
24	1		function() use ($value, $propertyPath, $exceptionMessage) {
25	1		if (is_array($value)) {
26	1		return;
27			}
28
29	1		if (null === $exceptionMessage) {
30			$exceptionMessage = sprintf(
			0 ignored issues – show Bug introduced 2018-03-10 13:02 UTC by Report Bug Copy Issue Report Consider using a different name than the imported variable `$exceptionMessage`, or did you forget to import by reference? It seems like you are assigning to a variable which was imported through a `use` statement which was not imported by reference. For clarity, we suggest to use a different name or import by reference depending on whether you would like to have the change visibile in outer-scope. Change not visible in outer-scope $x = 1; $callable = function() use ($x) { $x = 2; // Not visible in outer scope. If you would like this, how // about using a different variable name than $x? }; $callable(); var_dump($x); // integer(1) Change visible in outer-scope $x = 1; $callable = function() use (&$x) { $x = 2; }; $callable(); var_dump($x); // integer(2) Loading history...
31			'Value "%s" is not an array.',
32			$value
33			);
34			}
35
36	1		throw new InvalidArgumentException(
37			$exceptionMessage,
38	1		0,
39			$propertyPath,
40			$value
41			);
42	1		}
43			);
44
45	1		if (!is_array($value)) {
46	1		return [];
47			}
48
49	1		return $value;
50			}
51			}
52

ammit-php / ammit

ArrayValidatorTrait::mustBeArray() B last analyzed 2018-03-10 13:20 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Change not visible in outer-scope

Change visible in outer-scope

Duplication Side-by-Side

Filter issues like

ArrayValidatorTrait::mustBeArray() B
last analyzed 2018-03-10 13:20 UTC