AmmitPhp\Ammit\UI\Resolver\Validator\Implementation\Pure\BooleanValidatorTrait

Complexity

Total Complexity

7

Size/Duplication

Total Lines	60
Duplicated Lines	46.67 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

72.21%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	mustBeBooleanOrEmpty()	8	8	2
B	mustBeBoolean()	20	33	5

<?php

namespace AmmitPhp\Ammit\UI\Resolver\Validator\Implementation\Pure;

use AmmitPhp\Ammit\UI\Resolver\Validator\InvalidArgumentException;
use AmmitPhp\Ammit\Domain\BooleanValidation;
use AmmitPhp\Ammit\UI\Resolver\UIValidationEngine;
use AmmitPhp\Ammit\UI\Resolver\Validator\UIValidatorInterface;

trait BooleanValidatorTrait
{
    /** @var UIValidationEngine */
    protected $validationEngine;

    /**
     * Exceptions are caught in order to be processed later
     * @param mixed $value Boolean ?
     *
     * @return boolean|null Value casted into boolean or null
     */
    public function mustBeBooleanOrEmpty($value, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null)

This method seems to be duplicated in your project.

    {
        if ($value === '') {
            return null;
        }

        return $this->mustBeBoolean($value, $propertyPath, $parentValidator, $exceptionMessage);
    }

    /**
     * Exceptions are caught in order to be processed later
     * @param mixed $value Boolean ?
     *
     * @return boolean Value casted into boolean or false
     */
    public function mustBeBoolean($value, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null): bool
    {
        $this->validationEngine->validateFieldValue(
            $parentValidator ?: $this,
            function() use ($value, $propertyPath, $exceptionMessage) {

This code seems to be duplicated across your project.

                $booleanValidation = new BooleanValidation();
                if ($booleanValidation->isBooleanValid($value)) {
                    return;
                }

                if (null === $exceptionMessage) {
                    $exceptionMessage = sprintf(

Consider using a different name than the imported variable $exceptionMessage, or did you forget to import by reference?

                        'Value "%s" is not a boolean.',
                        $value
                    );
                }

                throw new InvalidArgumentException(
                    $exceptionMessage,
                    0,
                    $propertyPath,
                    $value
                );
            }
        );

        // Otherwise "false" would return true
        if (in_array($value, [true, 'true', '1', 1], true)) {

This if statement, and the following return statement can be replaced with return in_array($value, array(true, 'true', '1', 1), true);.

            return true;
        }

        return false;
    }
}