aminyazdanpanah / PHP-FFmpeg-video-streaming

src/Traits/Representations.php

<?php

/**
 * This file is part of the PHP-FFmpeg-video-streaming package.
 *
 * (c) Amin Yazdanpanah <contact@aminyazdanpanah.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Streaming\Traits;

use Streaming\AutoReps;
use Streaming\Exception\InvalidArgumentException;
use Streaming\RepresentationInterface;
use Streaming\RepsCollection;

trait Representations
{
    /** @var RepsCollection */
    protected $reps;

    /**
     * add a representation
     * @param RepresentationInterface $rep
     * @return $this
     */
    public function addRepresentation(RepresentationInterface $rep)
    {
        $this->reps->add($rep);
        return $this;
    }

    /**
     * add representations using an array
     * @param array $reps
     * @return $this
     */
    public function addRepresentations(array $reps)
    {
        array_walk($reps, [$this, 'addRepresentation']);
        return $this;
    }

    /**
     * @param array|null $sides
     * @param array|null $k_bitrate
     * @param bool $acceding_order
     * @return $this
     */
    public function autoGenerateRepresentations(array $sides = null, array $k_bitrate = null, bool $acceding_order = true)
    {
        if (!$this->format) {
            throw new InvalidArgumentException('First you must set the format of the video');
        }

        $reps = new AutoReps($this->getMedia(), $this->getFormat(), $sides, $k_bitrate);

It seems like getFormat() must be provided by classes using this trait. How about adding it as abstract method to this trait?

It seems like getMedia() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $reps->sort($acceding_order);

        foreach ($reps as $rep) {
            $this->addRepresentation($rep);
        }

        return $this;
    }

    /**
     * @return RepsCollection
     */
    public function getRepresentations(): RepsCollection
    {
        return $this->reps;
    }
}