HLSFilter::HLSFilter() - Code Metrics - Inspection of "Add fragmented MP4 format support #31" - aminyazdanpanah/PHP-FFmpeg-video-streaming - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f27e34...4d4fc5 )

by Amin

created 2020-02-29 18:51 UTC

HLSFilter::HLSFilter() A

↳ Parent: HLSFilter

Complexity

Conditions	4
Paths	5

Size

Total Lines	53
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	2	Features	0

Metric	Value
cc	4
eloc	44
c	3
b	2
f	0
nc	5
nop	1
dl	0
loc	53
rs	9.216

How to fix Long Method

<?php

/**
 * This file is part of the PHP-FFmpeg-video-streaming package.
 *
 * (c) Amin Yazdanpanah <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Streaming\Filters;

use Streaming\File;
use Streaming\HLS;
use Streaming\Representation;

class HLSFilter extends Filter
{
    /**
     * @param $media
     * @return mixed|void
     */
    public function setFilter($media): void
    {
        $this->filter = $this->HLSFilter($media);
    }

    /**
     * @param HLS $hls
     * @return array
     */
    private function HLSFilter(HLS $hls): array
    {
        $filter = [];
        $reps = $hls->getRepresentations();
        $path_parts = $hls->getPathInfo();
        $dirname = str_replace("\\", "/", $path_parts["dirname"]);
        list($seg_sub_dir, $base_url) = $this->getSubDirectory($hls, $dirname);
        $full_seg_filename = $dirname . "/" . $seg_sub_dir . $path_parts["filename"];

        foreach ($reps as $key => $rep) {
            if ($key) {
                $filter = array_merge($filter, $this->getFormats($hls));
            }

            $filter[] = "-s:v";
            $filter[] = $rep->getResize();
            $filter[] = "-crf";
            $filter[] = "20";
            $filter[] = "-sc_threshold";
            $filter[] = "0";
            $filter[] = "-g";
            $filter[] = "48";
            $filter[] = "-keyint_min";
            $filter[] = "48";
            $filter[] = "-hls_list_size";
            $filter[] = $hls->getHlsListSize();
            $filter[] = "-hls_time";
            $filter[] = $hls->getHlsTime();
            $filter[] = "-hls_allow_cache";
            $filter[] = (int)$hls->isHlsAllowCache();
            $filter[] = "-b:v";
            $filter[] = $rep->getKiloBitrate() . "k";
            $filter = array_merge($filter, $this->getAudioBitrate($rep));
            $filter[] = "-maxrate";
            $filter[] = intval($rep->getKiloBitrate() * 1.2) . "k";
            $filter[] = "-hls_segment_type";
            $filter[] = $hls->getHlsSegmentType();
            $filter[] = "-hls_fmp4_init_filename";
            $filter[] = $path_parts["filename"] . "_" . $hls->getHlsFmp4InitFilename();
            $filter[] = "-hls_segment_filename";
            $filter[] = $this->getSegmentFilename($full_seg_filename, $rep, $hls->getHlsSegmentType());
            $filter = array_merge($filter, $this->getBaseURL($base_url));
            $filter = array_merge($filter, $this->getKeyInfo($hls));
            $filter = array_merge($filter, $hls->getAdditionalParams());
            $filter[] = "-strict";
            $filter[] = $hls->getStrict();

            if (end($reps) !== $rep) {
                $filter[] = $dirname . "/" . $path_parts["filename"] . "_" . $rep->getHeight() . "p.m3u8";
            }
        }

        return $filter;
    }

    /**
     * @param HLS $hls
     * @param $dirname
     * @return array
     */
    private function getSubDirectory(HLS $hls, string $dirname): array
    {
        if ($hls->getTsSubDirectory()) {
            File::makeDir($dirname . "/" . $hls->getTsSubDirectory() . "/");
        }

        $base = $hls->getHlsBaseUrl() ? rtrim($hls->getHlsBaseUrl(), '/') . "/" : null;
        $ts = $hls->getTsSubDirectory() ? rtrim($hls->getTsSubDirectory(), '/') . "/" : null;

        return [$ts, $base . $ts];
    }

    /**
     * @param HLS $hls
     * @return array
     */
    private function getFormats(HLS $hls): array
    {
        $format = ['-c:v', $hls->getFormat()->getVideoCodec()];
        $format = ['-c:v', $hls->getFormat()->/** @scrutinizer ignore-call */ getVideoCodec()];
        $audio_format = $hls->getFormat()->getAudioCodec();
        $audio_format = $hls->getFormat()->/** @scrutinizer ignore-call */ getAudioCodec();

        return $audio_format ? array_merge($format, ['-c:a', $audio_format]) : $format;
    }

    /**
     * @param $base_url
     * @return array
     */
    private function getBaseURL(string $base_url): array
    {
        return $base_url ? ["-hls_base_url", $base_url] : [];
    }

    /**
     * @param HLS $hls
     * @return array
     */
    private function getKeyInfo(HLS $hls): array
    {
        return $hls->getHlsKeyInfoFile() ? ["-hls_key_info_file", $hls->getHlsKeyInfoFile()] : [];
    }

    /**
     * @param Representation $rep
     * @return array
     */
    private function getAudioBitrate(Representation $rep): array
    {
        return $rep->getAudioKiloBitrate() ? ["-b:a", $rep->getAudioKiloBitrate() . "k"] : [];
    }

    /**
     * @param string $full_seg_filename
     * @param Representation $rep
     * @param string $type
     * @return string
     */
    private function getSegmentFilename(string $full_seg_filename, Representation $rep, string $type): string
    {
        $ext = ($type === "fmp4") ? "m4s" : "ts";
        return $full_seg_filename . "_" . $rep->getHeight() . "p_%04d." . $ext;
    }
}

aminyazdanpanah / PHP-FFmpeg-video-streaming

Push — master ( f27e34...4d4fc5 )

HLSFilter::HLSFilter() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like