ProfileController::__construct() - Code Metrics - Inspection of "add profile feature" - aminetiyal/laravel-template - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f9cd2a...a18de0 )

by Amine

created 2020-04-12 18:15 UTC

ProfileController::__construct() A

↳ Parent: ProfileController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Aminetiyal\LaravelTemplate\Http\Controllers\Auth;
//namespace App\Http\Controllers\Auth;

use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Hash;
use Illuminate\Support\Facades\Validator;

class ProfileController extends Controller
{
    public function __construct()
    {
        $this->middleware('auth');
    }

    public function index()
    {
        $user = auth()->user();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return view('template::lte.profile', compact('user'));
    }

    public function update(Request $request)
    {
        $validator = Validator::make($request->all(), [
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            'name' => 'required|string|max:255',
            'email' => 'required|string|email|max:255|unique:users,email,' . auth()->id()
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        ])->validate();

        auth()->user()->update($request->only('name','email'));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return redirect()->back();
    }

    public function updatePassword(Request $request)
    {
        $validator = Validator::make($request->all(), [
            'old_password' => 'required|min:8',
            'password' => 'required|string|min:8|confirmed'
        ]);

        $validator->after(function ($validator) use ($request) {
            if (!$this->isUserPassword($request->input('old_password'))) {
                $validator->errors()->add('old_password', 'Your current password does not matches with the password you provided.');
            }
        });

        $validator->validate();

        auth()->user()->password = $request->input('password');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        auth()->user()->update();

        return redirect()->back();
    }

    private function isUserPassword($password)
    {
        return (Hash::check($password , auth()->user()->password));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

}


1			<?php
2
3			namespace Aminetiyal\LaravelTemplate\Http\Controllers\Auth;
4			//namespace App\Http\Controllers\Auth;
5
6			use App\Http\Controllers\Controller;
7			use Illuminate\Http\Request;
8			use Illuminate\Support\Facades\Hash;
9			use Illuminate\Support\Facades\Validator;
10
11			class ProfileController extends Controller
12			{
13			public function __construct()
14			{
15			$this->middleware('auth');
16			}
17
18			public function index()
19			{
20			$user = auth()->user();
			0 ignored issues – show Bug introduced 2020-04-12 18:16 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
21
22			return view('template::lte.profile', compact('user'));
23			}
24
25			public function update(Request $request)
26			{
27			$validator = Validator::make($request->all(), [
			0 ignored issues – show Unused Code introduced 2020-04-12 18:16 UTC by Report Bug Copy Issue Report `$validator` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
28			'name' => 'required\|string\|max:255',
29			'email' => 'required\|string\|email\|max:255\|unique:users,email,' . auth()->id()
			0 ignored issues – show Bug introduced 2020-04-12 18:16 UTC by Report Bug Copy Issue Report The method `id` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
30			])->validate();
31
32			auth()->user()->update($request->only('name','email'));
			0 ignored issues – show Bug introduced 2020-04-12 18:16 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
33
34			return redirect()->back();
35			}
36
37			public function updatePassword(Request $request)
38			{
39			$validator = Validator::make($request->all(), [
40			'old_password' => 'required\|min:8',
41			'password' => 'required\|string\|min:8\|confirmed'
42			]);
43
44			$validator->after(function ($validator) use ($request) {
45			if (!$this->isUserPassword($request->input('old_password'))) {
46			$validator->errors()->add('old_password', 'Your current password does not matches with the password you provided.');
47			}
48			});
49
50			$validator->validate();
51
52			auth()->user()->password = $request->input('password');
			0 ignored issues – show Bug introduced 2020-04-12 18:16 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
53
54			auth()->user()->update();
55
56			return redirect()->back();
57			}
58
59			private function isUserPassword($password)
60			{
61			return (Hash::check($password , auth()->user()->password));
			0 ignored issues – show Bug introduced 2020-04-12 18:16 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
62			}
63
64			}
65

aminetiyal / laravel-template

Push — master ( f9cd2a...a18de0 )

ProfileController::__construct() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like