EndorserClientFactory::fromInsecureChannelCredentials() - Code Metrics - americanexpress/hyperledger-fabric-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

fromInsecureChannelCredentials() A
last analyzed 2017-12-09 00:02 UTC

↳ Parent: EndorserClientFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0
ccs	3
cts	3
cp	1
crap	1

<?php

/**
 * Copyright 2017 American Express Travel Related Services Company, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
 * or implied. See the License for the specific language governing
 * permissions and limitations under the License.
 */

declare(strict_types=1);

namespace AmericanExpress\HyperledgerFabricClient\ProtoFactory;

use Grpc\ChannelCredentials;
use Hyperledger\Fabric\Protos\Peer\EndorserClient;

class EndorserClientFactory
{
    /**
     * @param string $host
     * @return EndorserClient
     */
    public static function fromInsecureChannelCredentials(string $host): EndorserClient
    {
        $channelCredentials = ChannelCredentials::createInsecure();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        return self::fromChannelCredentials($host, $channelCredentials);
    }

    /**
     * @param string $host
     * @param ChannelCredentials $channelCredentials
     * @return EndorserClient
     */
    public static function fromChannelCredentials(
        string $host,
        ChannelCredentials $channelCredentials = null
    ): EndorserClient {
        return new EndorserClient($host, [
            'credentials' => $channelCredentials,
        ]);
    }
}


1		<?php
2
3		/**
4		* Copyright 2017 American Express Travel Related Services Company, Inc.
5		*
6		* Licensed under the Apache License, Version 2.0 (the "License");
7		* you may not use this file except in compliance with the License.
8		* You may obtain a copy of the License at
9		*
10		* http://www.apache.org/licenses/LICENSE-2.0
11		*
12		* Unless required by applicable law or agreed to in writing, software
13		* distributed under the License is distributed on an "AS IS" BASIS,
14		* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
15		* or implied. See the License for the specific language governing
16		* permissions and limitations under the License.
17		*/
18
19		declare(strict_types=1);
20
21		namespace AmericanExpress\HyperledgerFabricClient\ProtoFactory;
22
23		use Grpc\ChannelCredentials;
24		use Hyperledger\Fabric\Protos\Peer\EndorserClient;
25
26		class EndorserClientFactory
27		{
28		/**
29		* @param string $host
30		* @return EndorserClient
31		*/
32	1	public static function fromInsecureChannelCredentials(string $host): EndorserClient
33		{
34	1	$channelCredentials = ChannelCredentials::createInsecure();
		0 ignored issues – show Bug introduced 2017-12-08 19:44 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$channelCredentials` is correct as `Grpc\ChannelCredentials::createInsecure()` targeting `Grpc\ChannelCredentials::createInsecure()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
35
36	1	return self::fromChannelCredentials($host, $channelCredentials);
37		}
38
39		/**
40		* @param string $host
41		* @param ChannelCredentials $channelCredentials
42		* @return EndorserClient
43		*/
44	2	public static function fromChannelCredentials(
45		string $host,
46		ChannelCredentials $channelCredentials = null
47		): EndorserClient {
48	2	return new EndorserClient($host, [
49	2	'credentials' => $channelCredentials,
50		]);
51		}
52		}
53

americanexpress / hyperledger-fabric-sdk-php

fromInsecureChannelCredentials() A last analyzed 2017-12-09 00:02 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

fromInsecureChannelCredentials() A
last analyzed 2017-12-09 00:02 UTC