AmericanExpressTest\HyperledgerFabricClient\Signatory\MdanterEccSignatoryTest

Complexity

Total Complexity

7

Size/Duplication

Total Lines	108
Duplicated Lines	18.52 %

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	testGetSCharacterization()	0	16	1
A	testSignProposal()	0	14	1
A	dataGetS()	0	3	1
A	testGetS()	0	8	1
A	setUp()	0	4	1
A	getProposalSignatureCharacterizationData()	18	18	1
A	testSignEmptyProposal()	0	9	1

<?php

/**
 * Copyright 2017 American Express Travel Related Services Company, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
 * or implied. See the License for the specific language governing
 * permissions and limitations under the License.
 */

declare(strict_types=1);

namespace AmericanExpressTest\HyperledgerFabricClient\Signatory;

use AmericanExpress\HyperledgerFabricClient\Signatory\MdanterEccSignatory;
use AmericanExpressTest\HyperledgerFabricClient\Chaincode\AbstractChaincodeTest;
use Hyperledger\Fabric\Protos\Peer\Proposal;
use Hyperledger\Fabric\Protos\Peer\SignedProposal;

/**
 * @covers \AmericanExpress\HyperledgerFabricClient\Signatory\MdanterEccSignatory
 */
class MdanterEccSignatoryTest extends AbstractChaincodeTest
{
    /**
     * @var MdanterEccSignatory
     */
    private $sut;

    protected function setUp()
    {
        parent::setUp();
        $this->sut = new MdanterEccSignatory();
    }

    public function testSignEmptyProposal()
    {
        $result = $this->sut->signProposal(new Proposal(), $this->privateKeyFile);

        self::assertInstanceOf(SignedProposal::class, $result);
        self::assertInternalType('string', $result->getProposalBytes());
        self::assertEmpty($result->getProposalBytes());
        self::assertInternalType('string', $result->getSignature());
        self::assertNotEmpty($result->getSignature());
    }

    public function testSignProposal()
    {
        $proposal = new Proposal();
        $proposal->setHeader('HEADER-STRING');
        $proposal->setPayload('PAYLOAD-STRING');
        $result = $this->sut->signProposal($proposal, $this->privateKeyFile);

        self::assertEquals(
            'Cg1IRUFERVItU1RSSU5HEg5QQVlMT0FELVNUUklORw==',
            base64_encode($result->getProposalBytes())
        );
        self::assertEquals(
            'MEQCIEfgYNT2Rve6kGy7Ter1/77KcJin1MImCroLqIzdiLmtAiBRjOCkd7aW6KM+qRzDxWmC1+X9aP/tzWD6/Z5a2E9zOA==',
            base64_encode($result->getSignature())
        );
    }

    /**
     * @dataProvider getProposalSignatureCharacterizationData
     * @param string $encodedProposalBytes
     * @param string $encodedSignature
     * @param string $proposalHeader
     * @param string $proposalPayload
     * @param string $proposalExtension
     */
    public function testGetSCharacterization(
        string $encodedProposalBytes,
        string $encodedSignature,
        string $proposalHeader,
        string $proposalPayload,
        string $proposalExtension
    ) {
        $proposal = new Proposal();
        $proposal->setHeader(base64_decode($proposalHeader));

It seems like base64_decode($proposalHeader) can also be of type false; however, parameter $var of Hyperledger\Fabric\Protos\Peer\Proposal::setHeader() does only seem to accept string, maybe add an additional type check?

        $proposal->setPayload(base64_decode($proposalPayload));

It seems like base64_decode($proposalPayload) can also be of type false; however, parameter $var of Hyperledger\Fabric\Protos\Peer\Proposal::setPayload() does only seem to accept string, maybe add an additional type check?

        $proposal->setExtension(base64_decode($proposalExtension));

It seems like base64_decode($proposalExtension) can also be of type false; however, parameter $var of Hyperledger\Fabric\Protos\Peer\Proposal::setExtension() does only seem to accept string, maybe add an additional type check?

        $result = $this->sut->signProposal($proposal, new \SplFileObject($this->privateKey->url()));

        self::assertInstanceOf(SignedProposal::class, $result);
        self::assertEquals($encodedProposalBytes, base64_encode($result->getProposalBytes()));
        self::assertEquals($encodedSignature, base64_encode($result->getSignature()));
    }

    /**
     * @covers       \AmericanExpress\HyperledgerFabricClient\Signatory\MdanterEccSignatory::getS
     * @dataProvider dataGetS
     * @param string $dateTime
     * @param string $encodedProposalBytes
     * @param string $encodedSignature
     */
    public function testGetS(string $dateTime, string $encodedProposalBytes, string $encodedSignature)
    {
        $proposal = $this->createChaincodeProposal($dateTime, $this->getPrivateKeyFile());
        $result = $this->sut->signProposal($proposal, new \SplFileObject($this->privateKey->url()));

        self::assertInstanceOf(SignedProposal::class, $result);
        self::assertEquals($encodedProposalBytes, base64_encode($result->getProposalBytes()));
        self::assertEquals($encodedSignature, base64_encode($result->getSignature()));
    }

    public function getProposalSignatureCharacterizationData()

This method seems to be duplicated in your project.

    {
        $data = $this->loadStaticData();

        return array_map(
            function ($value) {
                return array_intersect_key(
                    $value,
                    array_flip([
                        'encodedProposalBytes',
                        'encodedSignature',
                        'proposalHeader',
                        'proposalPayload',
                        'proposalExtension',
                    ])
                );
            },
            $data
        );
    }

    public function dataGetS()
    {
        return $this->loadStaticData();
    }
}