AmericanExpress\HyperledgerFabricClient\Serializer\SignedCharStringSerializer

Complexity

Total Complexity

2

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	serialize()	0	3	1
A	deserialize()	0	3	1

<?php

/**
 * Copyright 2017 American Express Travel Related Services Company, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
 * or implied. See the License for the specific language governing
 * permissions and limitations under the License.
 */

declare(strict_types=1);

namespace AmericanExpress\HyperledgerFabricClient\Serializer;

final class SignedCharStringSerializer implements StringSerializerInterface
{
    /**
     * @param array $array
     * @return string
     */
    public function serialize(array $array): string
    {
        return pack(...array_merge(['c*'], $array));

array_merge(array('c*'), $array) is expanded, but the parameter $format of pack() does not expect variable arguments.

    }

    /**
     * @param string $data
     * @return array
     */
    public function deserialize(string $data): array
    {
        return \unpack('c*', $data);

The call to unpack() has too few arguments starting with offset.

    }
}