Completed
Push — master ( 7deb80...a4d7e3 )
by Askupa
01:24
created
functions.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,9 @@
 block discarded – undo
17 17
 /**
18 18
  * Prevent loading the library more than once
19 19
  */
20
-if( defined( 'AMARKAL_UI' ) ) return false;
20
+if( defined( 'AMARKAL_UI' ) ) {
21
+    return false;
22
+}
21 23
 define( 'AMARKAL_UI', true );
22 24
 
23 25
 if(!function_exists('amarkal_ui_render'))
Please login to merge, or discard this patch.
ComponentFactory.php 2 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -52,8 +52,8 @@  discard block
 block discarded – undo
52 52
     
53 53
     /**
54 54
      * 
55
-     * @param type $type
56
-     * @param type $props
55
+     * @param string $type
56
+     * @param type string
57 57
      * @throws \RuntimeException
58 58
      */
59 59
     private static function create_core_component( $type, $props )
@@ -79,8 +79,8 @@  discard block
 block discarded – undo
79 79
     
80 80
     /**
81 81
      * 
82
-     * @param type $type
83
-     * @param type $props
82
+     * @param string $type
83
+     * @param type string
84 84
      * @throws \RuntimeException
85 85
      */
86 86
     private static function create_registered_component( $type, $props )
Please login to merge, or discard this patch.
Braces   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -46,8 +46,9 @@  discard block
 block discarded – undo
46 46
         if( !in_array($type, self::$registered_components) )
47 47
         {
48 48
             self::$registered_components[$type] = $class_name;
49
+        } else {
50
+            throw new \RuntimeException("A component of type '$type' has already been registered.");
49 51
         }
50
-        else throw new \RuntimeException("A component of type '$type' has already been registered.");
51 52
     }
52 53
     
53 54
     /**
@@ -67,8 +68,7 @@  discard block
 block discarded – undo
67 68
             if( file_exists( $file_name ) ) 
68 69
             {
69 70
                 require_once $file_name;
70
-            }
71
-            else 
71
+            } else 
72 72
             {
73 73
                 throw new \RuntimeException("A component of type '$type' does not exist.");
74 74
             }
Please login to merge, or discard this patch.
Form.php 2 patches
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -202,7 +202,9 @@
 block discarded – undo
202 202
      */
203 203
     private function validate( $component )
204 204
     {
205
-        if( !($component instanceof ValidatableComponentInterface) ) return;
205
+        if( !($component instanceof ValidatableComponentInterface) ) {
206
+            return;
207
+        }
206 208
         
207 209
         $name     = $component->name;
208 210
         $validate = $component->validation;
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
     /**
130 130
      * Get all components.
131 131
      * 
132
-     * @return array
132
+     * @return AbstractComponent[]
133 133
      */
134 134
     public function get_component_list()
135 135
     {
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
     /**
164 164
      * Check if the given component is disabled.
165 165
      * 
166
-     * @param UI\AbstractComponent $component
166
+     * @param ValueComponentInterface $component
167 167
      * @return boolean
168 168
      */
169 169
     private function is_disabled( $component )
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
     /**
180 180
      * Filter the component's value using its filter function (if applicable)
181 181
      * 
182
-     * @param UI\AbstractComponent $component
182
+     * @param ValueComponentInterface $component
183 183
      */
184 184
     private function filter( $component )
185 185
     {
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
      * If the value is invalid, the old value is used, and an error message is
202 202
      * saved into the errors array as component_name => error_message.
203 203
      * 
204
-     * @param UI\AbstractComponent $component The component to validate.
204
+     * @param ValueComponentInterface $component The component to validate.
205 205
      */
206 206
     private function validate( $component )
207 207
     {
Please login to merge, or discard this patch.
Template.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -90,8 +90,7 @@
 block discarded – undo
90 90
             ob_start();
91 91
             include( $this->get_template_path() );
92 92
             $rendered_html = ob_get_clean();
93
-        } 
94
-        else 
93
+        } else 
95 94
         {
96 95
             throw new \RuntimeException( "Error: cannot render HTML, template file not found at " . $this->get_template_path() );
97 96
         }
Please login to merge, or discard this patch.
components/composite/controller.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -123,7 +123,7 @@
 block discarded – undo
123 123
     /**
124 124
      * 
125 125
      * @param type $args
126
-     * @return type
126
+     * @return AbstractComponent
127 127
      */
128 128
     private function create_component( $args )
129 129
     {
Please login to merge, or discard this patch.
components/switch/controller.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
      * handle this.
44 44
      *
45 45
      * @param [string] $v
46
-     * @return void
46
+     * @return string
47 47
      */
48 48
     public function filter($v)
49 49
     {
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,9 @@
 block discarded – undo
47 47
      */
48 48
     public function filter($v)
49 49
     {
50
-        if($v !== 'on') return 'off';
50
+        if($v !== 'on') {
51
+            return 'off';
52
+        }
51 53
         return 'on';
52 54
     }
53 55
 }
54 56
\ No newline at end of file
Please login to merge, or discard this patch.
components/slider/controller.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
      * will handle this.
46 46
      *
47 47
      * @param [string] $v
48
-     * @return void
48
+     * @return double
49 49
      */
50 50
     public function filter($v)
51 51
     {
Please login to merge, or discard this patch.
ComponentList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -159,7 +159,7 @@
 block discarded – undo
159 159
     /**
160 160
      * Filter the list of components
161 161
      *
162
-     * @param function $callable
162
+     * @param \Closure $callable
163 163
      * @return array
164 164
      */
165 165
     private function filter( $callable )
Please login to merge, or discard this patch.