Amarkal\UI\Component_number

Complexity

Total Complexity

10

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	default_model()	0	17	1
A	filter()	0	4	1
B	validation()	0	17	6
A	required_arguments()	0	4	1
A	get_template_path()	0	4	1

<?php

namespace Amarkal\UI;

/**
 * Implements a number UI component.
 */
class Component_number
extends AbstractComponent

The extends keyword must be on the same line as the class name

implements ValueComponentInterface, 

The implements keyword must be on the same line as the class name

The first item in a multi-line implements list must be on the line following the implements keyword

           DisableableComponentInterface,

Expected 4 spaces before interface name; 11 found

           FilterableComponentInterface,

Expected 4 spaces before interface name; 11 found

           ValidatableComponentInterface

Expected 4 spaces before interface name; 11 found

{
    public function default_model() 
    {
        return array(
            'name'          => '',
            'id'            => '',
            'disabled'      => false,
            'size'          => null,
            'min'           => null,
            'max'           => null,
            'step'          => null,
            'required'      => false,
            'readonly'      => false,
            'default'       => null,
            'filter'        => array( $this, 'filter' ),
            'validation'    => array( $this, 'validation' )
        );
    }
    
    public function filter($v)
    {
        return floatval($v);
    }
    
    public function validation($v,&$e)
    {
        $max = $this->max;

The property max does not exist on object<Amarkal\UI\Component_number>. Since you implemented __set, maybe consider adding a @property annotation.

        $min = $this->min;

The property min does not exist on object<Amarkal\UI\Component_number>. Since you implemented __set, maybe consider adding a @property annotation.

        
        if(null !== $max && $v > $max)
        {
            $e = "must be less than {$max}";
        }

        if(null !== $min && $v < $min) 
        {
            $e = "must be greater than {$min}";
        }

        return $e ? false : true;
    }
    
    public function required_arguments()
    {
        return array('name');
    }
    
    public function get_template_path() 
    {
        return __DIR__.'/template.phtml';
    }
}