amarkal / amarkal-ui

components/select/controller.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
     
     public function required_arguments()
     {
-        return array('name','data');
+        return array('name', 'data');
     }
     
     public function get_template_path() 

composer.php

Spacing +1 added lines, -1 removed lines

@@ -6,7 +6,7 @@
  */
 
 // Prevent direct file access
-defined( 'ABSPATH' ) or die( 'No script kiddies please!' );
+defined('ABSPATH') or die('No script kiddies please!');
 
 // Load module functions
 require_once 'functions.php';
\ No newline at end of file

ComponentFactory.php

Doc Comments +4 added lines, -4 removed lines

@@ -52,8 +52,8 @@ 
     
     /**
      * 
-     * @param type $type
-     * @param type $props
+     * @param string $type
+     * @param type string
      * @throws \RuntimeException
      */
     private static function create_core_component( $type, $props )
@@ -79,8 +79,8 @@ 
     
     /**
      * 
-     * @param type $type
-     * @param type $props
+     * @param string $type
+     * @param type string
      * @throws \RuntimeException
      */
     private static function create_registered_component( $type, $props )

Spacing +8 added lines, -8 removed lines

@@ -20,7 +20,7 @@ 
      * @param array $props
      * @return AbstractComponent
      */
-    public static function create( $type, array $props )
+    public static function create($type, array $props)
     {
         try {
             $component = self::create_registered_component($type, $props);
@@ -41,9 +41,9 @@ 
      * @param string $class_name
      * @throws \RuntimeException
      */
-    public static function register( $type, $class_name )
+    public static function register($type, $class_name)
     {
-        if( !in_array($type, self::$registered_components) )
+        if (!in_array($type, self::$registered_components))
         {
             self::$registered_components[$type] = $class_name;
         }
@@ -56,15 +56,15 @@ 
      * @param type $props
      * @throws \RuntimeException
      */
-    private static function create_core_component( $type, $props )
+    private static function create_core_component($type, $props)
     {
         $file_name  = __DIR__."/components/$type/controller.php";
         $class_name = 'Amarkal\\UI\\Component_'.$type;
         
         // Load one of the core components
-        if(!class_exists($class_name))
+        if (!class_exists($class_name))
         {
-            if( file_exists( $file_name ) ) 
+            if (file_exists($file_name)) 
             {
                 require_once $file_name;
             }
@@ -83,9 +83,9 @@ 
      * @param type $props
      * @throws \RuntimeException
      */
-    private static function create_registered_component( $type, $props )
+    private static function create_registered_component($type, $props)
     {
-        if(in_array($type, self::$registered_components))
+        if (in_array($type, self::$registered_components))
         {
             $class_name = self::$registered_components[$type];
             return new $class_name($props);

bootstrap.php

Spacing +2 added lines, -2 removed lines

@@ -6,13 +6,13 @@
  */
 
 // Prevent direct file access
-defined( 'ABSPATH' ) or die( 'No script kiddies please!' );
+defined('ABSPATH') or die('No script kiddies please!');
 
 /**
  * Load module functions. If this amarkal module has not been loaded, 
  * functions.php will not return false.
  */
-if(false !== (require_once 'functions.php'))
+if (false !== (require_once 'functions.php'))
 {
     // Load required classes if not using composer
     require_once 'AbstractComponent.php';

components/composite/controller.php

Doc Comments +1 added lines, -1 removed lines

@@ -123,7 +123,7 @@
     /**
      * 
      * @param type $args
-     * @return type
+     * @return AbstractComponent
      */
     private function create_component( $args )
     {

Spacing +21 added lines, -21 removed lines

@@ -25,16 +25,16 @@ 
      * The __set magic method is overridden here to apply value & name changes to 
      * child components.
      */
-    public function __set( $name, $value )
+    public function __set($name, $value)
     {
         parent::__set($name, $value);
         
-        if( 'value' === $name )
+        if ('value' === $name)
         {
             $this->set_value($value);
         }
 
-        if( 'name' === $name )
+        if ('name' === $name)
         {
             $this->set_name($value);
         }
@@ -46,9 +46,9 @@ 
      * @param array $value
      * @return void
      */
-    public function set_value( array $value )
+    public function set_value(array $value)
     {
-        foreach($value as $n => $v)
+        foreach ($value as $n => $v)
         {
             $component = $this->get_component($n);
             $component->value = $v;
@@ -61,9 +61,9 @@ 
      * @param string $name
      * @return void
      */
-    public function set_name( $name )
+    public function set_name($name)
     {
-        foreach($this->components as $c)
+        foreach ($this->components as $c)
         {
             $c->name_template = str_replace('{{parent_name}}', $this->get_name(), $c->composite_name_template);
         }
@@ -92,7 +92,7 @@ 
      */
     public function required_arguments()
     {
-        return array('name','components','template');
+        return array('name', 'components', 'template');
     }
     
     /**
@@ -126,7 +126,7 @@ 
      */
     public function get_name()
     {
-        if('' !== $this->parent_name)
+        if ('' !== $this->parent_name)
         {
             return "{$this->parent_name}[{$this->name}]";
         }
@@ -135,9 +135,9 @@ 
 
     public function filter($v)
     {
-        foreach($this->components as $component)
+        foreach ($this->components as $component)
         {
-            if($component instanceof FilterableComponentInterface &&
+            if ($component instanceof FilterableComponentInterface &&
                \is_callable($component->filter))
             {
                 $n = $component->name;
@@ -148,15 +148,15 @@ 
         return $v;
     }
 
-    public function validation($v,&$e)
+    public function validation($v, &$e)
     {
-        foreach($this->components as $component)
+        foreach ($this->components as $component)
         {
-            if($component instanceof ValidatableComponentInterface &&
+            if ($component instanceof ValidatableComponentInterface &&
                \is_callable($component->validation))
             {
                 $n = $component->name;
-                if(!$component->validation($v[$n],$e))
+                if (!$component->validation($v[$n], $e))
                 {
                     return false;
                 }
@@ -172,9 +172,9 @@ 
      * @return UI\AbstractComponent
      * @throws \RuntimeException If there's no child component corresponding to the given name
      */
-    public function get_component( $name )
+    public function get_component($name)
     {
-        if(!array_key_exists($name, $this->components))
+        if (!array_key_exists($name, $this->components))
         {
             throw new \RuntimeException("Composite sub-component not found with name $name");
         }
@@ -186,7 +186,7 @@ 
      */
     protected function on_created()
     {
-        foreach( $this->model['components'] as $args )
+        foreach ($this->model['components'] as $args)
         {
             $this->components[$args['name']] = $this->create_component($args);
         }
@@ -197,16 +197,16 @@ 
      * @param type $args
      * @return type
      */
-    private function create_component( $args )
+    private function create_component($args)
     {
         $type = $args['type'];
         
-        if('composite' === $type)
+        if ('composite' === $type)
         {
             $args['parent_name'] = $this->get_name();
         }
         
-        $c = \Amarkal\UI\ComponentFactory::create( $type, $args );
+        $c = \Amarkal\UI\ComponentFactory::create($type, $args);
         
         // Apply the composite name template
         $c->name_template = str_replace('{{parent_name}}', $this->get_name(), $c->composite_name_template);

components/switch/controller.php

Doc Comments +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
      * handle this.
      *
      * @param [string] $v
-     * @return void
+     * @return string
      */
     public function filter($v)
     {

Spacing +2 added lines, -2 removed lines

@@ -21,7 +21,7 @@ 
             'disabled'      => false,
             'readonly'      => false,
             'default'       => null,
-            'filter'        => array( $this, 'filter' ),
+            'filter'        => array($this, 'filter'),
             'show'          => null
         );
     }
@@ -47,7 +47,7 @@ 
      */
     public function filter($v)
     {
-        if($v !== 'on') return 'off';
+        if ($v !== 'on') return 'off';
         return 'on';
     }
 }
\ No newline at end of file

components/slider/controller.php

Doc Comments +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
      * will handle this.
      *
      * @param [string] $v
-     * @return void
+     * @return double
      */
     public function filter($v)
     {

Spacing +2 added lines, -2 removed lines

@@ -25,14 +25,14 @@
             'min'           => null,
             'max'           => null,
             'step'          => 1,
-            'filter'        => array( $this, 'filter' ),
+            'filter'        => array($this, 'filter'),
             'show'          => null
         );
     }
     
     public function required_arguments()
     {
-        return array('name','min','max');
+        return array('name', 'min', 'max');
     }
     
     public function get_template_path() 

components/button/controller.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
     
     public function required_arguments()
     {
-        return array('request_url','label_start');
+        return array('request_url', 'label_start');
     }
     
     public function get_template_path() 

ComponentList.php

Doc Comments +1 added lines, -1 removed lines

@@ -159,7 +159,7 @@
     /**
      * Filter the list of components
      *
-     * @param function $callable
+     * @param \Closure $callable
      * @return array
      */
     private function filter( $callable )

Spacing +12 added lines, -12 removed lines

@@ -19,7 +19,7 @@ 
      *
      * @param array $components
      */
-    public function __construct( array $components = array() )
+    public function __construct(array $components = array())
     {
         $this->add_components($components);
     }
@@ -30,12 +30,12 @@ 
      * @param string $name
      * @return AbstractComponent
      */
-    public function get_by_name( $name )
+    public function get_by_name($name)
     {
         $filtered = $this->filter(function($c) use ($name) {
             return $c instanceof ValueComponentInterface && $c->name === $name;
         });
-        if(count($filtered) < 1)
+        if (count($filtered) < 1)
         {
             throw new \RuntimeException("No component with the name <b>$name</b> could be found.");
         }
@@ -48,7 +48,7 @@ 
      * @param string $type
      * @return AbstractComponent[]
      */
-    public function get_by_type( $type )
+    public function get_by_type($type)
     {
         return $this->filter(function($c) use ($type) {
             return $c->component_type === $type;
@@ -107,9 +107,9 @@ 
      * @param AbstractComponent[] $components
      * @return void
      */
-    public function add_components( array $components )
+    public function add_components(array $components)
     {
-        foreach( $components as $component )
+        foreach ($components as $component)
         {
             $this->add_component($component);
         }
@@ -121,9 +121,9 @@ 
      * @param AbstractComponent[] $args
      * @return void
      */
-    public function add_component( array $args )
+    public function add_component(array $args)
     {
-        if(!array_key_exists('type', $args))
+        if (!array_key_exists('type', $args))
         {
             throw new \RuntimeException("Component configuration arrays must have a <b>type</b> argument");
         }
@@ -140,16 +140,16 @@ 
      * @param AbstractComponent $comp
      * @return void
      */
-    private function verify_name_uniqueness( AbstractComponent $comp )
+    private function verify_name_uniqueness(AbstractComponent $comp)
     {
-        if(!($comp instanceof ValueComponentInterface))
+        if (!($comp instanceof ValueComponentInterface))
         {
             return;
         }
 
         foreach ($this->components as $c) 
         {
-            if($c->name === $comp->name)
+            if ($c->name === $comp->name)
             {
                 throw new \RuntimeException("Duplicate component name detected for the name <b>{$c->name}</b>.");
             }
@@ -162,7 +162,7 @@ 
      * @param function $callable
      * @return array
      */
-    private function filter( $callable )
+    private function filter($callable)
     {
         // array_values is needed in order to reindex the array after filtering it
         return array_values(array_filter($this->components, $callable));