Component_number - Code Metrics - Inspection of "Added support for form data processing" - amarkal/amarkal-ui - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ead358...de8c68 )

by Askupa

created 2017-04-10 06:28 UTC

Component_number A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	57
Duplicated Lines	17.54 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	10
loc	57
rs	10
wmc	9
lcom	0
cbo	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	default_model()	0	17	1
A	filter()	0	4	1
B	validation()	10	16	5
A	required_arguments()	0	4	1
A	get_template_path()	0	4	1

How to fix Duplicated Code

<?php

namespace Amarkal\UI;

/**
 * Implements a number UI component.
 */
class Component_number
extends AbstractComponent

implements ValueComponentInterface, 

           DisableableComponentInterface,

           FilterableComponentInterface,

           ValidatableComponentInterface

{
    public function default_model() 
    {
        return array(
            'name'          => '',
            'id'            => '',
            'disabled'      => false,
            'size'          => null,
            'min'           => null,
            'max'           => null,
            'step'          => null,
            'required'      => false,
            'readonly'      => false,
            'default'       => null,
            'filter'        => array( $this, 'filter' ),
            'validation'    => array( $this, 'validation' )
        );
    }
    
    public function filter($v)
    {
        return floatval($v);
    }
    
    public function validation($v,&$e)
    {
        if(null !== $this->max && $v > $this->max) 
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        {
            $e = "must be less than {$this->max}";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return false;
        }

        if(null !== $this->min && $v < $this->min) 
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        {
            $e = "must be greater than {$this->min}";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return false;
        }

        return true;
    }
    
    public function required_arguments()
    {
        return array('name');
    }
    
    public function get_template_path() 
    {
        return __DIR__.'/template.phtml';
    }
}

1		<?php
2
3		namespace Amarkal\UI;
4
5		/**
6		* Implements a number UI component.
7		*/
8		class Component_number
9		extends AbstractComponent
		0 ignored issues – show Coding Style introduced 2017-03-23 21:00 UTC by Report Bug Copy Issue Report The extends keyword must be on the same line as the class name Loading history...
10		implements ValueComponentInterface,
		0 ignored issues – show Coding Style introduced 2017-04-10 06:30 UTC by Report Bug Copy Issue Report The implements keyword must be on the same line as the class name Loading history... Coding Style introduced 2017-04-10 06:30 UTC by Report Bug Copy Issue Report The first item in a multi-line implements list must be on the line following the implements keyword Loading history...
11		DisableableComponentInterface,
		0 ignored issues – show Coding Style introduced 2017-04-10 06:30 UTC by Report Bug Copy Issue Report Expected 4 spaces before interface name; 11 found Loading history...
12		FilterableComponentInterface,
		0 ignored issues – show Coding Style introduced 2017-04-10 06:30 UTC by Report Bug Copy Issue Report Expected 4 spaces before interface name; 11 found Loading history...
13		ValidatableComponentInterface
		0 ignored issues – show Coding Style introduced 2017-04-10 06:30 UTC by Report Bug Copy Issue Report Expected 4 spaces before interface name; 11 found Loading history...
14		{
15		public function default_model()
16		{
17		return array(
18		'name' => '',
19		'id' => '',
20		'disabled' => false,
21		'size' => null,
22		'min' => null,
23		'max' => null,
24		'step' => null,
25		'required' => false,
26		'readonly' => false,
27		'default' => null,
28		'filter' => array( $this, 'filter' ),
29		'validation' => array( $this, 'validation' )
30		);
31		}
32
33		public function filter($v)
34		{
35		return floatval($v);
36		}
37
38		public function validation($v,&$e)
39		{
40	View Code Duplication	if(null !== $this->max && $v > $this->max)
		0 ignored issues – show Documentation introduced 2017-04-10 06:30 UTC by Report Bug Copy Issue Report The property `max` does not exist on `object<Amarkal\UI\Component_number>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Duplication introduced 2017-04-10 06:30 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
41		{
42		$e = "must be less than {$this->max}";
		0 ignored issues – show Documentation introduced 2017-04-10 06:30 UTC by Report Bug Copy Issue Report The property `max` does not exist on `object<Amarkal\UI\Component_number>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
43		return false;
44		}
45
46	View Code Duplication	if(null !== $this->min && $v < $this->min)
		0 ignored issues – show Documentation introduced 2017-04-10 06:30 UTC by Report Bug Copy Issue Report The property `min` does not exist on `object<Amarkal\UI\Component_number>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Duplication introduced 2017-04-10 06:30 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
47		{
48		$e = "must be greater than {$this->min}";
		0 ignored issues – show Documentation introduced 2017-04-10 06:30 UTC by Report Bug Copy Issue Report The property `min` does not exist on `object<Amarkal\UI\Component_number>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
49		return false;
50		}
51
52		return true;
53		}
54
55		public function required_arguments()
56		{
57		return array('name');
58		}
59
60		public function get_template_path()
61		{
62		return __DIR__.'/template.phtml';
63		}
64		}

amarkal / amarkal-ui

Push — master ( ead358...de8c68 )

Component_number A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like