Component_number::validation() - Code Metrics - amarkal/amarkal-ui - Measure and Improve Code Quality continuously with Scrutinizer

Component_number::validation() B
last analyzed 2017-12-31 22:00 UTC

↳ Parent: Component_number

Complexity

Conditions	6
Paths	8

Size

Total Lines	17
Code Lines	8

Duplication

Lines	8
Ratio	47.06 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	6
eloc	8
c	1
b	0
f	0
nc	8
nop	2
dl	8
loc	17
rs	8.8571

<?php

namespace Amarkal\UI;

/**
 * Implements a number UI component.
 */
class Component_number
extends AbstractComponent

implements ValueComponentInterface, 

           DisableableComponentInterface,

           FilterableComponentInterface,

           ValidatableComponentInterface

{
    public $component_type = 'number';
    
    public function default_model() 
    {
        return array(
            'name'          => '',
            'id'            => '',
            'disabled'      => false,
            'size'          => null,
            'min'           => null,
            'max'           => null,
            'step'          => null,
            'required'      => false,
            'readonly'      => false,
            'default'       => null,
            'filter'        => array( $this, 'filter' ),
            'validation'    => array( $this, 'validation' ),
            'show'          => null
        );
    }
    
    public function filter($v)
    {
        return floatval($v);
    }
    
    public function validation($v,&$e)
    {
        $max = $this->max;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $min = $this->min;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        
        if(null !== $max && $v > $max)

        {
            $e = sprintf( __("Value must be less than %d",'amarkal'), $max);
        }

        if(null !== $min && $v < $min) 

        {
            $e = sprintf( __("Value must be greater than %d",'amarkal'), $min);
        }

        return $e ? false : true;
    }
    
    public function required_arguments()
    {
        return array('name');
    }
    
    public function get_template_path() 
    {
        return __DIR__.'/template.phtml';
    }
}

1		<?php
2
3		namespace Amarkal\UI;
4
5		/**
6		* Implements a number UI component.
7		*/
8		class Component_number
9		extends AbstractComponent
		0 ignored issues – show Coding Style introduced 2017-04-20 18:39 UTC by Report Bug Copy Issue Report The extends keyword must be on the same line as the class name Loading history...
10		implements ValueComponentInterface,
		0 ignored issues – show Coding Style introduced 2017-04-05 13:47 UTC by Report Bug Copy Issue Report The implements keyword must be on the same line as the class name Loading history... Coding Style introduced 2017-04-05 13:47 UTC by Report Bug Copy Issue Report The first item in a multi-line implements list must be on the line following the implements keyword Loading history...
11		DisableableComponentInterface,
		0 ignored issues – show Coding Style introduced 2017-04-05 13:47 UTC by Report Bug Copy Issue Report Expected 4 spaces before interface name; 11 found Loading history...
12		FilterableComponentInterface,
		0 ignored issues – show Coding Style introduced 2017-04-05 13:47 UTC by Report Bug Copy Issue Report Expected 4 spaces before interface name; 11 found Loading history...
13		ValidatableComponentInterface
		0 ignored issues – show Coding Style introduced 2017-04-10 06:30 UTC by Report Bug Copy Issue Report Expected 4 spaces before interface name; 11 found Loading history...
14		{
15		public $component_type = 'number';
16
17		public function default_model()
18		{
19		return array(
20		'name' => '',
21		'id' => '',
22		'disabled' => false,
23		'size' => null,
24		'min' => null,
25		'max' => null,
26		'step' => null,
27		'required' => false,
28		'readonly' => false,
29		'default' => null,
30		'filter' => array( $this, 'filter' ),
31		'validation' => array( $this, 'validation' ),
32		'show' => null
33		);
34		}
35
36		public function filter($v)
37		{
38		return floatval($v);
39		}
40
41		public function validation($v,&$e)
42		{
43		$max = $this->max;
		0 ignored issues – show Documentation introduced 2017-04-21 18:27 UTC by Report Bug Copy Issue Report The property `max` does not exist on `object<Amarkal\UI\Component_number>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
44		$min = $this->min;
		0 ignored issues – show Documentation introduced 2017-04-21 18:27 UTC by Report Bug Copy Issue Report The property `min` does not exist on `object<Amarkal\UI\Component_number>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
45
46	View Code Duplication	if(null !== $max && $v > $max)
		0 ignored issues – show Duplication introduced 2017-05-21 04:19 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
47		{
48		$e = sprintf( __("Value must be less than %d",'amarkal'), $max);
49		}
50
51	View Code Duplication	if(null !== $min && $v < $min)
		0 ignored issues – show Duplication introduced 2017-05-21 04:19 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
52		{
53		$e = sprintf( __("Value must be greater than %d",'amarkal'), $min);
54		}
55
56		return $e ? false : true;
57		}
58
59		public function required_arguments()
60		{
61		return array('name');
62		}
63
64		public function get_template_path()
65		{
66		return __DIR__.'/template.phtml';
67		}
68		}

amarkal / amarkal-ui

Component_number::validation() B last analyzed 2017-12-31 22:00 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Component_number::validation() B
last analyzed 2017-12-31 22:00 UTC