Issues in EditField.php - All Issues - Inspection of "Fixed manual bootstrapping issues" - amarkal/amarkal-taxonomy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 544bdf...d3e666 )

by Askupa

created 2017-03-26 22:10 UTC

EditField.php (3 issues)

Labels

Severity

Informational 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Amarkal\Taxonomy;

class EditField
extends \Amarkal\UI\AbstractComponent

{
    public function default_model() 
    {
        return array(
            'type'          => '',
            'label'         => '',
            'description'   => ''
        );
    }
    
    protected function on_created() 
    {
        $this->model['value'] = \get_term_meta($this->term_id, $this->name, true);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
    
    public function get_template_path()
    {
        return __DIR__.'/EditField.phtml';
    }
}

1			<?php
2
3			namespace Amarkal\Taxonomy;
4
5			class EditField
6			extends \Amarkal\UI\AbstractComponent
			0 ignored issues – show Coding Style introduced 2017-03-21 18:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The extends keyword must be on the same line as the class name Loading history...
7			{
8			public function default_model()
9			{
10			return array(
11			'type' => '',
12			'label' => '',
13			'description' => ''
14			);
15			}
16
17			protected function on_created()
18			{
19			$this->model['value'] = \get_term_meta($this->term_id, $this->name, true);
			0 ignored issues – show Documentation introduced 2017-03-23 03:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `term_id` does not exist on `object<Amarkal\Taxonomy\EditField>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2017-03-23 03:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `name` does not exist on `object<Amarkal\Taxonomy\EditField>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
20			}
21
22			public function get_template_path()
23			{
24			return __DIR__.'/EditField.phtml';
25			}
26			}

amarkal / amarkal-taxonomy

Push — master ( 544bdf...d3e666 )

EditField.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like