Issues in sections.js (master) - Issues in master - amarkal/amarkal-settings - Measure and Improve Code Quality continuously with Scrutinizer

Issues (72)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

assets/js/src/sections.js (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

Amarkal.settings.sections = {

    $links: null,
    $loader: null,
    data: null,
    activeSection: null,
    init: function() {
        this.data = JSON.parse($('#sections-config').text());
        this.$links = $('.amarkal-settings-sections li');
        this.$loader = $('#amarkal-settings-loader');
        this.$form = $('#amarkal-settings-form');
        this.$fields = this.$form.find('.amarkal-settings-field');

        this.initSections();
    },
    initSections: function() {
        if(typeof this.data === 'object' && Object.keys(this.data).length > 0) {
            var _this = this;
            this.$links.on('click', function(){
                _this.activate($(this).attr('data-slug'));
            });
            this.activateInitialSection();
            this.$loader.hide();
        }
        else {
            Amarkal.settings.fields.showAll();

        }
    },
    activateInitialSection: function() {
        if('' !== window.location.hash) {
            this.activate(window.location.hash.substring(1));
        }
        else {
            this.activate($(this.$links[0]).attr('data-slug'));
        }
    },
    activate: function(sectionSlug) {
        if(this.activeSection === sectionSlug) {
            return;
        }
        this.activeSection = sectionSlug;

        this.$links
            .removeClass('active')
            .filter('[data-slug="'+sectionSlug+'"]')
            .addClass('active');

        Amarkal.settings.header.setSectionTitle(this.getTitle(sectionSlug));

        Amarkal.settings.header.setSectionSubtitle(this.getSubtitle(sectionSlug));
        Amarkal.settings.fields.hideAll();
        Amarkal.settings.fields.show(this.getSectionFields(sectionSlug));

        window.location = '#'+sectionSlug;
    },
    deactivate: function() {
        var sectionSlug = this.activeSection;

        this.$links.removeClass('active');
        Amarkal.settings.fields.hideAll();

        this.activeSection = null;
    },
    flag: function(type, slug) {
        this.$links.filter('[data-slug="'+slug+'"]').addClass('flag-'+type);
    },
    unflag: function(type, slug) {
        this.$links.filter('[data-slug="'+slug+'"]').removeClass('flag-'+type);
    },
    unflagAll: function() {
        this.$links.removeClass('flag-error flag-notice');
    },
    getTitle: function(slug) {
        return this.data[slug].title;
    },
    getSubtitle: function(slug) {
        return this.data[slug].subtitle;
    },
    getSectionFields: function(slug) {
        return this.$fields.filter('[data-section="'+slug+'"]');
    },
    changed: function(slug) {
        var changed = false;
        this.getSectionFields(slug).each(function(){
            if($(this).find('.amarkal-ui-component').amarkalUIComponent('changed')) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
                changed = true;
                return false;
            }
        });
        return changed;
    }
};

1			Amarkal.settings.sections = {
			0 ignored issues – show Bug introduced 2017-08-18 16:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `Amarkal` seems to be never declared. If this is a global, consider adding a `/** global: Amarkal */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
2			$links: null,
3			$loader: null,
4			data: null,
5			activeSection: null,
6			init: function() {
7			this.data = JSON.parse($('#sections-config').text());
8			this.$links = $('.amarkal-settings-sections li');
9			this.$loader = $('#amarkal-settings-loader');
10			this.$form = $('#amarkal-settings-form');
11			this.$fields = this.$form.find('.amarkal-settings-field');
12
13			this.initSections();
14			},
15			initSections: function() {
16			if(typeof this.data === 'object' && Object.keys(this.data).length > 0) {
17			var _this = this;
18			this.$links.on('click', function(){
19			_this.activate($(this).attr('data-slug'));
20			});
21			this.activateInitialSection();
22			this.$loader.hide();
23			}
24			else {
25			Amarkal.settings.fields.showAll();
			0 ignored issues – show Bug introduced 2017-08-26 22:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `Amarkal` seems to be never declared. If this is a global, consider adding a `/** global: Amarkal */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
26			}
27			},
28			activateInitialSection: function() {
29			if('' !== window.location.hash) {
30			this.activate(window.location.hash.substring(1));
31			}
32			else {
33			this.activate($(this.$links[0]).attr('data-slug'));
34			}
35			},
36			activate: function(sectionSlug) {
37			if(this.activeSection === sectionSlug) {
38			return;
39			}
40			this.activeSection = sectionSlug;
41
42			this.$links
43			.removeClass('active')
44			.filter('[data-slug="'+sectionSlug+'"]')
45			.addClass('active');
46
47			Amarkal.settings.header.setSectionTitle(this.getTitle(sectionSlug));
			0 ignored issues – show Bug introduced 2017-08-18 16:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `Amarkal` seems to be never declared. If this is a global, consider adding a `/** global: Amarkal */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
48			Amarkal.settings.header.setSectionSubtitle(this.getSubtitle(sectionSlug));
49			Amarkal.settings.fields.hideAll();
50			Amarkal.settings.fields.show(this.getSectionFields(sectionSlug));
51
52			window.location = '#'+sectionSlug;
53			},
54			deactivate: function() {
55			var sectionSlug = this.activeSection;
			0 ignored issues – show Unused Code introduced 2017-08-18 16:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `sectionSlug` seems to be never used. Consider removing it. Loading history...
56			this.$links.removeClass('active');
57			Amarkal.settings.fields.hideAll();
			0 ignored issues – show Bug introduced 2017-08-26 22:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `Amarkal` seems to be never declared. If this is a global, consider adding a `/** global: Amarkal */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
58			this.activeSection = null;
59			},
60			flag: function(type, slug) {
61			this.$links.filter('[data-slug="'+slug+'"]').addClass('flag-'+type);
62			},
63			unflag: function(type, slug) {
64			this.$links.filter('[data-slug="'+slug+'"]').removeClass('flag-'+type);
65			},
66			unflagAll: function() {
67			this.$links.removeClass('flag-error flag-notice');
68			},
69			getTitle: function(slug) {
70			return this.data[slug].title;
71			},
72			getSubtitle: function(slug) {
73			return this.data[slug].subtitle;
74			},
75			getSectionFields: function(slug) {
76			return this.$fields.filter('[data-section="'+slug+'"]');
77			},
78			changed: function(slug) {
79			var changed = false;
80			this.getSectionFields(slug).each(function(){
81			if($(this).find('.amarkal-ui-component').amarkalUIComponent('changed')) {
			0 ignored issues – show Complexity Best Practice introduced 2017-12-08 14:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no return statement if `$(this).find(".amarkal-u...lUIComponent("changed")` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
82			changed = true;
83			return false;
84			}
85			});
86			return changed;
87			}
88			};

amarkal / amarkal-settings

Issues (72)

Security Analysis no request data

assets/js/src/sections.js (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like