Issues in Manager.php - All Issues - Inspection of "Added a basic readme file" - amarkal/amarkal-settings - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1d5718...95de79 )

by Askupa

created 2017-04-17 00:32 UTC

Manager.php (5 issues)

Labels

Severity

Major 5

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Amarkal\Settings;

class Manager
{
    /**
     * @var Singleton The reference to *Singleton* instance of this class
     */
    private static $instance;
    
    private $pages = array();
    
    private $subpages = array();
    
    /**
     * Returns the *Singleton* instance of this class.
     *
     * @return Singleton The *Singleton* instance.
     */
    public static function get_instance()
    {
        if( null === static::$instance ) 
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
        {
            static::$instance = new static();
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
        }
        return static::$instance;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
    }
    
    public function add_page($args)
    {
        $slug = $args['slug'];
        if(array_key_exists($slug,$this->pages))
        {
            throw new \RuntimeException("A page with slug '$slug' has already been registered");
        }
        $this->pages[$slug] = new Page($args);
    }
    
    public function add_subpage($args)
    {
        $this->subpages[] = new SubPage($args);
    }
    
    public function register_settings()
    {
        register_setting( 'myoption-group', 'new_option_name' );
        register_setting( 'myoption-group', 'some_other_option' );
        register_setting( 'myoption-group', 'option_etc' );
    }
    
    public function register_scripts()
    {
        \wp_register_style('amarkal-settings',$this->get_url(__DIR__.'/assets/css/style.min.css'));
    }
    
    /**
     * Private constructor to prevent instantiation
     */
    private function __construct() 
    {
        $this->init();
    }
    
    private function init()
    {
        \add_action('admin_init',array($this,'register_scripts'));
    }
    
    private function get_url( $path )
    {
        $url  = str_replace( ABSPATH, '', $path );
        return esc_url_raw( site_url( $url ) );
    }
}

1			<?php
2
3			namespace Amarkal\Settings;
4
5			class Manager
6			{
7			/**
8			* @var Singleton The reference to Singleton instance of this class
9			*/
10			private static $instance;
11
12			private $pages = array();
13
14			private $subpages = array();
15
16			/**
17			* Returns the Singleton instance of this class.
18			*
19			* @return Singleton The Singleton instance.
20			*/
21			public static function get_instance()
22			{
23			if( null === static::$instance )
			0 ignored issues – show Bug introduced 2017-04-17 00:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
24			{
25			static::$instance = new static();
			0 ignored issues – show Bug introduced 2017-04-17 00:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history... Documentation Bug introduced 2017-04-17 00:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `new static()` of type `this<Amarkal\Settings\Manager>` is incompatible with the declared type `object<Amarkal\Settings\Singleton>` of property `$instance`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
26			}
27			return static::$instance;
			0 ignored issues – show Bug introduced 2017-04-17 00:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history... Bug Compatibility introduced 2017-04-17 00:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `static::$instance;` of type `Amarkal\Settings\Manager...rkal\Settings\Singleton` adds the type `Amarkal\Settings\Manager` to the return on line 27 which is incompatible with the return type documented by `Amarkal\Settings\Manager::get_instance` of type `Amarkal\Settings\Singleton`. Loading history...
28			}
29
30			public function add_page($args)
31			{
32			$slug = $args['slug'];
33			if(array_key_exists($slug,$this->pages))
34			{
35			throw new \RuntimeException("A page with slug '$slug' has already been registered");
36			}
37			$this->pages[$slug] = new Page($args);
38			}
39
40			public function add_subpage($args)
41			{
42			$this->subpages[] = new SubPage($args);
43			}
44
45			public function register_settings()
46			{
47			register_setting( 'myoption-group', 'new_option_name' );
48			register_setting( 'myoption-group', 'some_other_option' );
49			register_setting( 'myoption-group', 'option_etc' );
50			}
51
52			public function register_scripts()
53			{
54			\wp_register_style('amarkal-settings',$this->get_url(__DIR__.'/assets/css/style.min.css'));
55			}
56
57			/**
58			* Private constructor to prevent instantiation
59			*/
60			private function __construct()
61			{
62			$this->init();
63			}
64
65			private function init()
66			{
67			\add_action('admin_init',array($this,'register_scripts'));
68			}
69
70			private function get_url( $path )
71			{
72			$url = str_replace( ABSPATH, '', $path );
73			return esc_url_raw( site_url( $url ) );
74			}
75			}

amarkal / amarkal-settings

Push — master ( 1d5718...95de79 )

Manager.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like