Amarkal\Settings\SubPage

Complexity

Total Complexity

6

Size/Duplication

Total Lines	53
Duplicated Lines	39.62 %

Coupling/Cohesion

Components	2
Dependencies	1

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	add_submenu_page()	11	11	1
A	enqueue_scripts()	0	8	2
A	render()	0	5	1
A	default_args()	10	10	1

<?php

namespace Amarkal\Settings;

class SubPage
{   

The opening class brace should be on a newline by itself.

    private $config;
    
    private $form;
    
    public function __construct( array $args = array() ) 
    {
        $this->config = array_merge($this->default_args(), $args);
        $this->form = new \Amarkal\UI\Form($this->config['fields']);
        
        \add_action('admin_menu', array($this,'add_submenu_page'));
        \add_action('admin_enqueue_scripts', array($this,'enqueue_scripts'));
    }
    
    public function add_submenu_page()

This method seems to be duplicated in your project.

    {
        \add_submenu_page(
            $this->config['parent_slug'], 
            $this->config['title'], 
            $this->config['menu_title'], 
            $this->config['capability'],
            $this->config['slug'],
            array($this, 'render')
        );
    }
    
    public function enqueue_scripts()
    {
        // Only enqueue styles & scripts if this is a settings page
        if($this->config['slug'] === filter_input(INPUT_GET, 'page'))
        {
            \wp_enqueue_style('amarkal-settings');
        }
    }
    
    public function render()
    {
        $this->form->update();
        include __DIR__.'/SubPage.phtml';
    }
    
    private function default_args()

This method seems to be duplicated in your project.

    {
        return array(
            'parent_slug' => '',
            'slug'        => '',
            'title'       => '',
            'menu_title'  => '',
            'capability'  => 'manage_options'
        );
    }
}