Page::__construct() - Code Metrics - Inspection of "Fixed search box issue, fixed validation feedback..." - amarkal/amarkal-settings - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4ff74f...939158 )

by Askupa

created 2017-05-17 00:16 UTC

Page::__construct() A

↳ Parent: Page

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	1
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0

<?php

namespace Amarkal\Settings;

class Page
{   

    private $config;
    
    public function __construct( array $args = array() ) 
    {
        $this->config = array_merge($this->default_args(), $args);
        
        \add_action('admin_menu', array($this,'add_menu_page'));
    }
    
    public function add_menu_page()

    {
        \add_menu_page(
            $this->config['title'], 
            $this->config['menu_title'], 
            $this->config['capability'], 
            $this->config['slug'], 
            null, // Create a child page with the parent_slug set to this page's slug
            $this->config['icon'],
            $this->config['position']
        );
    }
    
    private function default_args()
    {
        return array(
            'slug'       => '',
            'title'      => '',
            'menu_title' => '',
            'icon'       => '',
            'position'   => 10,
            'capability' => 'manage_options'
        );
    }
}

1		<?php
2
3		namespace Amarkal\Settings;
4
5		class Page
6		{
		0 ignored issues – show Coding Style introduced 2017-04-19 08:41 UTC by Report Bug Copy Issue Report The opening class brace should be on a newline by itself. Loading history...
7		private $config;
8
9		public function __construct( array $args = array() )
10		{
11		$this->config = array_merge($this->default_args(), $args);
12
13		\add_action('admin_menu', array($this,'add_menu_page'));
14		}
15
16	View Code Duplication	public function add_menu_page()
		0 ignored issues – show Duplication introduced 2017-04-17 00:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
17		{
18		\add_menu_page(
19		$this->config['title'],
20		$this->config['menu_title'],
21		$this->config['capability'],
22		$this->config['slug'],
23		null, // Create a child page with the parent_slug set to this page's slug
24		$this->config['icon'],
25		$this->config['position']
26		);
27		}
28
29		private function default_args()
30		{
31		return array(
32		'slug' => '',
33		'title' => '',
34		'menu_title' => '',
35		'icon' => '',
36		'position' => 10,
37		'capability' => 'manage_options'
38		);
39		}
40		}

amarkal / amarkal-settings

Push — master ( 4ff74f...939158 )

Page::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like