exports.settings.init - Code Metrics - Inspection of "Fixed search issue" - amarkal/amarkal-settings - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 794039...360e98 )

by Askupa

created 2017-10-29 20:27 UTC

exports.settings.init A

↳ Parent: exports.settings.init

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
nc	1
nop	2
dl	0
loc	6
rs	9.4285
c	1
b	0
f	0

var $ = window.jQuery;

exports.settings = {
    haveBeenModified: false,
    init: function() {
        $('.amarkal-ui-component').on('amarkal.change',function(e, component){
            Amarkal.settings.notifier.notice("Settings have changed, click \"Save\" to apply them.");

            Amarkal.settings.sections.flag('notice', component.props.section);
            Amarkal.settings.fields.flag('notice', component.props.name);
            Amarkal.settings.haveBeenModified = true;
        });
        $(window).on('beforeunload',function(){
            if(Amarkal.settings.haveBeenModified) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
                return 'Are you sure you want to leave this page?';
            }
        });
        Amarkal.settings.fields.init();
        Amarkal.settings.search.init();
        Amarkal.settings.sections.init();
    }
};

$(document).ready(function(){
    Amarkal.settings.init();

});


1			var $ = window.jQuery;
2
3			exports.settings = {
4			haveBeenModified: false,
5			init: function() {
6			$('.amarkal-ui-component').on('amarkal.change',function(e, component){
7			Amarkal.settings.notifier.notice("Settings have changed, click \"Save\" to apply them.");
			0 ignored issues – show Bug introduced 2017-10-29 20:28 UTC by Report Bug Copy Issue Report The variable `Amarkal` seems to be never declared. If this is a global, consider adding a `/** global: Amarkal */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
8			Amarkal.settings.sections.flag('notice', component.props.section);
9			Amarkal.settings.fields.flag('notice', component.props.name);
10			Amarkal.settings.haveBeenModified = true;
11			});
12			$(window).on('beforeunload',function(){
13			if(Amarkal.settings.haveBeenModified) {
			0 ignored issues – show Complexity Best Practice introduced 2017-08-26 22:34 UTC by Report Bug Copy Issue Report There is no return statement if `Amarkal.settings.haveBeenModified` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history... Bug introduced 2017-10-29 20:28 UTC by Report Bug Copy Issue Report The variable `Amarkal` seems to be never declared. If this is a global, consider adding a `/** global: Amarkal */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
14			return 'Are you sure you want to leave this page?';
15			}
16			});
17			Amarkal.settings.fields.init();
18			Amarkal.settings.search.init();
19			Amarkal.settings.sections.init();
20			}
21			};
22
23			$(document).ready(function(){
24			Amarkal.settings.init();
			0 ignored issues – show Bug introduced 2017-10-29 20:28 UTC by Report Bug Copy Issue Report The variable `Amarkal` seems to be never declared. If this is a global, consider adding a `/** global: Amarkal */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
25			});
26

amarkal / amarkal-settings

Push — master ( 794039...360e98 )

exports.settings.init A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like