View GitHub Repository amarkal-metabox

Schedule Inspection
Subscribe
Completed
Push — master ( 4487f0...44a470 )
by Askupa
01:52
created

bootstrap.php (2 issues)

← previous file next file →

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1 
<?php
2 
/**
3 
 * This file is used to manually include all required PHP files. If you are
4 
 * using composer as your dependency manager, you do not need to include this
5 
 * file as composer will include all neccessary files automatically.
6 
 */
7 

            


            
                                                        
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
// Prevent direct file access

            


            
                                                        
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
defined( 'ABSPATH' ) or die( 'No script kiddies please!' );

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Comprehensibility
            Best Practice
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
Using logical operators such as or instead of || is generally not recommended.
                                                                                                                                                    

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
PHP has two types of connecting operators (logical operators, and boolean operators):


 
Logical Operators
Boolean Operator

AND - meaning
and
&&

OR - meaning
or
||

The difference between these is the order in which they are executed. In most cases,
you would want to use a boolean operator like &&, or ||.


Let’s take a look at a few examples:


// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);







Logical Operators are used for Control-Flow


One case where you explicitly want to use logical operators is for control-flow
such as this:


$x === 5
    or die('$x must be 5.');

// Instead of
if ($x !== 5) {
    die('$x must be 5.');
}





Since die introduces problems of its own, f.e. it makes our code hardly
testable, and prevents any kind of more sophisticated error handling; you probably
do not want to use this in real-world code. Unfortunately, logical operators
cannot be combined with throw at this point:


// The following is currently a parse error.
$x === 5
    or throw new RuntimeException('$x must be 5.');





These limitations lead to logical operators rarely being of use in current
PHP code.




                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
/**

            


            
                                                        
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
 * Load module functions. If this amarkal module has not been loaded, 

            


            
                                                        
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
 * functions.php will not return false.

            


            
                                                        
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
 */

            


            
                                                        
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
if(false !== (require_once 'functions.php'))

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Unused Code
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
This if statement is empty and can be removed.
                                            

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This check looks for the bodies of  if statements that have no statements or where all statements
have been commented out. This may be the result of changes for debugging or the code
may simply be obsolete.


These if bodies can be removed. If you have an empty if but statements in the else
branch, consider inverting the condition.


if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}





could be turned into


if (rand(1, 6) <= 3) {
    print "Check succeeded";
}





This is much more concise to read.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
{

            


            
                                                        
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                
    // Load required classes if not using composer

            


            
                                                        
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
    

            


            
                                                        
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                
}