Issues in ExcelExportPunction.php (master) - Issues in master - amarcinkowski/hospitalplugin - Measure and Improve Code Quality continuously with Scrutinizer

Issues (100)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/utils/ExcelExportPunction.php (11 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Hospitalplugin\utils;

use Hospitalplugin\Entities\InfectionsCRUD;
use Hospitalplugin\Entities\Infections;
use Hospitalplugin\Entities\PatientRaport;
use Hospitalplugin\Entities\WardCRUD;

class ExcelExportPunction {
	
	/**
	 *
	 * @param unknown $id        	
	 */
	private static function getData($id, $type) {
		$raport = PatientRaport::getRaportBetweenDates ( $id, $type, '2014-06-01', (new \DateTime ())->format ( "Y-m-d" ) );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		return $raport;
	}
	/**
	 *
	 * @param unknown $objPHPExcel        	
	 * @param unknown $cols        	
	 */
	private static function printHeaders($objPHPExcel, $cols) {
		$count = 1;
		$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 0, 2, "Data" );
		foreach ( $cols as $col ) {
			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( $count ++, 2, sprintf ( "%7s", $col ) );
		}
	}
	/**
	 */
	private static function printData($objPHPExcel, $data, $type) {
		$row = 3;
		$lastColumn = 1;
		$colNumberOfPatients = ExcelExport::getColumnLetter ( 1 );
		$indexes = PatientRaport::getIndexes ( $type );
		foreach ( $data as $rowKey => $rowValue ) {
			// 1 col: date
			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 0, $row, json_encode ( $rowKey ) );
			$count = 1;
			// 2-5 cols: N1 N2 N3 N0
			foreach ( $indexes as $index ) {
				$value = isset ( $rowValue [$index] ) ? $rowValue [$index] : "0";
				$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( $count ++, $row, $value );
			}
			// 6 col: num of categorized (N = N1+N2+N3)
			$colHighestCategory = ExcelExport::getColumnLetter ( $count - 2 );
			$colNumberOfPatients = ExcelExport::getColumnLetter ( $count );
			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( $count ++, $row, '=SUM(B' . $row . ':' . $colHighestCategory . $row . ')' );
			$tpb = PatientRaport::getTpb ( $type );
			// 7-11 tpb1, tpb2, tpb3, 0 (no-cat), 2 (add)

			foreach ( $tpb as $tpbn ) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
				$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( $count ++, $row, $tpbn );
			}
			// 9-11: Tpb1*N1,Tpb2*N2,Tpb3*N3+2xN
			$tpbSize = count ( $tpb );
			foreach ( $tpb as $tpbn ) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
				$col1Letter = ExcelExport::getColumnLetter ( $count - 2 * $tpbSize );
				$col2Letter = ExcelExport::getColumnLetter ( $count - $tpbSize );
				$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( $count ++, $row, '=' . $col1Letter . $row . "*" . $col2Letter . $row );
			}
			// SUM Tpb
			$col3Letter = ExcelExport::getColumnLetter ( $count - $tpbSize );
			$col4Letter = ExcelExport::getColumnLetter ( $count - 1 );
			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( $count ++, $row, '=SUM(' . $col3Letter . $row . ":" . $col4Letter . $row . ")" );
			$row ++;
			$lastColumn = $count - 1;
		}
		// number of categorization days
		$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 1, 1, '=COUNTIFS(' . $colNumberOfPatients . '3:' . $colNumberOfPatients . ($row - 1) . ',">0")' );
		// sum
		$col5Letter = ExcelExport::getColumnLetter ( $lastColumn );
		$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 2, 1, '=SUM(' . $col5Letter . '3:' . $col5Letter . ($row - 1) . ')/60' );
		return $row;
	}
	
	/**
	 *
	 * @param unknown $objPHPExcel        	
	 */
	static function fillSummary($objPHPExcel) {

		ExcelExport::newSheet ( $objPHPExcel, 0 );
		ExcelExport::printTitle ( $objPHPExcel, "Raport" );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$sheetCount = $objPHPExcel->getSheetCount ();
		$objPHPExcel->getActiveSheet ()->setCellValue ( 'A2', 'Oddz.' );
		$objPHPExcel->getActiveSheet ()->setCellValue ( 'B2', 'Dni' );
		$objPHPExcel->getActiveSheet ()->setCellValue ( 'C2', 'Tpb' );
		$objPHPExcel->getActiveSheet ()->setCellValue ( 'D2', 'Tśpb' );
		$objPHPExcel->getActiveSheet ()->setCellValue ( 'E2', 'Tśpc*' );
		$objPHPExcel->getActiveSheet ()->setCellValue ( 'F2', 'Tśpc**' );
		$objPHPExcel->getActiveSheet ()->setCellValue ( 'G2', 'Td***' );
		$objPHPExcel->getActiveSheet ()->setCellValue ( 'H2', 'Le*' );
		$objPHPExcel->getActiveSheet ()->setCellValue ( 'I2', 'Le**' );
		for($i = 1; $i < $sheetCount; $i ++) {
			$loadedSheetNames = $objPHPExcel->getSheetNames ();
			foreach ( $loadedSheetNames as $sheetIndex => $loadedSheetName ) {
				if ($sheetIndex == 0) {
					continue;
				}
				$row = $sheetIndex + 2;
				$objPHPExcel->getActiveSheet ()->setCellValue ( 'A' . $row, "='" . $loadedSheetName . "'!A1" );
				$objPHPExcel->getActiveSheet ()->setCellValue ( 'B' . $row, "='" . $loadedSheetName . "'!B1" );
				$objPHPExcel->getActiveSheet ()->setCellValue ( 'C' . $row, "='" . $loadedSheetName . "'!C1" );
				$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 3, $row, "=IF(C" . $row . ">0,C" . $row . "/B" . $row . ",0)" );
				$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 4, $row, "=D" . $row . "*110%" );
				$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 5, $row, "=D" . $row . "*125%" );
				$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 6, $row, "1531" );
				$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 7, $row, "=IF(E" . $row . ">0,E" . $row . "*365/G" . $row . ",\"-\")" );
				$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 8, $row, "=IF(F" . $row . ">0,F" . $row . "*365/G" . $row . ",\"-\")" );
			}
			$objPHPExcel->getActiveSheet ()->getStyle ( 'C3:I100' )->getNumberFormat ()->setFormatCode ( '#,##0.0' );
			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 0, $row + 1, "* Czas pielęgnacji pośredniej jako 10% czasu pielęgnacji bezpośredniej" );
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 0, $row + 2, "** Czas pielęgnacji pośredniej jako 25% czasu pielęgnacji bezpośredniej" );
			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 0, $row + 3, "*** Czas dyspozycyjny - propozycja z Rozporządzenia MZ: 202 dni x 7,58 h" );
			ExcelExport::styleActiveSheet ( $objPHPExcel );
		}
	}
	static function fillData($objPHPExcel) {

		// no time limit for this script
		set_time_limit ( 0 );
		$time_start = microtime ( true );
		// remove first default sheet
		$objPHPExcel->removeSheetByIndex ( 0 );
		// get wards
		$wards = WardCRUD::getWardsArray ();
		foreach ( $wards as $ward ) {
			ExcelExport::newSheet ( $objPHPExcel );
			$wardName = $ward->name . " (" . $ward->getTypOddzialu () . ")";
			ExcelExport::printTitle ( $objPHPExcel, $wardName );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$data = ExcelExportPunction::getData ( $ward->id, $ward->getTypOddzialu () );
			$cols = PatientRaport::getColumns ( $ward->getTypOddzialu () );
			ExcelExportPunction::printHeaders ( $objPHPExcel, $cols );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			ExcelExportPunction::printData ( $objPHPExcel, $data, $ward->getTypOddzialu () );
			ExcelExport::styleActiveSheet ( $objPHPExcel );
		}
		ExcelExportPunction::fillSummary ( $objPHPExcel );
		$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 0, 100, "summary " . ($time_start - microtime ( true )) . " s" );
	}
}

Issues (100)

Security Analysis not enabled

src/utils/ExcelExportPunction.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

1			<?php
2
3			namespace Hospitalplugin\utils;
4
5			use Hospitalplugin\Entities\InfectionsCRUD;
6			use Hospitalplugin\Entities\Infections;
7			use Hospitalplugin\Entities\PatientRaport;
8			use Hospitalplugin\Entities\WardCRUD;
9
10			class ExcelExportPunction {
11
12			/**
13			*
14			* @param unknown $id
15			*/
16			private static function getData($id, $type) {
17			$raport = PatientRaport::getRaportBetweenDates ( $id, $type, '2014-06-01', (new \DateTime ())->format ( "Y-m-d" ) );
			0 ignored issues – show Documentation introduced 2015-11-23 17:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'2014-06-01'` is of type `string`, but the function expects a `object<Hospitalplugin\Entities\unknown>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2015-11-23 17:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `(new \DateTime())->format('Y-m-d')` is of type `string`, but the function expects a `object<Hospitalplugin\Entities\unknown>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
18			return $raport;
19			}
20			/**
21			*
22			* @param unknown $objPHPExcel
23			* @param unknown $cols
24			*/
25			private static function printHeaders($objPHPExcel, $cols) {
26			$count = 1;
27			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 0, 2, "Data" );
28			foreach ( $cols as $col ) {
29			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( $count ++, 2, sprintf ( "%7s", $col ) );
30			}
31			}
32			/**
33			*/
34			private static function printData($objPHPExcel, $data, $type) {
35			$row = 3;
36			$lastColumn = 1;
37			$colNumberOfPatients = ExcelExport::getColumnLetter ( 1 );
38			$indexes = PatientRaport::getIndexes ( $type );
39			foreach ( $data as $rowKey => $rowValue ) {
40			// 1 col: date
41			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 0, $row, json_encode ( $rowKey ) );
42			$count = 1;
43			// 2-5 cols: N1 N2 N3 N0
44			foreach ( $indexes as $index ) {
45			$value = isset ( $rowValue [$index] ) ? $rowValue [$index] : "0";
46			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( $count ++, $row, $value );
47			}
48			// 6 col: num of categorized (N = N1+N2+N3)
49			$colHighestCategory = ExcelExport::getColumnLetter ( $count - 2 );
50			$colNumberOfPatients = ExcelExport::getColumnLetter ( $count );
51			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( $count ++, $row, '=SUM(B' . $row . ':' . $colHighestCategory . $row . ')' );
52			$tpb = PatientRaport::getTpb ( $type );
53			// 7-11 tpb1, tpb2, tpb3, 0 (no-cat), 2 (add)
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-10 21:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this `43%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
54			foreach ( $tpb as $tpbn ) {
			0 ignored issues – show Bug introduced 2016-03-15 08:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$tpb` of type `array<integer,integer,{"...r","3":"integer"}>\|null` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
55			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( $count ++, $row, $tpbn );
56			}
57			// 9-11: Tpb1N1,Tpb2N2,Tpb3*N3+2xN
58			$tpbSize = count ( $tpb );
59			foreach ( $tpb as $tpbn ) {
			0 ignored issues – show Bug introduced 2016-03-15 08:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$tpb` of type `array<integer,integer,{"...r","3":"integer"}>\|null` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
60			$col1Letter = ExcelExport::getColumnLetter ( $count - 2 * $tpbSize );
61			$col2Letter = ExcelExport::getColumnLetter ( $count - $tpbSize );
62			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( $count ++, $row, '=' . $col1Letter . $row . "*" . $col2Letter . $row );
63			}
64			// SUM Tpb
65			$col3Letter = ExcelExport::getColumnLetter ( $count - $tpbSize );
66			$col4Letter = ExcelExport::getColumnLetter ( $count - 1 );
67			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( $count ++, $row, '=SUM(' . $col3Letter . $row . ":" . $col4Letter . $row . ")" );
68			$row ++;
69			$lastColumn = $count - 1;
70			}
71			// number of categorization days
72			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 1, 1, '=COUNTIFS(' . $colNumberOfPatients . '3:' . $colNumberOfPatients . ($row - 1) . ',">0")' );
73			// sum
74			$col5Letter = ExcelExport::getColumnLetter ( $lastColumn );
75			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 2, 1, '=SUM(' . $col5Letter . '3:' . $col5Letter . ($row - 1) . ')/60' );
76			return $row;
77			}
78
79			/**
80			*
81			* @param unknown $objPHPExcel
82			*/
83			static function fillSummary($objPHPExcel) {
			0 ignored issues – show Best Practice introduced 2015-11-23 17:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
84			ExcelExport::newSheet ( $objPHPExcel, 0 );
85			ExcelExport::printTitle ( $objPHPExcel, "Raport" );
			0 ignored issues – show Documentation introduced 2015-11-23 17:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'Raport'` is of type `string`, but the function expects a `object<Hospitalplugin\utils\unknown>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
86			$sheetCount = $objPHPExcel->getSheetCount ();
87			$objPHPExcel->getActiveSheet ()->setCellValue ( 'A2', 'Oddz.' );
88			$objPHPExcel->getActiveSheet ()->setCellValue ( 'B2', 'Dni' );
89			$objPHPExcel->getActiveSheet ()->setCellValue ( 'C2', 'Tpb' );
90			$objPHPExcel->getActiveSheet ()->setCellValue ( 'D2', 'Tśpb' );
91			$objPHPExcel->getActiveSheet ()->setCellValue ( 'E2', 'Tśpc*' );
92			$objPHPExcel->getActiveSheet ()->setCellValue ( 'F2', 'Tśpc**' );
93			$objPHPExcel->getActiveSheet ()->setCellValue ( 'G2', 'Td***' );
94			$objPHPExcel->getActiveSheet ()->setCellValue ( 'H2', 'Le*' );
95			$objPHPExcel->getActiveSheet ()->setCellValue ( 'I2', 'Le**' );
96			for($i = 1; $i < $sheetCount; $i ++) {
97			$loadedSheetNames = $objPHPExcel->getSheetNames ();
98			foreach ( $loadedSheetNames as $sheetIndex => $loadedSheetName ) {
99			if ($sheetIndex == 0) {
100			continue;
101			}
102			$row = $sheetIndex + 2;
103			$objPHPExcel->getActiveSheet ()->setCellValue ( 'A' . $row, "='" . $loadedSheetName . "'!A1" );
104			$objPHPExcel->getActiveSheet ()->setCellValue ( 'B' . $row, "='" . $loadedSheetName . "'!B1" );
105			$objPHPExcel->getActiveSheet ()->setCellValue ( 'C' . $row, "='" . $loadedSheetName . "'!C1" );
106			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 3, $row, "=IF(C" . $row . ">0,C" . $row . "/B" . $row . ",0)" );
107			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 4, $row, "=D" . $row . "*110%" );
108			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 5, $row, "=D" . $row . "*125%" );
109			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 6, $row, "1531" );
110			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 7, $row, "=IF(E" . $row . ">0,E" . $row . "*365/G" . $row . ",\"-\")" );
111			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 8, $row, "=IF(F" . $row . ">0,F" . $row . "*365/G" . $row . ",\"-\")" );
112			}
113			$objPHPExcel->getActiveSheet ()->getStyle ( 'C3:I100' )->getNumberFormat ()->setFormatCode ( '#,##0.0' );
114			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 0, $row + 1, "* Czas pielęgnacji pośredniej jako 10% czasu pielęgnacji bezpośredniej" );
			0 ignored issues – show Bug introduced 2015-11-23 17:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$row` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
115			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 0, $row + 2, "** Czas pielęgnacji pośredniej jako 25% czasu pielęgnacji bezpośredniej" );
116			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 0, $row + 3, "*** Czas dyspozycyjny - propozycja z Rozporządzenia MZ: 202 dni x 7,58 h" );
117			ExcelExport::styleActiveSheet ( $objPHPExcel );
118			}
119			}
120			static function fillData($objPHPExcel) {
			0 ignored issues – show Best Practice introduced 2015-11-23 17:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
121			// no time limit for this script
122			set_time_limit ( 0 );
123			$time_start = microtime ( true );
124			// remove first default sheet
125			$objPHPExcel->removeSheetByIndex ( 0 );
126			// get wards
127			$wards = WardCRUD::getWardsArray ();
128			foreach ( $wards as $ward ) {
129			ExcelExport::newSheet ( $objPHPExcel );
130			$wardName = $ward->name . " (" . $ward->getTypOddzialu () . ")";
131			ExcelExport::printTitle ( $objPHPExcel, $wardName );
			0 ignored issues – show Documentation introduced 2015-11-23 17:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$wardName` is of type `string`, but the function expects a `object<Hospitalplugin\utils\unknown>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
132			$data = ExcelExportPunction::getData ( $ward->id, $ward->getTypOddzialu () );
133			$cols = PatientRaport::getColumns ( $ward->getTypOddzialu () );
134			ExcelExportPunction::printHeaders ( $objPHPExcel, $cols );
			0 ignored issues – show Documentation introduced 2015-11-23 17:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$cols` is of type `array<integer,string,{"0...string","15":"string"}>`, but the function expects a `object<Hospitalplugin\utils\unknown>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
135			ExcelExportPunction::printData ( $objPHPExcel, $data, $ward->getTypOddzialu () );
136			ExcelExport::styleActiveSheet ( $objPHPExcel );
137			}
138			ExcelExportPunction::fillSummary ( $objPHPExcel );
139			$objPHPExcel->getActiveSheet ()->setCellValueByColumnAndRow ( 0, 100, "summary " . ($time_start - microtime ( true )) . " s" );
140			}
141			}

amarcinkowski / hospitalplugin

Issues (100)

Security Analysis not enabled

src/utils/ExcelExportPunction.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like