Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 40 | View Code Duplication | class PatientPED extends Patient |
|
|
|
|||
| 41 | { |
||
| 42 | |||
| 43 | /** |
||
| 44 | * @var string $typ typ pacjenta |
||
| 45 | */ |
||
| 46 | protected $typ = "PED"; |
||
| 47 | |||
| 48 | /** |
||
| 49 | * @Column(columnDefinition="TINYINT(4) DEFAULT 0") |
||
| 50 | */ |
||
| 51 | public $aktywnoscFizyczna; |
||
| 52 | |||
| 53 | /** |
||
| 54 | * @Column(columnDefinition="TINYINT(4) DEFAULT 0") |
||
| 55 | */ |
||
| 56 | public $higiena; |
||
| 57 | |||
| 58 | /** |
||
| 59 | * @Column(columnDefinition="TINYINT(4) DEFAULT 0") |
||
| 60 | */ |
||
| 61 | public $karmienieIOdzywianie; |
||
| 62 | |||
| 63 | /** |
||
| 64 | * @Column(columnDefinition="TINYINT(4) DEFAULT 0") |
||
| 65 | */ |
||
| 66 | public $wydalanie; |
||
| 67 | |||
| 68 | /** |
||
| 69 | * @Column(columnDefinition="TINYINT(4) DEFAULT 0") |
||
| 70 | */ |
||
| 71 | public $pomiarParametrowZyciowych; |
||
| 72 | |||
| 73 | /** |
||
| 74 | * @Column(columnDefinition="TINYINT(4) DEFAULT 0") |
||
| 75 | */ |
||
| 76 | public $leczenie; |
||
| 77 | |||
| 78 | /** |
||
| 79 | * @Column(columnDefinition="TINYINT(4) DEFAULT 0") |
||
| 80 | */ |
||
| 81 | public $edukacjaZdrowotnaOrazWsparcieDzieckaIRodzicow; |
||
| 82 | |||
| 83 | /** |
||
| 84 | * getaktywnoscFizyczna |
||
| 85 | * |
||
| 86 | * @return aktywnoscFizyczna int |
||
| 87 | */ |
||
| 88 | public function getAktywnoscFizyczna() |
||
| 92 | |||
| 93 | /** |
||
| 94 | * setaktywnoscFizyczna |
||
| 95 | * |
||
| 96 | * @param int $aktywnoscFizyczna aktywnosc fizyczna |
||
| 97 | * |
||
| 98 | * @return PatientPED |
||
| 99 | */ |
||
| 100 | public function setAktywnoscFizyczna($aktywnoscFizyczna) |
||
| 101 | { |
||
| 102 | $this->aktywnoscFizyczna = $aktywnoscFizyczna; |
||
| 103 | return $this; |
||
| 104 | } |
||
| 105 | |||
| 106 | /** |
||
| 107 | * getHigiena |
||
| 108 | * |
||
| 109 | * @return Higiena int Higiena |
||
| 110 | */ |
||
| 111 | public function getHigiena() |
||
| 115 | |||
| 116 | /** |
||
| 117 | * setHigiena |
||
| 118 | * |
||
| 119 | * @param int $Higiena int higiena |
||
| 120 | * |
||
| 121 | * @return PatientPED |
||
| 122 | */ |
||
| 123 | public function setHigiena($higiena) |
||
| 124 | { |
||
| 125 | $this->higiena = $higiena; |
||
| 126 | return $this; |
||
| 127 | } |
||
| 128 | |||
| 129 | /** |
||
| 130 | * getKarmienieIOdzywianie |
||
| 131 | * |
||
| 132 | * @return KarmienieIOdzywianie |
||
| 133 | */ |
||
| 134 | public function getKarmienieIOdzywianie() |
||
| 138 | |||
| 139 | /** |
||
| 140 | * setKarmienieIOdzywianie |
||
| 141 | * |
||
| 142 | * @param int $KarmienieIOdzywianie itn karmienieIOdzywianie |
||
| 143 | * |
||
| 144 | * @return PatientPED |
||
| 145 | */ |
||
| 146 | public function setKarmienieIOdzywianie($karmienieIOdzywianie) |
||
| 147 | { |
||
| 148 | $this->karmienieIOdzywianie = $karmienieIOdzywianie; |
||
| 149 | return $this; |
||
| 150 | } |
||
| 151 | |||
| 152 | /** |
||
| 153 | * getWydalanie |
||
| 154 | * |
||
| 155 | * @return Wydalanie |
||
| 156 | */ |
||
| 157 | public function getWydalanie() |
||
| 161 | |||
| 162 | /** |
||
| 163 | * PatientPED |
||
| 164 | * |
||
| 165 | * @param int $Wydalanie Wydalanie |
||
| 166 | * |
||
| 167 | * @return PatientPED |
||
| 168 | */ |
||
| 169 | public function setWydalanie($wydalanie) |
||
| 170 | { |
||
| 171 | $this->wydalanie = $wydalanie; |
||
| 172 | return $this; |
||
| 173 | } |
||
| 174 | |||
| 175 | /** |
||
| 176 | * getPomiarParametrowZyciowych |
||
| 177 | * |
||
| 178 | * @return PomiarParametrowZyciowych |
||
| 179 | */ |
||
| 180 | public function getPomiarParametrowZyciowych() |
||
| 184 | |||
| 185 | /** |
||
| 186 | * setPomiarParametrowZyciowych |
||
| 187 | * |
||
| 188 | * @param int $PomiarParametrowZyciowych int PomiarParametrowZyciowych |
||
| 189 | * |
||
| 190 | * @return PatientPED |
||
| 191 | */ |
||
| 192 | public function setPomiarParametrowZyciowych($pomiarParametrowZyciowych) |
||
| 193 | { |
||
| 194 | $this->pomiarParametrowZyciowych = $pomiarParametrowZyciowych; |
||
| 195 | return $this; |
||
| 196 | } |
||
| 197 | |||
| 198 | /** |
||
| 199 | * getLeczenie |
||
| 200 | * |
||
| 201 | * @return Leczenie |
||
| 202 | */ |
||
| 203 | public function getLeczenie() |
||
| 207 | |||
| 208 | /** |
||
| 209 | * setLeczenie |
||
| 210 | * |
||
| 211 | * @param int $Leczenie int Leczenie |
||
| 212 | * |
||
| 213 | * @return PatientPED |
||
| 214 | */ |
||
| 215 | public function setLeczenie($Leczenie) |
||
| 216 | { |
||
| 217 | $this->leczenie = $Leczenie; |
||
| 218 | return $this; |
||
| 219 | } |
||
| 220 | |||
| 221 | /** |
||
| 222 | * getEdukacjaZdrowotnaOrazWsparcieDzieckaIRodzicow |
||
| 223 | * |
||
| 224 | * @return EdukacjaZdrowotnaOrazWsparcieDzieckaIRodzicow |
||
| 225 | */ |
||
| 226 | public function getEdukacjaZdrowotnaOrazWsparcieDzieckaIRodzicow() |
||
| 230 | |||
| 231 | /** |
||
| 232 | * setEdukacjaZdrowotnaOrazWsparcieDzieckaIRodzicow |
||
| 233 | * |
||
| 234 | * @param int $EdukacjaZdrowotnaOrazWsparcieDzieckaIRodzicow int ezowdir |
||
| 235 | * |
||
| 236 | * @return PatientPED |
||
| 237 | */ |
||
| 238 | public function setEdukacjaZdrowotnaOrazWsparcieDzieckaIRodzicow($EdukacjaZdrowotnaOrazWsparcieDzieckaIRodzicow) |
||
| 243 | |||
| 244 | /** |
||
| 245 | * getFields |
||
| 246 | * |
||
| 247 | * @return multitype:string |
||
| 248 | */ |
||
| 249 | public static function getFields() |
||
| 263 | } |
||
| 264 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.