HospitalForm - Code Metrics - amarcinkowski/hospitalplugin - Measure and Improve Code Quality continuously with Scrutinizer

HospitalForm A
last analyzed 2016-03-15 08:59 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	3
c	1
b	0
f	0
lcom	0
cbo	5
dl	0
loc	27
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
B	load()	0	25	3

<?php

/**
 * PatientCRUD
 *
 * THIS MATERIAL IS PROVIDED AS IS, WITH ABSOLUTELY NO WARRANTY EXPRESSED
 * OR IMPLIED. ANY USE IS AT YOUR OWN RISK.
 *
 * Permission is hereby granted to use or copy this program
 * for any purpose, provided the above notices are retained on all copies.
 * Permission to modify the code and to distribute modified code is granted,
 * provided the above notices are retained, and a notice that the code was
 * modified is included with the above copyright notice.
 *
 * @category  Wp
 * @package   Punction
 * @author    Andrzej Marcinkowski <[email protected]>
 * @copyright 2014 Wojewódzki Szpital Zespolony, Kalisz
 * @license   MIT http://opensource.org/licenses/MIT
 * @version   1.0 $Format:%H$
 * @link      http://
 * @since     File available since Release 1.0.0
 * PHP Version 5
 */
namespace Hospitalplugin\Entities;

use Hospitalplugin\DB\DoctrineBootstrap;
use Hospitalplugin\utils\Utils;
use Hospitalplugin\Twig\EscapePLCharsExtension;
use Hospitalplugin\Entities\WardCRUD;
use Hospitalplugin\Twig\PLTwig;

class HospitalForm {
	public static function load($yaml, $class, $dir) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		try {
			$em = DoctrineBootstrap::getEntityManager ();
			
			$userId = $userId = wp_get_current_user ()->ID;
			$ward = WardCRUD::getWardForUser ( $userId );
			$user = $em->find ( "\Hospitalplugin\Entities\User", $userId );
			
			if (! empty ( $_POST )) {
				$args = $_POST;
				$i = new $class ( $args );
				$i->setWard ( $ward );
				$i->setUser ( $user );
				$em->persist ( $i );
				$em->flush ();
			} else {
				$object = \Hospitalplugin\utils\YAML2Object::getObject ( $yaml );
				echo PLTwig::load ( $dir )->render ( 'form.twig', array (
						'infections' => $object 
				) );
			}
		} catch ( Exception $e ) {

			echo "ERR: " . $e;
		}
	}
}
?>


1			<?php
2
3			/**
4			* PatientCRUD
5			*
6			* THIS MATERIAL IS PROVIDED AS IS, WITH ABSOLUTELY NO WARRANTY EXPRESSED
7			* OR IMPLIED. ANY USE IS AT YOUR OWN RISK.
8			*
9			* Permission is hereby granted to use or copy this program
10			* for any purpose, provided the above notices are retained on all copies.
11			* Permission to modify the code and to distribute modified code is granted,
12			* provided the above notices are retained, and a notice that the code was
13			* modified is included with the above copyright notice.
14			*
15			* @category Wp
16			* @package Punction
17			* @author Andrzej Marcinkowski <[email protected]>
18			* @copyright 2014 Wojewódzki Szpital Zespolony, Kalisz
19			* @license MIT http://opensource.org/licenses/MIT
20			* @version 1.0 $Format:%H$
21			* @link http://
22			* @since File available since Release 1.0.0
23			* PHP Version 5
24			*/
25			namespace Hospitalplugin\Entities;
26
27			use Hospitalplugin\DB\DoctrineBootstrap;
28			use Hospitalplugin\utils\Utils;
29			use Hospitalplugin\Twig\EscapePLCharsExtension;
30			use Hospitalplugin\Entities\WardCRUD;
31			use Hospitalplugin\Twig\PLTwig;
32
33			class HospitalForm {
34			public static function load($yaml, $class, $dir) {
			0 ignored issues – show Coding Style introduced 2015-11-23 17:01 UTC by Report Bug Copy Issue Report `load` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
35			try {
36			$em = DoctrineBootstrap::getEntityManager ();
37
38			$userId = $userId = wp_get_current_user ()->ID;
39			$ward = WardCRUD::getWardForUser ( $userId );
40			$user = $em->find ( "\Hospitalplugin\Entities\User", $userId );
41
42			if (! empty ( $_POST )) {
43			$args = $_POST;
44			$i = new $class ( $args );
45			$i->setWard ( $ward );
46			$i->setUser ( $user );
47			$em->persist ( $i );
48			$em->flush ();
49			} else {
50			$object = \Hospitalplugin\utils\YAML2Object::getObject ( $yaml );
51			echo PLTwig::load ( $dir )->render ( 'form.twig', array (
52			'infections' => $object
53			) );
54			}
55			} catch ( Exception $e ) {
			0 ignored issues – show Bug introduced 2015-11-23 17:00 UTC by Report Bug Copy Issue Report The class `Hospitalplugin\Entities\Exception` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
56			echo "ERR: " . $e;
57			}
58			}
59			}
60			?>
			0 ignored issues – show Best Practice introduced 2015-11-23 17:00 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...

amarcinkowski / hospitalplugin

HospitalForm A last analyzed 2016-03-15 08:59 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like

HospitalForm A
last analyzed 2016-03-15 08:59 UTC