HandlerProcessRefund::analyze() - Code Metrics - Inspection of "New messages: `DocRefund_IgnoreRefund` and `Ticket..." - amabnl/amadeus-ws-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#181)

unknown

created 2018-04-17 16:57 UTC

HandlerProcessRefund::analyze() B

↳ Parent: HandlerProcessRefund

Complexity

Conditions	3
Paths	3

Size

Total Lines	25
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	25
ccs	16
cts	16
cp	1
rs	8.8571
cc	3
eloc	15
nc	3
nop	1
crap	3

<?php
/**
 * amadeus-ws-client
 *
 * Copyright 2015 Amadeus Benelux NV
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 *
 * @package Amadeus
 * @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
 */

namespace Amadeus\Client\ResponseHandler\Ticket;

use Amadeus\Client\ResponseHandler\StandardResponseHandler;
use Amadeus\Client\Result;
use Amadeus\Client\Session\Handler\SendResult;

/**
 * HandlerProcessRefund
 *
 * @package Amadeus\Client\ResponseHandler\Ticket
 * @author Mike Hernas <[email protected]>
 */
class HandlerProcessRefund extends StandardResponseHandler
{
    /**
     * @param SendResult $response
     * @return Result
     */
    public function analyze(SendResult $response)
    {
        $analyzeResponse = new Result($response);

        $code = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $message = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $domXpath = $this->makeDomXpath($response->responseXml);
        $success = $domXpath->query('//GeneralReply//Success');
        if ($success->length > 0) {
            $analyzeResponse->status = Result::STATUS_OK;
            return $analyzeResponse;
        }

        $errorCodeNodeList = $domXpath->query("//GeneralReply/Errors/Errors");

        if ($errorCodeNodeList->length > 0) {
            $analyzeResponse->status = Result::STATUS_ERROR;

            $errorCatNode = $errorCodeNodeList->item(0);
            $analyzeResponse->messages[] = trim($errorCatNode->nodeValue);
        }

        return $analyzeResponse;
    }
}


1		<?php
2		/**
3		* amadeus-ws-client
4		*
5		* Copyright 2015 Amadeus Benelux NV
6		*
7		* Licensed under the Apache License, Version 2.0 (the "License");
8		* you may not use this file except in compliance with the License.
9		* You may obtain a copy of the License at
10		*
11		* http://www.apache.org/licenses/LICENSE-2.0
12		*
13		* Unless required by applicable law or agreed to in writing, software
14		* distributed under the License is distributed on an "AS IS" BASIS,
15		* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16		* See the License for the specific language governing permissions and
17		* limitations under the License.
18		*
19		* @package Amadeus
20		* @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
21		*/
22
23		namespace Amadeus\Client\ResponseHandler\Ticket;
24
25		use Amadeus\Client\ResponseHandler\StandardResponseHandler;
26		use Amadeus\Client\Result;
27		use Amadeus\Client\Session\Handler\SendResult;
28
29		/**
30		* HandlerProcessRefund
31		*
32		* @package Amadeus\Client\ResponseHandler\Ticket
33		* @author Mike Hernas <[email protected]>
34		*/
35		class HandlerProcessRefund extends StandardResponseHandler
36		{
37		/**
38		* @param SendResult $response
39		* @return Result
40		*/
41	8	public function analyze(SendResult $response)
42		{
43	8	$analyzeResponse = new Result($response);
44
45	8	$code = null;
		0 ignored issues – show Unused Code introduced 2016-08-11 13:37 UTC by Report Bug Copy Issue Report `$code` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
46	8	$message = null;
		0 ignored issues – show Unused Code introduced 2016-08-11 13:37 UTC by Report Bug Copy Issue Report `$message` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
47
48	8	$domXpath = $this->makeDomXpath($response->responseXml);
49	8	$success = $domXpath->query('//GeneralReply//Success');
50	8	if ($success->length > 0) {
51	4	$analyzeResponse->status = Result::STATUS_OK;
52	4	return $analyzeResponse;
53		}
54
55	4	$errorCodeNodeList = $domXpath->query("//GeneralReply/Errors/Errors");
56
57	4	if ($errorCodeNodeList->length > 0) {
58	4	$analyzeResponse->status = Result::STATUS_ERROR;
59
60	4	$errorCatNode = $errorCodeNodeList->item(0);
61	4	$analyzeResponse->messages[] = trim($errorCatNode->nodeValue);
62	2	}
63
64	4	return $analyzeResponse;
65		}
66		}
67

amabnl / amadeus-ws-client

Pull Request — master (#181)

HandlerProcessRefund::analyze() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like