| Conditions | 20 |
| Paths | 17 |
| Total Lines | 91 |
| Code Lines | 69 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 155 | protected function loadElement($element, $elementType) |
||
| 156 | { |
||
| 157 | switch ($elementType) { |
||
| 158 | case 'Contact': |
||
| 159 | /** @var Element\Contact $element */ |
||
| 160 | $this->freetextData = new FreetextData( |
||
| 161 | $element->value, |
||
| 162 | $element->type |
||
| 163 | ); |
||
| 164 | break; |
||
| 165 | case 'FormOfPayment': |
||
| 166 | /** @var Element\FormOfPayment $element */ |
||
| 167 | $this->formOfPayment = new FormOfPayment($element->type); |
||
| 168 | if ($element->type === Fop::IDENT_CREDITCARD) { |
||
| 169 | $this->formOfPayment->fop->creditCardCode = $element->creditCardType; |
||
| 170 | $this->formOfPayment->fop->accountNumber = $element->creditCardNumber; |
||
| 171 | $this->formOfPayment->fop->expiryDate = $element->creditCardExpiry; |
||
| 172 | if (!is_null($element->creditCardCvcCode)) { |
||
| 173 | $ext = new FopExtension(1); |
||
| 174 | $ext->newFopsDetails = new NewFopsDetails(); |
||
| 175 | $ext->newFopsDetails->cvData = $element->creditCardCvcCode; |
||
| 176 | $this->fopExtension[] = $ext; |
||
| 177 | } |
||
| 178 | } elseif ($element->type === Fop::IDENT_MISC && $element->freeText != "NONREF") { |
||
| 179 | $this->formOfPayment->fop->freetext = $element->freeText; |
||
| 180 | } elseif ($element->type === Fop::IDENT_MISC && $element->freeText === "NONREF") { |
||
| 181 | $this->fopExtension[] = new FopExtension(1); |
||
| 182 | } elseif ($element->type === Fop::IDENT_CHECK) { |
||
| 183 | throw new \RuntimeException("FOP CHECK NOT YET IMPLEMENTED"); |
||
| 184 | } |
||
| 185 | break; |
||
| 186 | case 'MiscellaneousRemark': |
||
| 187 | /** @var Element\MiscellaneousRemark $element */ |
||
| 188 | $this->miscellaneousRemark = new MiscellaneousRemark( |
||
| 189 | $element->text, |
||
| 190 | $element->type, |
||
| 191 | $element->category |
||
| 192 | ); |
||
| 193 | break; |
||
| 194 | case 'ReceivedFrom': |
||
| 195 | /** @var Element\ReceivedFrom $element */ |
||
| 196 | $this->freetextData = new FreetextData( |
||
| 197 | $element->receivedFrom, |
||
| 198 | FreetextDetail::TYPE_RECEIVE_FROM |
||
| 199 | ); |
||
| 200 | break; |
||
| 201 | case 'ServiceRequest': |
||
| 202 | /** @var Element\ServiceRequest $element */ |
||
| 203 | $this->serviceRequest = new ServiceRequest($element); |
||
| 204 | break; |
||
| 205 | case 'Ticketing': |
||
| 206 | /** @var Element\Ticketing $element */ |
||
| 207 | $this->ticketElement = new TicketElement($element); |
||
| 208 | break; |
||
| 209 | case 'AccountingInfo': |
||
| 210 | /** @var Element\AccountingInfo $element */ |
||
| 211 | $this->accounting = new Accounting($element); |
||
| 212 | break; |
||
| 213 | case 'Address': |
||
| 214 | /** @var Element\Address $element */ |
||
| 215 | if ($element->type === ElementManagementData::SEGNAME_ADDRESS_BILLING_UNSTRUCTURED || |
||
| 216 | $element->type === ElementManagementData::SEGNAME_ADDRESS_MAILING_UNSTRUCTURED |
||
| 217 | ) { |
||
| 218 | $this->freetextData = new FreetextData( |
||
| 219 | $element->freeText, |
||
| 220 | FreetextDetail::TYPE_MAILING_ADDRESS |
||
| 221 | ); |
||
| 222 | } else { |
||
| 223 | $this->structuredAddress = new StructuredAddress($element); |
||
| 224 | } |
||
| 225 | break; |
||
| 226 | case 'FrequentFlyer': |
||
| 227 | /** @var Element\FrequentFlyer $element */ |
||
| 228 | $this->serviceRequest = new ServiceRequest(); |
||
| 229 | $this->serviceRequest->ssr->type = 'FQTV'; |
||
| 230 | $this->serviceRequest->ssr->companyId = $element->airline; |
||
| 231 | $this->frequentTravellerData = new FrequentTravellerData($element); |
||
| 232 | break; |
||
| 233 | case 'OtherServiceInfo': |
||
| 234 | /** @var Element\OtherServiceInfo $element */ |
||
| 235 | $this->freetextData = new FreetextData( |
||
| 236 | $element->freeText, |
||
| 237 | FreetextDetail::TYPE_OSI_ELEMENT |
||
| 238 | ); |
||
| 239 | $this->freetextData->freetextDetail->companyId = $element->airline; |
||
| 240 | $this->freetextData->freetextDetail->subjectQualifier = FreetextDetail::QUALIFIER_LITERALTEXT; |
||
| 241 | break; |
||
| 242 | default: |
||
| 243 | throw new InvalidArgumentException('Element type ' . $elementType . ' is not supported'); |
||
| 244 | } |
||
| 245 | } |
||
| 246 | |||
| 281 |
This check compares the return type specified in the
@returnannotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch.