Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
31 | View Code Duplication | class Address |
|
|
|||
32 | { |
||
33 | const OPTION_CITY = "CI"; |
||
34 | const OPTION_COUNTRY = "CO"; |
||
35 | const OPTION_COMPANY = "CY"; |
||
36 | const OPTION_ADDRESS_LINE_1 = "L1"; |
||
37 | const OPTION_ADDRESS_LINE_2 = "L2"; |
||
38 | const OPTION_NAME = "NA"; |
||
39 | const OPTION_PO_BOX = "PO"; |
||
40 | const OPTION_STATE = "ST"; |
||
41 | const OPTION_POSTAL_CODE = "ZP"; |
||
42 | |||
43 | /** |
||
44 | * self::OPTION_* |
||
45 | * |
||
46 | * @var string |
||
47 | */ |
||
48 | public $option; |
||
49 | |||
50 | /** |
||
51 | * @var string |
||
52 | */ |
||
53 | public $optionText; |
||
54 | |||
55 | /** |
||
56 | * Address constructor. |
||
57 | * |
||
58 | * @param string $option self::OPTION_* |
||
59 | * @param string $optionText |
||
60 | */ |
||
61 | 2 | public function __construct($option, $optionText) |
|
66 | } |
||
67 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.