FlightInfo - Code Metrics - Inspection of "New Message Service_StandaloneCatalogue Integratio..." - amabnl/amadeus-ws-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#220)

by Dieter

created 2019-05-25 07:01 UTC

FlightInfo A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	51
Duplicated Lines	62.75 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	5
lcom	1
cbo	3
dl	32
loc	51
ccs	0
cts	27
cp	0
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	16	16	1
A	loadOptionalSegmentInformation()	16	16	4

How to fix Duplicated Code

<?php
/**
 * amadeus-ws-client
 *
 * Copyright 2015 Amadeus Benelux NV
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 *
 * @package Amadeus
 * @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
 */

namespace Amadeus\Client\Struct\Service\StandaloneCatalogue;

use Amadeus\Client\RequestOptions\Fare\InformativePricing\Segment;
use Amadeus\Client\Struct\Fare\InformativePricing13\SegmentGroup;
use Amadeus\Client\Struct\Fare\InformativePricing13\SegmentInformation;
use Amadeus\Client\Struct\Air\FlightTypeDetails;

/**
 * FlightInfo
 *
 * @package Amadeus\Client\Struct\Service\StandaloneCatalogue
 * @author Arvind Pandey <[email protected]>
 */
class FlightInfo extends SegmentGroup
{
    /**
     * @var flightDetails
     */
    public $flightDetails;

    /**
     * FlightInfo constructor.
     *
     * @param FlightInfo $options
     */
    public function __construct($options)

    {
        $this->flightDetails = new SegmentInformation(

            $options->segmentTattoo,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $options->departureDate,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $options->from,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $options->to,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $options->marketingCompany,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $options->flightNumber,
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $options->bookingClass
class MyClass { }

$x = new MyClass();
$x->foo = true;
        );

        $this->loadOptionalSegmentInformation($options);

        SegmentGroup::loadInventory($options->inventory);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Load non-required options if available
     *
     * @param FlightInfo $options
     */
    protected function loadOptionalSegmentInformation($options)

    {
        if (! empty($options->operatingCompany)) {
            $this->flightDetails->companyDetails->operatingCompany = $options->operatingCompany;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }
        
        if ($options->arrivalDate instanceof \DateTime) {
            $this->flightDetails->flightDate->setArrivalDate($options->arrivalDate);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }
        
        if (! empty($options->groupNumber)) {
            $this->flightDetails->flightTypeDetails = new FlightTypeDetails($options->groupNumber);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }
        
        SegmentGroup::loadAdditionalSegmentDetails($options->airplaneCode, $options->nrOfStops);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
}


1		<?php
2		/**
3		* amadeus-ws-client
4		*
5		* Copyright 2015 Amadeus Benelux NV
6		*
7		* Licensed under the Apache License, Version 2.0 (the "License");
8		* you may not use this file except in compliance with the License.
9		* You may obtain a copy of the License at
10		*
11		* http://www.apache.org/licenses/LICENSE-2.0
12		*
13		* Unless required by applicable law or agreed to in writing, software
14		* distributed under the License is distributed on an "AS IS" BASIS,
15		* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16		* See the License for the specific language governing permissions and
17		* limitations under the License.
18		*
19		* @package Amadeus
20		* @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
21		*/
22
23		namespace Amadeus\Client\Struct\Service\StandaloneCatalogue;
24
25		use Amadeus\Client\RequestOptions\Fare\InformativePricing\Segment;
26		use Amadeus\Client\Struct\Fare\InformativePricing13\SegmentGroup;
27		use Amadeus\Client\Struct\Fare\InformativePricing13\SegmentInformation;
28		use Amadeus\Client\Struct\Air\FlightTypeDetails;
29
30		/**
31		* FlightInfo
32		*
33		* @package Amadeus\Client\Struct\Service\StandaloneCatalogue
34		* @author Arvind Pandey <[email protected]>
35		*/
36		class FlightInfo extends SegmentGroup
37		{
38		/**
39		* @var flightDetails
40		*/
41		public $flightDetails;
42
43		/**
44		* FlightInfo constructor.
45		*
46		* @param FlightInfo $options
47		*/
48	View Code Duplication	public function __construct($options)
		0 ignored issues – show Duplication introduced 2018-08-13 07:59 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
49		{
50		$this->flightDetails = new SegmentInformation(
		0 ignored issues – show Documentation Bug introduced 2018-08-07 13:56 UTC by Report Bug Copy Issue Report It seems like `new \Amadeus\Client\Stru...$options->bookingClass)` of type `object<Amadeus\Client\St...g13\SegmentInformation>` is incompatible with the declared type `object<Amadeus\Client\St...atalogue\flightDetails>` of property `$flightDetails`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
51		$options->segmentTattoo,
		0 ignored issues – show Bug introduced 2018-08-13 07:59 UTC by Report Bug Copy Issue Report The property `segmentTattoo` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
52		$options->departureDate,
		0 ignored issues – show Bug introduced 2018-08-13 07:59 UTC by Report Bug Copy Issue Report The property `departureDate` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
53		$options->from,
		0 ignored issues – show Bug introduced 2018-08-13 07:59 UTC by Report Bug Copy Issue Report The property `from` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
54		$options->to,
		0 ignored issues – show Bug introduced 2018-08-13 07:59 UTC by Report Bug Copy Issue Report The property `to` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
55		$options->marketingCompany,
		0 ignored issues – show Bug introduced 2018-08-13 07:59 UTC by Report Bug Copy Issue Report The property `marketingCompany` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
56		$options->flightNumber,
		0 ignored issues – show Bug introduced 2018-08-13 07:59 UTC by Report Bug Copy Issue Report The property `flightNumber` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
57		$options->bookingClass
		0 ignored issues – show Bug introduced 2018-08-13 07:59 UTC by Report Bug Copy Issue Report The property `bookingClass` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
58		);
59
60		$this->loadOptionalSegmentInformation($options);
61
62		SegmentGroup::loadInventory($options->inventory);
		0 ignored issues – show Documentation introduced 2018-08-13 07:59 UTC by Report Bug Copy Issue Report `$options->inventory` is of type `object<Amadeus\Client\St...ivePricing13\Inventory>`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
63		}
64
65		/**
66		* Load non-required options if available
67		*
68		* @param FlightInfo $options
69		*/
70	View Code Duplication	protected function loadOptionalSegmentInformation($options)
		0 ignored issues – show Duplication introduced 2018-08-13 07:59 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
71		{
72		if (! empty($options->operatingCompany)) {
73		$this->flightDetails->companyDetails->operatingCompany = $options->operatingCompany;
		0 ignored issues – show Bug introduced 2018-08-13 07:59 UTC by Report Bug Copy Issue Report The property `operatingCompany` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
74		}
75
76		if ($options->arrivalDate instanceof \DateTime) {
77		$this->flightDetails->flightDate->setArrivalDate($options->arrivalDate);
		0 ignored issues – show Bug introduced 2018-08-13 07:59 UTC by Report Bug Copy Issue Report The property `arrivalDate` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
78		}
79
80		if (! empty($options->groupNumber)) {
81		$this->flightDetails->flightTypeDetails = new FlightTypeDetails($options->groupNumber);
		0 ignored issues – show Bug introduced 2018-08-13 07:59 UTC by Report Bug Copy Issue Report The property `groupNumber` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
82		}
83
84		SegmentGroup::loadAdditionalSegmentDetails($options->airplaneCode, $options->nrOfStops);
		0 ignored issues – show Bug introduced 2018-08-13 07:59 UTC by Report Bug Copy Issue Report The property `airplaneCode` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2018-08-13 07:59 UTC by Report Bug Copy Issue Report The property `nrOfStops` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
85		}
86		}
87

amabnl / amadeus-ws-client

Pull Request — master (#220)

FlightInfo A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like