IntegratedPricing::__construct() - Code Metrics - Inspection of "New Message Service_StandaloneCatalogue Integratio..." - amabnl/amadeus-ws-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#220)

unknown

created 2018-08-08 07:40 UTC

IntegratedPricing::__construct() A

↳ Parent: IntegratedPricing

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2.2559

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	3
cts	5
cp	0.6
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2.2559

<?php
/**
 * amadeus-ws-client
 *
 * Copyright 2015 Amadeus Benelux NV
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 *
 * @package Amadeus
 * @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
 */

namespace Amadeus\Client\Struct\Service;

use Amadeus\Client\RequestOptions\Fare\PricePnr\PaxSegRef;
use Amadeus\Client\RequestOptions\Service\FormOfPayment;
use Amadeus\Client\RequestOptions\Service\FrequentFlyer;
use Amadeus\Client\RequestOptions\ServiceIntegratedCatalogueOptions;
use Amadeus\Client\RequestOptions\ServiceIntegratedPricingOptions;
use Amadeus\Client\Struct\Fare\BasePricingMessage;
use Amadeus\Client\Struct\Fare\PricePnr13\CarrierInformation;
use Amadeus\Client\Struct\Fare\PricePnr13\Currency;
use Amadeus\Client\Struct\Fare\PricePnr13\DateInformation;
use Amadeus\Client\Struct\Fare\PricePnr13\FormOfPaymentInformation;
use Amadeus\Client\Struct\Fare\PricePnr13\FrequentFlyerInformation;
use Amadeus\Client\Struct\Fare\PricePnr13\LocationInformation;
use Amadeus\Client\Struct\Fare\PricePnr13\OptionDetail;
use Amadeus\Client\Struct\Fare\PricePnr13\PaxSegTstReference;
use Amadeus\Client\Struct\Fare\PricePnr13\PricingOptionGroup;
use Amadeus\Client\Struct\Service\IntegratedPricing\PricingOptionKey;
use Amadeus\Client\Struct\Service\IntegratedPricing\PricingOption;

/**
 * Service_IntegratedPricing request structure
 *
 * @package Amadeus\Client\Struct\Service
 * @author Dieter Devlieghere <[email protected]>
 */
class IntegratedPricing extends BasePricingMessage
{
    /**
     * @var PricingOption[]
     */
    public $pricingOption = [];

    /**
     * IntegratedPricing constructor.
     *
     * @param ServiceIntegratedPricingOptions|ServiceIntegratedCatalogueOptions|null $options
     */
    public function __construct($options = null)
    {
        if (!is_null($options)) {
            $this->pricingOption = $this->loadPricingOptions($options);
        }
    }

    /**
     * @param ServiceIntegratedPricingOptions|ServiceIntegratedCatalogueOptions $options
     * @return PricingOption[]
     */
    public static function loadPricingOptions($options)
    {
        $priceOptions = [];
        
        $priceOptions = self::mergeOptions(
            $priceOptions,
            self::makePricingOptionFareBasisOverride($options->pricingsFareBasis)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
        
        $priceOptions = self::mergeOptions(
            $priceOptions,
            self::makePricingOptionForValidatingCarrier($options->validatingCarrier)
        );

        $priceOptions = self::mergeOptions(
            $priceOptions,
            self::makePricingOptionForCurrencyOverride($options->currencyOverride)
        );

        $priceOptions = self::mergeOptions(
            $priceOptions,
            self::makePricingOptionWithOptionDetailAndRefs(
                PricingOptionKey::OVERRIDE_ACCOUNT_CODE,
                $options->accountCode,
                $options->accountCodeRefs
            )
        );

        $priceOptions = self::mergeOptions(
            $priceOptions,
            self::makePricingOptionWithOptionDetailAndRefs(
                PricingOptionKey::OVERRIDE_AWARD,
                $options->awardPricing,
                []
            )
        );

        $priceOptions = self::mergeOptions(
            $priceOptions,
            self::makePricingOptionWithOptionDetailAndRefs(
                PricingOptionKey::OVERRIDE_CORPORATION_NUMBER,
                $options->corporationNumber,
                []
            )
        );

        $priceOptions = self::mergeOptions(
            $priceOptions,
            self::loadDateOverride($options->overrideDate)
        );

        $priceOptions = self::mergeOptions(
            $priceOptions,
            self::makePricingOptionWithOptionDetailAndRefs(PricingOptionKey::OVERRIDE_TICKET_DESIGNATOR, $options->ticketDesignator, []));

        
        $priceOptions = self::mergeOptions($priceOptions, self::loadPointOverrides($options->pointOfSaleOverride));
        
        $priceOptions = self::mergeOptions($priceOptions, self::loadFormOfPaymentOverride($options->formOfPayment));
        
        $priceOptions = self::mergeOptions($priceOptions, self::loadFrequentFlyerOverride($options->frequentFlyers));
        
        $priceOptions = self::mergeOptions($priceOptions, self::loadReferences($options->references));
        
        $priceOptions = self::mergeOptions($priceOptions, self::makeOverrideOptions($options->overrideOptions, $priceOptions)

        );

        // All options processed, no options found:
        if (empty($priceOptions)) {
            $priceOptions[] = new PricingOption(PricingOptionKey::OVERRIDE_NO_OPTION);
        }

        return $priceOptions;
    }

    /**
     *
     * @param FareBasis[] $pricingsFareBasis
     * @return PricingOptionGroup[]
     */
    protected static function makePricingOptionFareBasisOverride($pricingsFareBasis)

    {
        $opt = [];
        if ($pricingsFareBasis !== null) {
            foreach ($pricingsFareBasis as $pricingFareBasis) {
                $po = new PricingOptionGroup($pricingFareBasis->overrideType);
                
                $po->optionDetail = new OptionDetail($pricingFareBasis->fareBasisCode);
                
                $po->paxSegTstReference = new PaxSegTstReference($pricingFareBasis->references);
                
                $opt[] = $po;
            }
        }
        
        return $opt;
    }
    

    /**
     * @param string|null $validatingCarrier
     * @return PricingOption[]
     */
    protected static function makePricingOptionForValidatingCarrier($validatingCarrier)

    {
        $opt = [];

        if ($validatingCarrier !== null) {
            $po = new PricingOption(PricingOptionKey::OVERRIDE_VALIDATING_CARRIER);

            $po->carrierInformation = new CarrierInformation($validatingCarrier);

            $opt[] = $po;
        }

        return $opt;
    }

    /**
     * @param string|null $currency
     * @return PricingOption[]
     */
    protected static function makePricingOptionForCurrencyOverride($currency)

    {
        $opt = [];

        if ($currency !== null) {
            $po = new PricingOption(PricingOptionKey::OVERRIDE_CURRENCY);

            $po->currency = new Currency($currency);

            $opt[] = $po;
        }

        return $opt;
    }

    /**
     * @param string $overrideCode
     * @param string|array|null $options
     * @param PaxSegRef[] $references
     * @return PricingOption[]
     */
    protected function makePricingOptionWithOptionDetailAndRefs($overrideCode, $options, $references)
    {
        $opt = [];

        if ($options !== null) {
            $po = new PricingOption($overrideCode);

            $po->optionDetail = new OptionDetail($options);

            if (!empty($references)) {
                $po->paxSegTstReference = new PaxSegTstReference($references);
            }

            $opt[] = $po;
        }

        return $opt;
    }

    /**
     * @param \DateTime|null $dateOverride
     * @return PricingOption[]
     */
    protected static function loadDateOverride($dateOverride)

    {
        $opt = [];

        if ($dateOverride instanceof \DateTime) {
            $po = new PricingOption(PricingOptionKey::OVERRIDE_PRICING_DATE);

            $po->dateInformation = new DateInformation(
                DateInformation::OPT_DATE_OVERRIDE,
                $dateOverride
            );

            $opt[] = $po;
        }

        return $opt;
    }

    /**
     * @param string|null $posOverride
     * @return PricingOption[]
     */
    protected static function loadPointOverrides($posOverride)

    {
        $opt = [];

        if (!empty($posOverride)) {
            $po = new PricingOption(PricingOptionKey::OVERRIDE_POINT_OF_SALE);

            $po->locationInformation = new LocationInformation(
                LocationInformation::TYPE_POINT_OF_SALE,
                $posOverride
            );

            $opt[] = $po;
        }

        return $opt;
    }

    /**
     * @param FormOfPayment[] $formOfPayment
     * @return PricingOption[]
     */
    protected static function loadFormOfPaymentOverride($formOfPayment)

    {
        $opt = [];

        if (!empty($formOfPayment)) {
            $po = new PricingOption(PricingOptionKey::OVERRIDE_FORM_OF_PAYMENT);

            $po->formOfPaymentInformation = new FormOfPaymentInformation($formOfPayment);

            $opt[] = $po;
        }

        return $opt;
    }

    /**
     * @param FrequentFlyer[] $frequentFlyers
     * @return PricingOption[]
     */
    protected static function loadFrequentFlyerOverride($frequentFlyers)

    {
        $opt = [];

        if (!empty($frequentFlyers)) {
            $po = new PricingOption(PricingOptionKey::OVERRIDE_FREQUENT_FLYER_INFORMATION);

            $po->frequentFlyerInformation = new FrequentFlyerInformation($frequentFlyers);

            $opt[] = $po;
        }

        return $opt;
    }

    /**
     * @param PaxSegRef[] $references
     * @return PricingOption[]
     */
    protected static function loadReferences($references)

    {
        $opt = [];

        if (!empty($references)) {
            $po = new PricingOption(PricingOptionKey::OVERRIDE_PAX_SEG_ELEMENT_SELECTION);

            $po->paxSegTstReference = new PaxSegTstReference($references);

            $opt[] = $po;
        }

        return $opt;
    }

    /**
     * @param string[] $overrideOptions
     * @param PricingOption[] $priceOptions
     * @return PricingOption[]
     */
    protected static function makeOverrideOptions($overrideOptions, $priceOptions)

    {
        $opt = [];

        foreach ($overrideOptions as $overrideOption) {
            if (!self::hasPricingGroup($overrideOption, $priceOptions)) {
                $opt[] = new PricingOption($overrideOption);
            }
        }

        return $opt;
    }

    /**
     * Merges Pricing options
     *
     * @param PricingOption[] $existingOptions
     * @param PricingOption[] $newOptions
     * @return PricingOption[] merged array
     */
    protected static function mergeOptions($existingOptions, $newOptions)
    {
        if (!empty($newOptions)) {
            $existingOptions = array_merge(
                $existingOptions,
                $newOptions
            );
        }

        return $existingOptions;
    }
}


1			<?php
2			/**
3			* amadeus-ws-client
4			*
5			* Copyright 2015 Amadeus Benelux NV
6			*
7			* Licensed under the Apache License, Version 2.0 (the "License");
8			* you may not use this file except in compliance with the License.
9			* You may obtain a copy of the License at
10			*
11			* http://www.apache.org/licenses/LICENSE-2.0
12			*
13			* Unless required by applicable law or agreed to in writing, software
14			* distributed under the License is distributed on an "AS IS" BASIS,
15			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16			* See the License for the specific language governing permissions and
17			* limitations under the License.
18			*
19			* @package Amadeus
20			* @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
21			*/
22
23			namespace Amadeus\Client\Struct\Service;
24
25			use Amadeus\Client\RequestOptions\Fare\PricePnr\PaxSegRef;
26			use Amadeus\Client\RequestOptions\Service\FormOfPayment;
27			use Amadeus\Client\RequestOptions\Service\FrequentFlyer;
28			use Amadeus\Client\RequestOptions\ServiceIntegratedCatalogueOptions;
29			use Amadeus\Client\RequestOptions\ServiceIntegratedPricingOptions;
30			use Amadeus\Client\Struct\Fare\BasePricingMessage;
31			use Amadeus\Client\Struct\Fare\PricePnr13\CarrierInformation;
32			use Amadeus\Client\Struct\Fare\PricePnr13\Currency;
33			use Amadeus\Client\Struct\Fare\PricePnr13\DateInformation;
34			use Amadeus\Client\Struct\Fare\PricePnr13\FormOfPaymentInformation;
35			use Amadeus\Client\Struct\Fare\PricePnr13\FrequentFlyerInformation;
36			use Amadeus\Client\Struct\Fare\PricePnr13\LocationInformation;
37			use Amadeus\Client\Struct\Fare\PricePnr13\OptionDetail;
38			use Amadeus\Client\Struct\Fare\PricePnr13\PaxSegTstReference;
39			use Amadeus\Client\Struct\Fare\PricePnr13\PricingOptionGroup;
40			use Amadeus\Client\Struct\Service\IntegratedPricing\PricingOptionKey;
41			use Amadeus\Client\Struct\Service\IntegratedPricing\PricingOption;
42
43			/**
44			* Service_IntegratedPricing request structure
45			*
46			* @package Amadeus\Client\Struct\Service
47			* @author Dieter Devlieghere <[email protected]>
48			*/
49			class IntegratedPricing extends BasePricingMessage
50			{
51			/**
52			* @var PricingOption[]
53			*/
54			public $pricingOption = [];
55
56			/**
57			* IntegratedPricing constructor.
58			*
59			* @param ServiceIntegratedPricingOptions\|ServiceIntegratedCatalogueOptions\|null $options
60			*/
61	64		public function __construct($options = null)
62			{
63	64		if (!is_null($options)) {
64	64		$this->pricingOption = $this->loadPricingOptions($options);
65			}
66			}
67
68			/**
69			* @param ServiceIntegratedPricingOptions\|ServiceIntegratedCatalogueOptions $options
70			* @return PricingOption[]
71			*/
72	64		public static function loadPricingOptions($options)
73			{
74	64		$priceOptions = [];
75
76	64		$priceOptions = self::mergeOptions(
77	64		$priceOptions,
78	64		self::makePricingOptionFareBasisOverride($options->pricingsFareBasis)
			0 ignored issues – show Bug introduced 2018-07-23 05:28 UTC by Report Bug Copy Issue Report The property `pricingsFareBasis` does not seem to exist in `Amadeus\Client\RequestOp...ntegratedPricingOptions`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history... Documentation introduced 2018-07-23 05:28 UTC by Report Bug Copy Issue Report `self::makePricingOptionF...ons->pricingsFareBasis)` is of type `array<integer,object<Ama...13\PricingOptionGroup>>`, but the function expects a `array<integer,object<Ama...Pricing\PricingOption>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
79			);
80
81			$priceOptions = self::mergeOptions(
82			$priceOptions,
83			self::makePricingOptionForValidatingCarrier($options->validatingCarrier)
84			);
85
86			$priceOptions = self::mergeOptions(
87			$priceOptions,
88			self::makePricingOptionForCurrencyOverride($options->currencyOverride)
89			);
90
91			$priceOptions = self::mergeOptions(
92			$priceOptions,
93			self::makePricingOptionWithOptionDetailAndRefs(
94			PricingOptionKey::OVERRIDE_ACCOUNT_CODE,
95			$options->accountCode,
96			$options->accountCodeRefs
97			)
98			);
99
100			$priceOptions = self::mergeOptions(
101			$priceOptions,
102			self::makePricingOptionWithOptionDetailAndRefs(
103			PricingOptionKey::OVERRIDE_AWARD,
104			$options->awardPricing,
105			[]
106			)
107			);
108
109			$priceOptions = self::mergeOptions(
110			$priceOptions,
111			self::makePricingOptionWithOptionDetailAndRefs(
112			PricingOptionKey::OVERRIDE_CORPORATION_NUMBER,
113			$options->corporationNumber,
114			[]
115			)
116			);
117
118			$priceOptions = self::mergeOptions(
119			$priceOptions,
120			self::loadDateOverride($options->overrideDate)
121			);
122
123			$priceOptions = self::mergeOptions(
124			$priceOptions,
125			self::makePricingOptionWithOptionDetailAndRefs(PricingOptionKey::OVERRIDE_TICKET_DESIGNATOR, $options->ticketDesignator, []));
			0 ignored issues – show Coding Style introduced 2018-08-08 07:34 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 138 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
126
127			$priceOptions = self::mergeOptions($priceOptions, self::loadPointOverrides($options->pointOfSaleOverride));
128
129			$priceOptions = self::mergeOptions($priceOptions, self::loadFormOfPaymentOverride($options->formOfPayment));
130
131			$priceOptions = self::mergeOptions($priceOptions, self::loadFrequentFlyerOverride($options->frequentFlyers));
132
133			$priceOptions = self::mergeOptions($priceOptions, self::loadReferences($options->references));
134
135			$priceOptions = self::mergeOptions($priceOptions, self::makeOverrideOptions($options->overrideOptions, $priceOptions)
			0 ignored issues – show Coding Style introduced 2018-08-08 07:34 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 125 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
136			);
137
138			// All options processed, no options found:
139			if (empty($priceOptions)) {
140			$priceOptions[] = new PricingOption(PricingOptionKey::OVERRIDE_NO_OPTION);
141			}
142
143			return $priceOptions;
144			}
145
146			/**
147			*
148			* @param FareBasis[] $pricingsFareBasis
149			* @return PricingOptionGroup[]
150			*/
151		View Code Duplication	protected static function makePricingOptionFareBasisOverride($pricingsFareBasis)
			0 ignored issues – show Duplication introduced 2017-03-22 11:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
152			{
153			$opt = [];
154			if ($pricingsFareBasis !== null) {
155			foreach ($pricingsFareBasis as $pricingFareBasis) {
156			$po = new PricingOptionGroup($pricingFareBasis->overrideType);
157
158			$po->optionDetail = new OptionDetail($pricingFareBasis->fareBasisCode);
159
160			$po->paxSegTstReference = new PaxSegTstReference($pricingFareBasis->references);
161
162			$opt[] = $po;
163			}
164			}
165
166			return $opt;
167			}
168
169
170			/**
171			* @param string\|null $validatingCarrier
172			* @return PricingOption[]
173			*/
174		View Code Duplication	protected static function makePricingOptionForValidatingCarrier($validatingCarrier)
			0 ignored issues – show Duplication introduced 2016-10-19 13:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
175			{
176			$opt = [];
177
178			if ($validatingCarrier !== null) {
179			$po = new PricingOption(PricingOptionKey::OVERRIDE_VALIDATING_CARRIER);
180
181			$po->carrierInformation = new CarrierInformation($validatingCarrier);
182
183			$opt[] = $po;
184			}
185
186			return $opt;
187			}
188
189			/**
190			* @param string\|null $currency
191			* @return PricingOption[]
192			*/
193		View Code Duplication	protected static function makePricingOptionForCurrencyOverride($currency)
			0 ignored issues – show Duplication introduced 2016-10-19 13:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
194			{
195			$opt = [];
196
197			if ($currency !== null) {
198			$po = new PricingOption(PricingOptionKey::OVERRIDE_CURRENCY);
199
200			$po->currency = new Currency($currency);
201
202			$opt[] = $po;
203			}
204
205			return $opt;
206			}
207
208			/**
209			* @param string $overrideCode
210			* @param string\|array\|null $options
211			* @param PaxSegRef[] $references
212			* @return PricingOption[]
213			*/
214			protected function makePricingOptionWithOptionDetailAndRefs($overrideCode, $options, $references)
215			{
216			$opt = [];
217
218			if ($options !== null) {
219			$po = new PricingOption($overrideCode);
220
221			$po->optionDetail = new OptionDetail($options);
222
223			if (!empty($references)) {
224			$po->paxSegTstReference = new PaxSegTstReference($references);
225			}
226
227			$opt[] = $po;
228			}
229
230			return $opt;
231			}
232
233			/**
234			* @param \DateTime\|null $dateOverride
235			* @return PricingOption[]
236			*/
237		View Code Duplication	protected static function loadDateOverride($dateOverride)
			0 ignored issues – show Duplication introduced 2016-10-19 13:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
238			{
239			$opt = [];
240
241			if ($dateOverride instanceof \DateTime) {
242			$po = new PricingOption(PricingOptionKey::OVERRIDE_PRICING_DATE);
243
244			$po->dateInformation = new DateInformation(
245			DateInformation::OPT_DATE_OVERRIDE,
246			$dateOverride
247			);
248
249			$opt[] = $po;
250			}
251
252			return $opt;
253			}
254
255			/**
256			* @param string\|null $posOverride
257			* @return PricingOption[]
258			*/
259		View Code Duplication	protected static function loadPointOverrides($posOverride)
			0 ignored issues – show Duplication introduced 2016-10-19 13:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
260			{
261			$opt = [];
262
263			if (!empty($posOverride)) {
264			$po = new PricingOption(PricingOptionKey::OVERRIDE_POINT_OF_SALE);
265
266			$po->locationInformation = new LocationInformation(
267			LocationInformation::TYPE_POINT_OF_SALE,
268			$posOverride
269			);
270
271			$opt[] = $po;
272			}
273
274			return $opt;
275			}
276
277			/**
278			* @param FormOfPayment[] $formOfPayment
279			* @return PricingOption[]
280			*/
281		View Code Duplication	protected static function loadFormOfPaymentOverride($formOfPayment)
			0 ignored issues – show Duplication introduced 2017-05-10 15:21 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
282			{
283			$opt = [];
284
285			if (!empty($formOfPayment)) {
286			$po = new PricingOption(PricingOptionKey::OVERRIDE_FORM_OF_PAYMENT);
287
288			$po->formOfPaymentInformation = new FormOfPaymentInformation($formOfPayment);
289
290			$opt[] = $po;
291			}
292
293			return $opt;
294			}
295
296			/**
297			* @param FrequentFlyer[] $frequentFlyers
298			* @return PricingOption[]
299			*/
300		View Code Duplication	protected static function loadFrequentFlyerOverride($frequentFlyers)
			0 ignored issues – show Duplication introduced 2017-05-10 15:21 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
301			{
302			$opt = [];
303
304			if (!empty($frequentFlyers)) {
305			$po = new PricingOption(PricingOptionKey::OVERRIDE_FREQUENT_FLYER_INFORMATION);
306
307			$po->frequentFlyerInformation = new FrequentFlyerInformation($frequentFlyers);
308
309			$opt[] = $po;
310			}
311
312			return $opt;
313			}
314
315			/**
316			* @param PaxSegRef[] $references
317			* @return PricingOption[]
318			*/
319		View Code Duplication	protected static function loadReferences($references)
			0 ignored issues – show Duplication introduced 2016-10-19 13:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
320			{
321			$opt = [];
322
323			if (!empty($references)) {
324			$po = new PricingOption(PricingOptionKey::OVERRIDE_PAX_SEG_ELEMENT_SELECTION);
325
326			$po->paxSegTstReference = new PaxSegTstReference($references);
327
328			$opt[] = $po;
329			}
330
331			return $opt;
332			}
333
334			/**
335			* @param string[] $overrideOptions
336			* @param PricingOption[] $priceOptions
337			* @return PricingOption[]
338			*/
339		View Code Duplication	protected static function makeOverrideOptions($overrideOptions, $priceOptions)
			0 ignored issues – show Duplication introduced 2016-10-19 13:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
340			{
341			$opt = [];
342
343			foreach ($overrideOptions as $overrideOption) {
344			if (!self::hasPricingGroup($overrideOption, $priceOptions)) {
345			$opt[] = new PricingOption($overrideOption);
346			}
347			}
348
349			return $opt;
350			}
351
352			/**
353			* Merges Pricing options
354			*
355			* @param PricingOption[] $existingOptions
356			* @param PricingOption[] $newOptions
357			* @return PricingOption[] merged array
358			*/
359			protected static function mergeOptions($existingOptions, $newOptions)
360			{
361			if (!empty($newOptions)) {
362			$existingOptions = array_merge(
363			$existingOptions,
364			$newOptions
365			);
366			}
367
368			return $existingOptions;
369			}
370			}
371

amabnl / amadeus-ws-client

Pull Request — master (#220)

IntegratedPricing::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like