PricePNRWithLowerFares12::__construct() - Code Metrics - Inspection of "Implemented Fare_PricePNRWithLowerFares and Fare_P..." - amabnl/amadeus-ws-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0fe829...fb702c )

by Dieter

created 2016-10-10 13:53 UTC

PricePNRWithLowerFares12::__construct() A

↳ Parent: PricePNRWithLowerFares12

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1

<?php
/**
 * amadeus-ws-client
 *
 * Copyright 2015 Amadeus Benelux NV
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 *
 * @package Amadeus
 * @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
 */

namespace Amadeus\Client\Struct\Fare;

use Amadeus\Client\RequestOptions\FarePricePnrWithLowerFaresOptions;

/**
 * PricePNRWithLowerFares12
 *
 * @package Amadeus\Client\Struct\Fare
 * @author Dieter Devlieghere <[email protected]>
 */
class PricePNRWithLowerFares12 extends PricePNRWithBookingClass12
{
    /**
     * PricePNRWithLowerFares12 constructor.
     *
     * @param FarePricePnrWithLowerFaresOptions|null $options
     */
    public function __construct(FarePricePnrWithLowerFaresOptions $options = null)
    {
        parent::__construct($options);
function notNullable(stdClass $x) { }

// Unsafe
function withoutCheck(stdClass $x = null) {
    notNullable($x);
}

// Safe - Alternative 1: Adding Additional Type-Check
function withCheck(stdClass $x = null) {
    if ($x instanceof stdClass) {
        notNullable($x);
    }
}

// Safe - Alternative 2: Changing Parameter
function withNonNullableParam(stdClass $x) {
    notNullable($x);
}
    }
}


1			<?php
2			/**
3			* amadeus-ws-client
4			*
5			* Copyright 2015 Amadeus Benelux NV
6			*
7			* Licensed under the Apache License, Version 2.0 (the "License");
8			* you may not use this file except in compliance with the License.
9			* You may obtain a copy of the License at
10			*
11			* http://www.apache.org/licenses/LICENSE-2.0
12			*
13			* Unless required by applicable law or agreed to in writing, software
14			* distributed under the License is distributed on an "AS IS" BASIS,
15			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16			* See the License for the specific language governing permissions and
17			* limitations under the License.
18			*
19			* @package Amadeus
20			* @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
21			*/
22
23			namespace Amadeus\Client\Struct\Fare;
24
25			use Amadeus\Client\RequestOptions\FarePricePnrWithLowerFaresOptions;
26
27			/**
28			* PricePNRWithLowerFares12
29			*
30			* @package Amadeus\Client\Struct\Fare
31			* @author Dieter Devlieghere <[email protected]>
32			*/
33			class PricePNRWithLowerFares12 extends PricePNRWithBookingClass12
34			{
35			/**
36			* PricePNRWithLowerFares12 constructor.
37			*
38			* @param FarePricePnrWithLowerFaresOptions\|null $options
39			*/
40			public function __construct(FarePricePnrWithLowerFaresOptions $options = null)
41			{
42			parent::__construct($options);
			0 ignored issues – show Bug introduced 2016-10-10 14:01 UTC by Report Bug Copy Issue Report It seems like `$options` defined by parameter `$options` on line `40` can be `null`; however, `Amadeus\Client\Struct\Fa...gClass12::__construct()` does not accept `null`, maybe add an additional type check? It seems like you allow that null is being passed for a parameter, however the function which is called does not seem to accept null. We recommend to add an additional type check (or disallow null for the parameter): function notNullable(stdClass $x) { } // Unsafe function withoutCheck(stdClass $x = null) { notNullable($x); } // Safe - Alternative 1: Adding Additional Type-Check function withCheck(stdClass $x = null) { if ($x instanceof stdClass) { notNullable($x); } } // Safe - Alternative 2: Changing Parameter function withNonNullableParam(stdClass $x) { notNullable($x); } Loading history...
43			}
44			}
45

amabnl / amadeus-ws-client

Push — master ( 0fe829...fb702c )

PricePNRWithLowerFares12::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like