Completed
Push — master ( 0fe829...fb702c )
by Dieter
08:08
created

PricePNRWithLowestFare12   A

Complexity

Total Complexity 1

Size/Duplication

Total Lines 12
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 1

Importance

Changes 0
Metric Value
wmc 1
lcom 0
cbo 1
dl 0
loc 12
rs 10
c 0
b 0
f 0

1 Method

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 4 1
1
<?php
2
/**
3
 * amadeus-ws-client
4
 *
5
 * Copyright 2015 Amadeus Benelux NV
6
 *
7
 * Licensed under the Apache License, Version 2.0 (the "License");
8
 * you may not use this file except in compliance with the License.
9
 * You may obtain a copy of the License at
10
 *
11
 * http://www.apache.org/licenses/LICENSE-2.0
12
 *
13
 * Unless required by applicable law or agreed to in writing, software
14
 * distributed under the License is distributed on an "AS IS" BASIS,
15
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16
 * See the License for the specific language governing permissions and
17
 * limitations under the License.
18
 *
19
 * @package Amadeus
20
 * @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
21
 */
22
23
namespace Amadeus\Client\Struct\Fare;
24
25
use Amadeus\Client\RequestOptions\FarePricePnrWithLowestFareOptions;
26
27
/**
28
 * PricePNRWithLowestFare12
29
 *
30
 * @package Amadeus\Client\Struct\Fare
31
 * @author Dieter Devlieghere <[email protected]>
32
 */
33
class PricePNRWithLowestFare12 extends PricePNRWithBookingClass12
34
{
35
    /**
36
     * PricePNRWithLowestFare12 constructor.
37
     *
38
     * @param FarePricePnrWithLowestFareOptions|null $options
39
     */
40
    public function __construct(FarePricePnrWithLowestFareOptions $options = null)
41
    {
42
        parent::__construct($options);
0 ignored issues
show
Bug introduced by
It seems like $options defined by parameter $options on line 40 can be null; however, Amadeus\Client\Struct\Fa...gClass12::__construct() does not accept null, maybe add an additional type check?

It seems like you allow that null is being passed for a parameter, however the function which is called does not seem to accept null.

We recommend to add an additional type check (or disallow null for the parameter):

function notNullable(stdClass $x) { }

// Unsafe
function withoutCheck(stdClass $x = null) {
    notNullable($x);
}

// Safe - Alternative 1: Adding Additional Type-Check
function withCheck(stdClass $x = null) {
    if ($x instanceof stdClass) {
        notNullable($x);
    }
}

// Safe - Alternative 2: Changing Parameter
function withNonNullableParam(stdClass $x) {
    notNullable($x);
}
Loading history...
43
    }
44
}
45