Identifier::__construct() - Code Metrics - Inspection of "WIP: 5.25 Operation: 02.25 Flight Option - Anchore..." - amabnl/amadeus-ws-client - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#324)

unknown

created 2019-12-19 13:25 UTC

Identifier::__construct() A

↳ Parent: Identifier

Complexity

Conditions	4
Paths	8

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.7333
c	0
b	0
f	0
cc	4
nc	8
nop	1

<?php
/**
 * amadeus-ws-client
 *
 * Copyright 2015 Amadeus Benelux NV
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 *
 * @package Amadeus
 * @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
 */
namespace Amadeus\Client\Struct\Service\BookPriceService;

/**
 * Identifier
 *
 * @package Amadeus\Client\Struct\Service\BookPriceService
 * @author Mike Hernas <[email protected]>
 */
class Identifier
{
    /**
     * @var int
     */
    public $bookingMethod;

    /**
     * @var string|null
     */
    public $RFIC = null;

    /**
     * @var string|null
     */
    public $RFISC = null;

    /**
     * @var string|null
     */
    public $Code = null;

    /**
     * Identifier constructor.
     *
     * @param Identifier $identifierOptions
     */
    public function __construct($identifierOptions)
    {
        $this->bookingMethod = $identifierOptions->bookingMethod;

        if ($identifierOptions->code) {
            $this->Code = $identifierOptions->code;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }

        if ($identifierOptions->RFISC) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->RFISC = $identifierOptions->RFISC;
        }

        if ($identifierOptions->RFIC) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->RFIC = $identifierOptions->RFIC;
        }
    }
}


1			<?php
2			/**
3			* amadeus-ws-client
4			*
5			* Copyright 2015 Amadeus Benelux NV
6			*
7			* Licensed under the Apache License, Version 2.0 (the "License");
8			* you may not use this file except in compliance with the License.
9			* You may obtain a copy of the License at
10			*
11			* http://www.apache.org/licenses/LICENSE-2.0
12			*
13			* Unless required by applicable law or agreed to in writing, software
14			* distributed under the License is distributed on an "AS IS" BASIS,
15			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16			* See the License for the specific language governing permissions and
17			* limitations under the License.
18			*
19			* @package Amadeus
20			* @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
21			*/
22			namespace Amadeus\Client\Struct\Service\BookPriceService;
23
24			/**
25			* Identifier
26			*
27			* @package Amadeus\Client\Struct\Service\BookPriceService
28			* @author Mike Hernas <[email protected]>
29			*/
30			class Identifier
31			{
32			/**
33			* @var int
34			*/
35			public $bookingMethod;
36
37			/**
38			* @var string\|null
39			*/
40			public $RFIC = null;
41
42			/**
43			* @var string\|null
44			*/
45			public $RFISC = null;
46
47			/**
48			* @var string\|null
49			*/
50			public $Code = null;
51
52			/**
53			* Identifier constructor.
54			*
55			* @param Identifier $identifierOptions
56			*/
57			public function __construct($identifierOptions)
58			{
59			$this->bookingMethod = $identifierOptions->bookingMethod;
60
61			if ($identifierOptions->code) {
62			$this->Code = $identifierOptions->code;
			0 ignored issues – show Bug introduced 2019-12-19 13:39 UTC by Report Bug Copy Issue Report The property `code` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
63			}
64
65			if ($identifierOptions->RFISC) {
			0 ignored issues – show Bug Best Practice introduced 2019-12-19 13:39 UTC by Report Bug Copy Issue Report The expression `$identifierOptions->RFISC` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
66			$this->RFISC = $identifierOptions->RFISC;
67			}
68
69			if ($identifierOptions->RFIC) {
			0 ignored issues – show Bug Best Practice introduced 2019-12-19 13:39 UTC by Report Bug Copy Issue Report The expression `$identifierOptions->RFIC` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
70			$this->RFIC = $identifierOptions->RFIC;
71			}
72			}
73			}
74

amabnl / amadeus-ws-client

Pull Request — master (#324)

Identifier::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like