HandlerBookPriceService::analyze() - Code Metrics - Inspection of "WIP: 5.25 Operation: 02.25 Flight Option - Anchore..." - amabnl/amadeus-ws-client - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#324)

unknown

created 2019-12-19 13:25 UTC

HandlerBookPriceService::analyze() A

↳ Parent: HandlerBookPriceService

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	30
rs	9.44
c	0
b	0
f	0
cc	4
nc	4
nop	1

<?php
/**
 * amadeus-ws-client
 *
 * Copyright 2015 Amadeus Benelux NV
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 *
 * @package Amadeus
 * @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
 */

namespace Amadeus\Client\ResponseHandler\Service;

use Amadeus\Client\ResponseHandler\StandardResponseHandler;
use Amadeus\Client\Result;
use Amadeus\Client\Session\Handler\SendResult;

/**
 * HandlerBookPriceService
 *
 * @package Amadeus\Client\ResponseHandler\Service
 * @author Mike Hernas <[email protected]>
 */
class HandlerBookPriceService extends StandardResponseHandler
{
    /**
     * @param SendResult $response
     * @return Result
     */
    public function analyze(SendResult $response)
    {
        $analyzeResponse = new Result($response);
        $domXpath = $this->makeDomXpath($response->responseXml);

        $errorCodeNodeList = $domXpath->query("//ama:Error");

        if ($errorCodeNodeList->length > 0) {
            $analyzeResponse->status = Result::STATUS_ERROR;

            $errorCatNode = $errorCodeNodeList->item(0);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            foreach (iterator_to_array($errorCodeNodeList) as $msg) {
                $analyzeResponse->messages[] = new Result\NotOk(
                    $msg->getAttribute('Code'),
                    trim($msg->getAttribute('ShortText'))
                );
            }

            return $analyzeResponse;
        }

        $success = $domXpath->query('//m:Success');
        if ($success->length > 0) {
            $analyzeResponse->status = Result::STATUS_OK;
            return $analyzeResponse;
        }

        $analyzeResponse->status = Result::STATUS_UNKNOWN;
        return $analyzeResponse;
    }
}


1			<?php
2			/**
3			* amadeus-ws-client
4			*
5			* Copyright 2015 Amadeus Benelux NV
6			*
7			* Licensed under the Apache License, Version 2.0 (the "License");
8			* you may not use this file except in compliance with the License.
9			* You may obtain a copy of the License at
10			*
11			* http://www.apache.org/licenses/LICENSE-2.0
12			*
13			* Unless required by applicable law or agreed to in writing, software
14			* distributed under the License is distributed on an "AS IS" BASIS,
15			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16			* See the License for the specific language governing permissions and
17			* limitations under the License.
18			*
19			* @package Amadeus
20			* @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
21			*/
22
23			namespace Amadeus\Client\ResponseHandler\Service;
24
25			use Amadeus\Client\ResponseHandler\StandardResponseHandler;
26			use Amadeus\Client\Result;
27			use Amadeus\Client\Session\Handler\SendResult;
28
29			/**
30			* HandlerBookPriceService
31			*
32			* @package Amadeus\Client\ResponseHandler\Service
33			* @author Mike Hernas <[email protected]>
34			*/
35			class HandlerBookPriceService extends StandardResponseHandler
36			{
37			/**
38			* @param SendResult $response
39			* @return Result
40			*/
41			public function analyze(SendResult $response)
42			{
43			$analyzeResponse = new Result($response);
44			$domXpath = $this->makeDomXpath($response->responseXml);
45
46			$errorCodeNodeList = $domXpath->query("//ama:Error");
47
48			if ($errorCodeNodeList->length > 0) {
49			$analyzeResponse->status = Result::STATUS_ERROR;
50
51			$errorCatNode = $errorCodeNodeList->item(0);
			0 ignored issues – show Unused Code introduced 2019-12-19 13:39 UTC by Report Bug Copy Issue Report `$errorCatNode` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
52			foreach (iterator_to_array($errorCodeNodeList) as $msg) {
53			$analyzeResponse->messages[] = new Result\NotOk(
54			$msg->getAttribute('Code'),
55			trim($msg->getAttribute('ShortText'))
56			);
57			}
58
59			return $analyzeResponse;
60			}
61
62			$success = $domXpath->query('//m:Success');
63			if ($success->length > 0) {
64			$analyzeResponse->status = Result::STATUS_OK;
65			return $analyzeResponse;
66			}
67
68			$analyzeResponse->status = Result::STATUS_UNKNOWN;
69			return $analyzeResponse;
70			}
71			}
72

amabnl / amadeus-ws-client

Pull Request — master (#324)

HandlerBookPriceService::analyze() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like