ProcessETicket::loadMsgAction() - Code Metrics - Inspection of "New messages: `DocRefund_IgnoreRefund` and `Ticket..." - amabnl/amadeus-ws-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1d411d...695480 )

by Dieter

created 2018-04-19 20:42 UTC

ProcessETicket::loadMsgAction() A

↳ Parent: ProcessETicket

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	6
ccs	5
cts	5
cp	1
rs	9.4285
cc	2
eloc	3
nc	2
nop	1
crap	2

<?php
/**
 * amadeus-ws-client
 *
 * Copyright 2015 Amadeus Benelux NV
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 *
 * @package Amadeus
 * @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
 */

namespace Amadeus\Client\Struct\Ticket;

use Amadeus\Client\RequestOptions\TicketProcessETicketOptions;
use Amadeus\Client\Struct\BaseWsMessage;
use Amadeus\Client\Struct\Ticket\ProcessETicket\TicketInfoGroup;
use Amadeus\Client\Struct\Ticket\ProcessEDoc\MsgActionDetails;

/**
 * TicketProcessETicket
 *
 * Basic Request structure for the TicketProcessETicket messages
 *
 * @package Amadeus\Client\Struct\Ticket\EDoc
 * @author Mike Hernas <[email protected]>
 */
class ProcessETicket extends BaseWsMessage
{
    /**
     * @var MsgActionDetails
     */
    public $msgActionDetails;

    /**
     * @var TicketInfoGroup[]
     */
    public $ticketInfoGroup = [];


    /**
     * ProcessETicket constructor.
     *
     * @param TicketProcessETicketOptions $options
     */
    public function __construct(TicketProcessETicketOptions $options)
    {
        $this->loadOptions($options->ticketNumber);
        $this->loadMsgAction($options->action);
    }

    /**
     * @param string $ticketNumber
     */
    protected function loadOptions($ticketNumber)
    {
        if (!empty($ticketNumber)) {
            $this->ticketInfoGroup[] = new TicketInfoGroup($ticketNumber);
        }
    }

    /**
     * @param string $action
     * @param string[] $additionalActions
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    protected function loadMsgAction($action)
    {
        if ($this->checkAnyNotEmpty($action)) {
            $this->msgActionDetails = new MsgActionDetails($action, null);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
    }
}


1		<?php
2		/**
3		* amadeus-ws-client
4		*
5		* Copyright 2015 Amadeus Benelux NV
6		*
7		* Licensed under the Apache License, Version 2.0 (the "License");
8		* you may not use this file except in compliance with the License.
9		* You may obtain a copy of the License at
10		*
11		* http://www.apache.org/licenses/LICENSE-2.0
12		*
13		* Unless required by applicable law or agreed to in writing, software
14		* distributed under the License is distributed on an "AS IS" BASIS,
15		* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16		* See the License for the specific language governing permissions and
17		* limitations under the License.
18		*
19		* @package Amadeus
20		* @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
21		*/
22
23		namespace Amadeus\Client\Struct\Ticket;
24
25		use Amadeus\Client\RequestOptions\TicketProcessETicketOptions;
26		use Amadeus\Client\Struct\BaseWsMessage;
27		use Amadeus\Client\Struct\Ticket\ProcessETicket\TicketInfoGroup;
28		use Amadeus\Client\Struct\Ticket\ProcessEDoc\MsgActionDetails;
29
30		/**
31		* TicketProcessETicket
32		*
33		* Basic Request structure for the TicketProcessETicket messages
34		*
35		* @package Amadeus\Client\Struct\Ticket\EDoc
36		* @author Mike Hernas <[email protected]>
37		*/
38		class ProcessETicket extends BaseWsMessage
39		{
40		/**
41		* @var MsgActionDetails
42		*/
43		public $msgActionDetails;
44
45		/**
46		* @var TicketInfoGroup[]
47		*/
48		public $ticketInfoGroup = [];
49
50
51		/**
52		* ProcessETicket constructor.
53		*
54		* @param TicketProcessETicketOptions $options
55		*/
56	8	public function __construct(TicketProcessETicketOptions $options)
57		{
58	8	$this->loadOptions($options->ticketNumber);
59	8	$this->loadMsgAction($options->action);
60	8	}
61
62		/**
63		* @param string $ticketNumber
64		*/
65	8	protected function loadOptions($ticketNumber)
66		{
67	8	if (!empty($ticketNumber)) {
68	8	$this->ticketInfoGroup[] = new TicketInfoGroup($ticketNumber);
69	4	}
70	8	}
71
72		/**
73		* @param string $action
74		* @param string[] $additionalActions
		0 ignored issues – show Documentation introduced 2018-04-14 14:47 UTC by Report Bug Copy Issue Report There is no parameter named `$additionalActions`. Did you maybe mean `$action`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
75		*/
76	8	protected function loadMsgAction($action)
77		{
78	8	if ($this->checkAnyNotEmpty($action)) {
79	8	$this->msgActionDetails = new MsgActionDetails($action, null);
		0 ignored issues – show Documentation introduced 2018-04-14 14:47 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `array<integer,string>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
80	4	}
81	8	}
82		}
83

amabnl / amadeus-ws-client

Push — master ( 1d411d...695480 )

ProcessETicket::loadMsgAction() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like