HandlerInitRefund::analyze() - Code Metrics - Inspection of "New messages: `DocRefund_IgnoreRefund` and `Ticket..." - amabnl/amadeus-ws-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1d411d...695480 )

by Dieter

created 2018-04-19 20:42 UTC

HandlerInitRefund::analyze() B

↳ Parent: HandlerInitRefund

Complexity

Conditions	4
Paths	4

Size

Total Lines	27
Code Lines	16

Duplication

Lines	27
Ratio	100 %

Code Coverage

Tests	17
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	27
loc	27
ccs	17
cts	17
cp	1
rs	8.5806
cc	4
eloc	16
nc	4
nop	1
crap	4

<?php
/**
 * amadeus-ws-client
 *
 * Copyright 2015 Amadeus Benelux NV
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 *
 * @package Amadeus
 * @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
 */

namespace Amadeus\Client\ResponseHandler\Ticket;

use Amadeus\Client\ResponseHandler\StandardResponseHandler;
use Amadeus\Client\Result;
use Amadeus\Client\Session\Handler\SendResult;

/**
 * HandlerInitRefund
 *
 * @package Amadeus\Client\ResponseHandler\Ticket
 * @author Mike Hernas <[email protected]>
 */
class HandlerInitRefund extends StandardResponseHandler

{
    /**
     * @param SendResult $response
     * @return Result
     */
    public function analyze(SendResult $response)
    {
        $analyzeResponse = new Result($response);
        $domXpath = $this->makeDomXpath($response->responseXml);

        $errorCodeNodeList = $domXpath->query("//ama:Errors");

        if ($errorCodeNodeList->length > 0) {
            $analyzeResponse->status = Result::STATUS_ERROR;

            $errorCatNode = $errorCodeNodeList->item(0);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            foreach (iterator_to_array($errorCodeNodeList) as $msg) {
                $analyzeResponse->messages[] = trim($msg->nodeValue);
            }

            return $analyzeResponse;
        }

        $success = $domXpath->query('//m:GeneralReply//m:Success');
        if ($success->length > 0) {
            $analyzeResponse->status = Result::STATUS_OK;
            return $analyzeResponse;
        }

        $analyzeResponse->status = Result::STATUS_UNKNOWN;
        return $analyzeResponse;
    }
}


1			<?php
2			/**
3			* amadeus-ws-client
4			*
5			* Copyright 2015 Amadeus Benelux NV
6			*
7			* Licensed under the Apache License, Version 2.0 (the "License");
8			* you may not use this file except in compliance with the License.
9			* You may obtain a copy of the License at
10			*
11			* http://www.apache.org/licenses/LICENSE-2.0
12			*
13			* Unless required by applicable law or agreed to in writing, software
14			* distributed under the License is distributed on an "AS IS" BASIS,
15			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16			* See the License for the specific language governing permissions and
17			* limitations under the License.
18			*
19			* @package Amadeus
20			* @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
21			*/
22
23			namespace Amadeus\Client\ResponseHandler\Ticket;
24
25			use Amadeus\Client\ResponseHandler\StandardResponseHandler;
26			use Amadeus\Client\Result;
27			use Amadeus\Client\Session\Handler\SendResult;
28
29			/**
30			* HandlerInitRefund
31			*
32			* @package Amadeus\Client\ResponseHandler\Ticket
33			* @author Mike Hernas <[email protected]>
34			*/
35		View Code Duplication	class HandlerInitRefund extends StandardResponseHandler
			0 ignored issues – show Duplication introduced 2018-04-18 14:16 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36			{
37			/**
38			* @param SendResult $response
39			* @return Result
40			*/
41	12		public function analyze(SendResult $response)
42			{
43	12		$analyzeResponse = new Result($response);
44	12		$domXpath = $this->makeDomXpath($response->responseXml);
45
46	12		$errorCodeNodeList = $domXpath->query("//ama:Errors");
47
48	12		if ($errorCodeNodeList->length > 0) {
49	4		$analyzeResponse->status = Result::STATUS_ERROR;
50
51	4		$errorCatNode = $errorCodeNodeList->item(0);
			0 ignored issues – show Unused Code introduced 2018-04-18 16:19 UTC by Report Bug Copy Issue Report `$errorCatNode` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
52	4		foreach (iterator_to_array($errorCodeNodeList) as $msg) {
53	4		$analyzeResponse->messages[] = trim($msg->nodeValue);
54	2		}
55
56	4		return $analyzeResponse;
57			}
58
59	8		$success = $domXpath->query('//m:GeneralReply//m:Success');
60	8		if ($success->length > 0) {
61	4		$analyzeResponse->status = Result::STATUS_OK;
62	4		return $analyzeResponse;
63			}
64
65	4		$analyzeResponse->status = Result::STATUS_UNKNOWN;
66	4		return $analyzeResponse;
67			}
68			}
69

amabnl / amadeus-ws-client

Push — master ( 1d411d...695480 )

HandlerInitRefund::analyze() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like