Completed
Pull Request — master (#222)
by
unknown
12:13 queued 30s
created

PriceUpsellWithoutPNRConv   A

Complexity

Total Complexity 2

Size/Duplication

Total Lines 16
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 3

Test Coverage

Coverage 0%

Importance

Changes 0
Metric Value
wmc 2
lcom 0
cbo 3
dl 0
loc 16
ccs 0
cts 8
cp 0
rs 10
c 0
b 0
f 0

1 Method

Rating   Name   Duplication   Size   Complexity  
A convert() 0 8 2
1
<?php
2
/**
3
 * amadeus-ws-client
4
 *
5
 * Copyright 2015 Amadeus Benelux NV
6
 *
7
 * Licensed under the Apache License, Version 2.0 (the "License");
8
 * you may not use this file except in compliance with the License.
9
 * You may obtain a copy of the License at
10
 *
11
 * http://www.apache.org/licenses/LICENSE-2.0
12
 *
13
 * Unless required by applicable law or agreed to in writing, software
14
 * distributed under the License is distributed on an "AS IS" BASIS,
15
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16
 * See the License for the specific language governing permissions and
17
 * limitations under the License.
18
 *
19
 * @package Amadeus
20
 * @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
21
 */
22
23
namespace Amadeus\Client\RequestCreator\Converter\Fare;
24
25
use Amadeus\Client\RequestCreator\Converter\BaseConverter;
26
use Amadeus\Client\RequestOptions\FareInformativeBestPricingWithoutPnrOptions;
27
use Amadeus\Client\Struct;
28
29
/**
30
 * Fare_InformativeBestPricingWithoutPNR Request converter
31
 *
32
 * @package Amadeus\Client\RequestCreator\Converter\Fare
33
 * @author Leonardo Travel <[email protected]>
34
 */
35
class PriceUpsellWithoutPNRConv extends BaseConverter
36
{
37
    /**
38
     * @param FareInformativeBestPricingWithoutPnrOptions $requestOptions
39
     * @param int|string $version
40
     * @return Struct\Fare\InformativePriceUpsellWithoutPNR15|Struct\Fare\InformativePriceUpsellWithoutPNR16
41
     */
42
    public function convert($requestOptions, $version)
43
    {
44
        if (floatval($version) < floatval(16)) {
45
            return new Struct\Fare\InformativePriceUpsellWithoutPNR15($requestOptions);
0 ignored issues
show
Documentation introduced by
$requestOptions is of type object<Amadeus\Client\Re...icingWithoutPnrOptions>, but the function expects a null|object<Amadeus\Clie...psellWithoutPNROptions>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
46
        } else {
47
            return new Struct\Fare\InformativePriceUpsellWithoutPNR16($requestOptions);
0 ignored issues
show
Documentation introduced by
$requestOptions is of type object<Amadeus\Client\Re...icingWithoutPnrOptions>, but the function expects a null|object<Amadeus\Clie...psellWithoutPNROptions>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
48
        }
49
    }
50
}
51