InformativeBestPricingWithoutPNR13::loadCabin() - Code Metrics - Inspection of "Fare_InformativeBestPricingWithoutPNR - Set attrib..." - amabnl/amadeus-ws-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#248)

by Dieter

created 2018-11-25 15:14 UTC

InformativeBestPricingWithoutPNR13::loadCabin() A

↳ Parent: InformativeBestPricingWithoutPNR13

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	8
cts	8
cp	1
rs	9.9
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2

<?php
/**
 * amadeus-ws-client
 *
 * Copyright 2015 Amadeus Benelux NV
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 *
 * @package Amadeus
 * @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
 */

namespace Amadeus\Client\Struct\Fare;

use Amadeus\Client\RequestOptions\Fare\InformativeBestPricingWithoutPnr\Cabin;
use Amadeus\Client\RequestOptions\FareInformativeBestPricingWithoutPnrOptions;
use Amadeus\Client\Struct\Fare\PricePnr13\PricingOptionGroup;
use Amadeus\Client\Struct\Fare\PricePnr13\PricingOptionKey;

/**
 * InformativeBestPricingWithoutPNR13
 *
 * @package Amadeus\Client\Struct\Fare
 * @author Dieter Devlieghere <[email protected]>
 */
class InformativeBestPricingWithoutPNR13 extends InformativePricingWithoutPNR13
{
    /**
     * InformativeBestPricingWithoutPNR13 constructor.
     *
     * @param FareInformativeBestPricingWithoutPnrOptions|null $options
     */
    public function __construct(FareInformativeBestPricingWithoutPnrOptions $options = null)
    {
        parent::__construct($options);

        if (!empty($options->cabin)) {
            $this->loadCabin($options->cabin);
        }
    }

    /**
     * @param Cabin $cabin
     * @return InformativeBestPricingWithoutPNR13
     */
    protected function loadCabin($cabin)
    {
        if ($cabin instanceof Cabin) {
            $this->pricingOptionGroup = array_merge(
                $this->pricingOptionGroup,
                [new PricingOptionGroup(PricingOptionKey::OPTION_CABIN, $cabin->criteriaDetails)]
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            );
        }

        return $this;
    }
}


1		<?php
2		/**
3		* amadeus-ws-client
4		*
5		* Copyright 2015 Amadeus Benelux NV
6		*
7		* Licensed under the Apache License, Version 2.0 (the "License");
8		* you may not use this file except in compliance with the License.
9		* You may obtain a copy of the License at
10		*
11		* http://www.apache.org/licenses/LICENSE-2.0
12		*
13		* Unless required by applicable law or agreed to in writing, software
14		* distributed under the License is distributed on an "AS IS" BASIS,
15		* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16		* See the License for the specific language governing permissions and
17		* limitations under the License.
18		*
19		* @package Amadeus
20		* @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
21		*/
22
23		namespace Amadeus\Client\Struct\Fare;
24
25		use Amadeus\Client\RequestOptions\Fare\InformativeBestPricingWithoutPnr\Cabin;
26		use Amadeus\Client\RequestOptions\FareInformativeBestPricingWithoutPnrOptions;
27		use Amadeus\Client\Struct\Fare\PricePnr13\PricingOptionGroup;
28		use Amadeus\Client\Struct\Fare\PricePnr13\PricingOptionKey;
29
30		/**
31		* InformativeBestPricingWithoutPNR13
32		*
33		* @package Amadeus\Client\Struct\Fare
34		* @author Dieter Devlieghere <[email protected]>
35		*/
36		class InformativeBestPricingWithoutPNR13 extends InformativePricingWithoutPNR13
37		{
38		/**
39		* InformativeBestPricingWithoutPNR13 constructor.
40		*
41		* @param FareInformativeBestPricingWithoutPnrOptions\|null $options
42		*/
43	12	public function __construct(FareInformativeBestPricingWithoutPnrOptions $options = null)
44		{
45	12	parent::__construct($options);
46
47	12	if (!empty($options->cabin)) {
48	4	$this->loadCabin($options->cabin);
49	2	}
50	12	}
51
52		/**
53		* @param Cabin $cabin
54		* @return InformativeBestPricingWithoutPNR13
55		*/
56	4	protected function loadCabin($cabin)
57		{
58	4	if ($cabin instanceof Cabin) {
59	4	$this->pricingOptionGroup = array_merge(
60	4	$this->pricingOptionGroup,
61	4	[new PricingOptionGroup(PricingOptionKey::OPTION_CABIN, $cabin->criteriaDetails)]
		0 ignored issues – show Documentation introduced 2018-10-25 09:16 UTC by Report Bug Copy Issue Report `$cabin->criteriaDetails` is of type `array`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
62	2	);
63	2	}
64
65	4	return $this;
66		}
67		}
68

amabnl / amadeus-ws-client

Pull Request — master (#248)

InformativeBestPricingWithoutPNR13::loadCabin() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like