DisplayQueryReport::loadCurrency() - Code Metrics - Inspection of "New message: SalesReports_DisplayQueryReports - wi..." - amabnl/amadeus-ws-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( b71e24...13e4b5 )

by Dieter

created 2016-09-14 20:03 UTC

DisplayQueryReport::loadCurrency() A

↳ Parent: DisplayQueryReport

Complexity

Conditions	3
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	6
rs	9.4285
c	1
b	0
f	0
cc	3
eloc	3
nc	2
nop	2

<?php
/**
 * amadeus-ws-client
 *
 * Copyright 2015 Amadeus Benelux NV
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 *
 * @package Amadeus
 * @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
 */

namespace Amadeus\Client\Struct\SalesReports;

use Amadeus\Client\RequestOptions\SalesReportsDisplayQueryReportOptions;
use Amadeus\Client\Struct\BaseWsMessage;
use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\ActionDetails;
use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\AgencyDetails;
use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\AgentUserDetails;
use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\CurrencyInfo;
use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\DateDetails;
use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\FormOfPaymentDetails;
use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\RequestOption;
use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\SalesIndicator;
use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\SalesPeriodDetails;
use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\TransactionData;
use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\ValidatingCarrierDetails;

/**
 * DisplayQueryReport
 *
 * @package Amadeus\Client\Struct\SalesReports
 * @author Dieter Devlieghere <[email protected]>
 */
class DisplayQueryReport extends BaseWsMessage
{
    /**
     * @var DisplayQueryReport\ActionDetails
     */
    public $actionDetails;

    /**
     * @var DisplayQueryReport\AgentUserDetails
     */
    public $agentUserDetails;

    /**
     * @var DisplayQueryReport\DateDetails
     */
    public $dateDetails;

    /**
     * @var DisplayQueryReport\CurrencyInfo
     */
    public $currencyInfo;

    /**
     * @var DisplayQueryReport\AgencyDetails
     */
    public $agencyDetails;

    /**
     * @var DisplayQueryReport\SalesPeriodDetails
     */
    public $salesPeriodDetails;

    /**
     * @var DisplayQueryReport\TransactionData[]
     */
    public $transactionData = [];

    /**
     * @var DisplayQueryReport\FormOfPaymentDetails
     */
    public $formOfPaymentDetails;

    /**
     * @var DisplayQueryReport\ValidatingCarrierDetails
     */
    public $validatingCarrierDetails;

    /**
     * @var DisplayQueryReport\RequestOption
     */
    public $requestOption;

    /**
     * @var DisplayQueryReport\SalesIndicator
     */
    public $salesIndicator;

    /**
     * @var DisplayQueryReport\FromSequenceDocumentNumber
     */
    public $fromSequenceDocumentNumber;

    /**
     * @var DisplayQueryReport\AttributeInfo
     */
    public $attributeInfo;

    /**
     * DisplayQueryReport constructor.
     *
     * @param SalesReportsDisplayQueryReportOptions $options
     */
    public function __construct(SalesReportsDisplayQueryReportOptions $options)
    {
        $this->loadRequestOptions($options->requestOptions);

        $this->loadAgencySource($options->agencySourceType, $options->agencyIataNumber, $options->agencyOfficeId);

        $this->loadAgent($options->agentCode);

        $this->loadTransaction(
            $options->transactionCode,
            $options->transactionType,
            $options->transactionIssueIndicator
        );

        $this->loadValidatingCarrier($options->validatingCarrier);

        $this->loadDateRange($options->startDate, $options->endDate);

        $this->loadDate($options->specificDateType, $options->specificDate);

        $this->loadCurrency($options->currencyType, $options->currency);

        $this->loadFormOfPayment($options->fopType, $options->fopVendor);

        $this->loadSalesIndicator($options->salesIndicator);

        $this->loadScrolling($options->scrollingCount, $options->scrollingFromItem);
    }

    /**
     * @param array|null $requestOptions
     */
    protected function loadRequestOptions($requestOptions)
    {
        if (!empty($requestOptions)) {
            $this->requestOption = new RequestOption($requestOptions);
        }
    }

    /**
     * @param string|null $agencySourceType
     * @param string|null $iataNumber
     * @param string|null $officeId
     */
    protected function loadAgencySource($agencySourceType, $iataNumber, $officeId)
    {
        if (!empty($agencySourceType) || !empty($iataNumber) || !empty($officeId)) {
            $this->agencyDetails = new AgencyDetails($agencySourceType, $iataNumber, $officeId);
        }
    }

    /**
     * @param string|null $agentCode
     */
    protected function loadAgent($agentCode)
    {
        if (!empty($agentCode)) {
            $this->agentUserDetails = new AgentUserDetails($agentCode);
        }
    }

    /**
     * @param string|null $code
     * @param string|null $type
     * @param string|null $issueIndicator
     */
    protected function loadTransaction($code, $type, $issueIndicator)
    {
        if (!empty($type) || !empty($code) || !empty($issueIndicator)) {
            $this->transactionData[] = new TransactionData($type, $code, $issueIndicator);
        }
    }

    /**
     * @param string|null $validatingCarrier
     */
    protected function loadValidatingCarrier($validatingCarrier)
    {
        if (!empty($validatingCarrier)) {
            $this->validatingCarrierDetails = new ValidatingCarrierDetails($validatingCarrier);
        }
    }

    /**
     * @param \DateTime|null $startDate
     * @param \DateTime|null $endDate
     */
    protected function loadDateRange($startDate, $endDate)
    {
        if (!empty($startDate) || !empty($endDate)) {
            $this->salesPeriodDetails = new SalesPeriodDetails($startDate, $endDate);
        }
    }

    /**
     * @param string|null $type
     * @param \DateTime|null $date
     */
    protected function loadDate($type, $date)
    {
        if (!empty($type) || !empty($date)) {
            $this->dateDetails = new DateDetails($type, $date);
function notNullable(stdClass $x) { }

// Unsafe
function withoutCheck(stdClass $x = null) {
    notNullable($x);
}

// Safe - Alternative 1: Adding Additional Type-Check
function withCheck(stdClass $x = null) {
    if ($x instanceof stdClass) {
        notNullable($x);
    }
}

// Safe - Alternative 2: Changing Parameter
function withNonNullableParam(stdClass $x) {
    notNullable($x);
}
        }
    }

    /**
     * @param string $type
     * @param string $currency
     */
    protected function loadCurrency($type, $currency)
    {
        if (!empty($type) || !empty($currency)) {
            $this->currencyInfo = new CurrencyInfo($type, $currency);
        }
    }

    /**
     * @param string $type
     * @param string $vendor
     */
    protected function loadFormOfPayment($type, $vendor)
    {
        if (!empty($type) || !empty($vendor)) {
            $this->formOfPaymentDetails = new FormOfPaymentDetails($type, $vendor);
        }
    }

    /**
     * @param string $indicator
     */
    protected function loadSalesIndicator($indicator)
    {
        if (!empty($indicator)) {
            $this->salesIndicator = new SalesIndicator($indicator);
        }
    }

    /**
     * @param int $count
     * @param string $fromItem
     */
    protected function loadScrolling($count, $fromItem)
    {
        if (!empty($count) || !empty($fromItem)) {
            $this->actionDetails = new ActionDetails($count, $fromItem);
        }
    }
}


1			<?php
2			/**
3			* amadeus-ws-client
4			*
5			* Copyright 2015 Amadeus Benelux NV
6			*
7			* Licensed under the Apache License, Version 2.0 (the "License");
8			* you may not use this file except in compliance with the License.
9			* You may obtain a copy of the License at
10			*
11			* http://www.apache.org/licenses/LICENSE-2.0
12			*
13			* Unless required by applicable law or agreed to in writing, software
14			* distributed under the License is distributed on an "AS IS" BASIS,
15			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16			* See the License for the specific language governing permissions and
17			* limitations under the License.
18			*
19			* @package Amadeus
20			* @license https://opensource.org/licenses/Apache-2.0 Apache 2.0
21			*/
22
23			namespace Amadeus\Client\Struct\SalesReports;
24
25			use Amadeus\Client\RequestOptions\SalesReportsDisplayQueryReportOptions;
26			use Amadeus\Client\Struct\BaseWsMessage;
27			use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\ActionDetails;
28			use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\AgencyDetails;
29			use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\AgentUserDetails;
30			use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\CurrencyInfo;
31			use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\DateDetails;
32			use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\FormOfPaymentDetails;
33			use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\RequestOption;
34			use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\SalesIndicator;
35			use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\SalesPeriodDetails;
36			use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\TransactionData;
37			use Amadeus\Client\Struct\SalesReports\DisplayQueryReport\ValidatingCarrierDetails;
38
39			/**
40			* DisplayQueryReport
41			*
42			* @package Amadeus\Client\Struct\SalesReports
43			* @author Dieter Devlieghere <[email protected]>
44			*/
45			class DisplayQueryReport extends BaseWsMessage
46			{
47			/**
48			* @var DisplayQueryReport\ActionDetails
49			*/
50			public $actionDetails;
51
52			/**
53			* @var DisplayQueryReport\AgentUserDetails
54			*/
55			public $agentUserDetails;
56
57			/**
58			* @var DisplayQueryReport\DateDetails
59			*/
60			public $dateDetails;
61
62			/**
63			* @var DisplayQueryReport\CurrencyInfo
64			*/
65			public $currencyInfo;
66
67			/**
68			* @var DisplayQueryReport\AgencyDetails
69			*/
70			public $agencyDetails;
71
72			/**
73			* @var DisplayQueryReport\SalesPeriodDetails
74			*/
75			public $salesPeriodDetails;
76
77			/**
78			* @var DisplayQueryReport\TransactionData[]
79			*/
80			public $transactionData = [];
81
82			/**
83			* @var DisplayQueryReport\FormOfPaymentDetails
84			*/
85			public $formOfPaymentDetails;
86
87			/**
88			* @var DisplayQueryReport\ValidatingCarrierDetails
89			*/
90			public $validatingCarrierDetails;
91
92			/**
93			* @var DisplayQueryReport\RequestOption
94			*/
95			public $requestOption;
96
97			/**
98			* @var DisplayQueryReport\SalesIndicator
99			*/
100			public $salesIndicator;
101
102			/**
103			* @var DisplayQueryReport\FromSequenceDocumentNumber
104			*/
105			public $fromSequenceDocumentNumber;
106
107			/**
108			* @var DisplayQueryReport\AttributeInfo
109			*/
110			public $attributeInfo;
111
112			/**
113			* DisplayQueryReport constructor.
114			*
115			* @param SalesReportsDisplayQueryReportOptions $options
116			*/
117			public function __construct(SalesReportsDisplayQueryReportOptions $options)
118			{
119			$this->loadRequestOptions($options->requestOptions);
120
121			$this->loadAgencySource($options->agencySourceType, $options->agencyIataNumber, $options->agencyOfficeId);
122
123			$this->loadAgent($options->agentCode);
124
125			$this->loadTransaction(
126			$options->transactionCode,
127			$options->transactionType,
128			$options->transactionIssueIndicator
129			);
130
131			$this->loadValidatingCarrier($options->validatingCarrier);
132
133			$this->loadDateRange($options->startDate, $options->endDate);
134
135			$this->loadDate($options->specificDateType, $options->specificDate);
136
137			$this->loadCurrency($options->currencyType, $options->currency);
138
139			$this->loadFormOfPayment($options->fopType, $options->fopVendor);
140
141			$this->loadSalesIndicator($options->salesIndicator);
142
143			$this->loadScrolling($options->scrollingCount, $options->scrollingFromItem);
144			}
145
146			/**
147			* @param array\|null $requestOptions
148			*/
149			protected function loadRequestOptions($requestOptions)
150			{
151			if (!empty($requestOptions)) {
152			$this->requestOption = new RequestOption($requestOptions);
153			}
154			}
155
156			/**
157			* @param string\|null $agencySourceType
158			* @param string\|null $iataNumber
159			* @param string\|null $officeId
160			*/
161			protected function loadAgencySource($agencySourceType, $iataNumber, $officeId)
162			{
163			if (!empty($agencySourceType) \|\| !empty($iataNumber) \|\| !empty($officeId)) {
164			$this->agencyDetails = new AgencyDetails($agencySourceType, $iataNumber, $officeId);
165			}
166			}
167
168			/**
169			* @param string\|null $agentCode
170			*/
171			protected function loadAgent($agentCode)
172			{
173			if (!empty($agentCode)) {
174			$this->agentUserDetails = new AgentUserDetails($agentCode);
175			}
176			}
177
178			/**
179			* @param string\|null $code
180			* @param string\|null $type
181			* @param string\|null $issueIndicator
182			*/
183			protected function loadTransaction($code, $type, $issueIndicator)
184			{
185			if (!empty($type) \|\| !empty($code) \|\| !empty($issueIndicator)) {
186			$this->transactionData[] = new TransactionData($type, $code, $issueIndicator);
187			}
188			}
189
190			/**
191			* @param string\|null $validatingCarrier
192			*/
193			protected function loadValidatingCarrier($validatingCarrier)
194			{
195			if (!empty($validatingCarrier)) {
196			$this->validatingCarrierDetails = new ValidatingCarrierDetails($validatingCarrier);
197			}
198			}
199
200			/**
201			* @param \DateTime\|null $startDate
202			* @param \DateTime\|null $endDate
203			*/
204			protected function loadDateRange($startDate, $endDate)
205			{
206			if (!empty($startDate) \|\| !empty($endDate)) {
207			$this->salesPeriodDetails = new SalesPeriodDetails($startDate, $endDate);
208			}
209			}
210
211			/**
212			* @param string\|null $type
213			* @param \DateTime\|null $date
214			*/
215			protected function loadDate($type, $date)
216			{
217			if (!empty($type) \|\| !empty($date)) {
218			$this->dateDetails = new DateDetails($type, $date);
			0 ignored issues – show Bug introduced 2016-09-14 20:13 UTC by Report Bug Copy Issue Report It seems like `$date` defined by parameter `$date` on line `215` can be `null`; however, `Amadeus\Client\Struct\Sa...eDetails::__construct()` does not accept `null`, maybe add an additional type check? It seems like you allow that null is being passed for a parameter, however the function which is called does not seem to accept null. We recommend to add an additional type check (or disallow null for the parameter): function notNullable(stdClass $x) { } // Unsafe function withoutCheck(stdClass $x = null) { notNullable($x); } // Safe - Alternative 1: Adding Additional Type-Check function withCheck(stdClass $x = null) { if ($x instanceof stdClass) { notNullable($x); } } // Safe - Alternative 2: Changing Parameter function withNonNullableParam(stdClass $x) { notNullable($x); } Loading history...
219			}
220			}
221
222			/**
223			* @param string $type
224			* @param string $currency
225			*/
226			protected function loadCurrency($type, $currency)
227			{
228			if (!empty($type) \|\| !empty($currency)) {
229			$this->currencyInfo = new CurrencyInfo($type, $currency);
230			}
231			}
232
233			/**
234			* @param string $type
235			* @param string $vendor
236			*/
237			protected function loadFormOfPayment($type, $vendor)
238			{
239			if (!empty($type) \|\| !empty($vendor)) {
240			$this->formOfPaymentDetails = new FormOfPaymentDetails($type, $vendor);
241			}
242			}
243
244			/**
245			* @param string $indicator
246			*/
247			protected function loadSalesIndicator($indicator)
248			{
249			if (!empty($indicator)) {
250			$this->salesIndicator = new SalesIndicator($indicator);
251			}
252			}
253
254			/**
255			* @param int $count
256			* @param string $fromItem
257			*/
258			protected function loadScrolling($count, $fromItem)
259			{
260			if (!empty($count) \|\| !empty($fromItem)) {
261			$this->actionDetails = new ActionDetails($count, $fromItem);
262			}
263			}
264			}
265

amabnl / amadeus-ws-client

Push — develop ( b71e24...13e4b5 )

DisplayQueryReport::loadCurrency() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like