ama-team /
voxengine-scenario-framework
| Conditions | 1 |
| Paths | 32 |
| Total Lines | 78 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | var SDK = require('@ama-team/voxengine-sdk') |
||
| 16 | function Executor (ctx, options) { |
||
| 17 | var self = this |
||
| 18 | options = options || {} |
||
| 19 | var logger = Slf4j.factory(options.logger, 'ama-team.vsf.execution.executor') |
||
| 20 | |||
| 21 | /** |
||
| 22 | * @inheritDoc |
||
| 23 | */ |
||
| 24 | this.execute = function (fn, args) { |
||
| 25 | return fn.apply(ctx, args || []) |
||
| 26 | } |
||
| 27 | |||
| 28 | /** |
||
| 29 | * @inheritDoc |
||
| 30 | */ |
||
| 31 | this.promise = function (fn, args) { |
||
| 32 | try { |
||
| 33 | return Promise.resolve(self.execute(fn, args)) |
||
| 34 | } catch (e) { |
||
| 35 | return Promise.reject(e) |
||
| 36 | } |
||
| 37 | } |
||
| 38 | |||
| 39 | /** |
||
| 40 | * @param {THandler} handler |
||
| 41 | * @param {CancellationToken} [parent] |
||
| 42 | */ |
||
| 43 | function tokenFactory (handler, parent) { |
||
| 44 | var deps = parent ? [parent] : [] |
||
| 45 | return new CancellationToken(deps, 'handler `' + handler.id + '`') |
||
| 46 | } |
||
| 47 | |||
| 48 | /** |
||
| 49 | * @param {THandler} handler |
||
| 50 | * @param {CancellationToken} [token] |
||
| 51 | * @param {*[]} [args] |
||
| 52 | * @param {number} tokenArg |
||
| 53 | * @return {Function} |
||
| 54 | */ |
||
| 55 | function callbackFactory (handler, args, token, tokenArg) { |
||
| 56 | return function (resolve, reject) { |
||
| 57 | var message = 'Handler `' + handler.id + '` has exceeded it\'s timeout ' + |
||
| 58 | 'of ' + handler.timeout + ' ms' |
||
| 59 | logger.warn(message) |
||
| 60 | var error = new TimeoutException(message) |
||
| 61 | args[tokenArg].cancel() |
||
| 62 | if (!Objects.isObject(handler.onTimeout) || !Objects.isFunction(handler.onTimeout.handler)) { |
||
| 63 | return reject(error) |
||
| 64 | } |
||
| 65 | args = args.slice().concat(error) |
||
| 66 | return self |
||
| 67 | .runHandler(handler.onTimeout, args, token, tokenArg) |
||
| 68 | .then(resolve, function (e) { reject(e) }) |
||
| 69 | } |
||
| 70 | } |
||
| 71 | |||
| 72 | /** |
||
| 73 | * @inheritDoc |
||
| 74 | */ |
||
| 75 | this.runHandler = function (handler, args, token, tokenArg) { |
||
| 76 | logger.debug('Running handler `{}`', handler.id) |
||
| 77 | args = args ? args.slice() : [] |
||
| 78 | tokenArg = typeof tokenArg === 'number' ? tokenArg : args.length |
||
| 79 | args[tokenArg] = tokenFactory(handler, token) |
||
| 80 | var promise = self.promise(handler.handler, args) |
||
| 81 | if (typeof handler.timeout === 'number' && handler.timeout >= 0) { |
||
| 82 | logger.trace('Scheduling handler `{}` timeout in {} ms', handler.id, |
||
| 83 | handler.timeout) |
||
| 84 | var callback = callbackFactory(handler, args, token, tokenArg) |
||
| 85 | promise = timeout(promise, handler.timeout, callback) |
||
| 86 | } |
||
| 87 | return promise |
||
| 88 | } |
||
| 89 | |||
| 90 | this.getContext = function () { |
||
| 91 | return ctx |
||
| 92 | } |
||
| 93 | } |
||
| 94 | |||
| 98 |
