ClassMappingView::merge() - Code Metrics - Inspection of "Saving yet another WIP" - ama-team/php-elasticsearch - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/initial-implementation ( 79751f...3b7c72 )

by Fike

created 2017-11-21 19:16 UTC

ClassMappingView::merge() A

↳ Parent: ClassMappingView

Complexity

Conditions	4
Paths	5

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.2
c	0
b	0
f	0
cc	4
eloc	9
nc	5
nop	1

<?php

declare(strict_types=1);

namespace AmaTeam\ElasticSearch\Entity\Mapping;

use AmaTeam\ElasticSearch\API\Entity\Mapping\ClassMappingViewInterface;

class ClassMappingView implements ClassMappingViewInterface
{
    /**
     * @var string
     */
    private $type;
    /**
     * @var array
     */
    private $parameters = [];

    /**
     * @return string
     */
    public function getType(): ?string
    {
        return $this->type;
    }

    /**
     * @param string $type
     * @return $this
     */
    public function setType(string $type)
    {
        $this->type = $type;
        return $this;
    }

    /**
     * @return array
     */
    public function getParameters(): array
    {
        return $this->parameters;
    }

    public function setParameter(string $parameter, $value): ClassMappingViewInterface
    {
        $this->parameters[$parameter] = $value;
        return $this;
    }

    /**
     * @param array $parameters
     * @return $this
     */
    public function setParameters(array $parameters)
    {
        $this->parameters = $parameters;
        return $this;
    }

    public static function merge(ClassMappingViewInterface ...$mappings): ClassMappingView
    {
        $target = new ClassMappingView();
        $parameters = [];
        foreach ($mappings as $mapping) {
            if ($mapping->getType()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $target->setType($mapping->getType());
            }
            foreach ($mapping->getParameters() as $parameter => $value) {
                $parameters[$parameter] = $value;
            }
        }
        $target->setParameters($parameters);
        return $target;
    }

    public static function from(ClassMappingViewInterface $mapping): ClassMappingView
    {
        return static::merge($mapping);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace AmaTeam\ElasticSearch\Entity\Mapping;
6
7			use AmaTeam\ElasticSearch\API\Entity\Mapping\ClassMappingViewInterface;
8
9			class ClassMappingView implements ClassMappingViewInterface
10			{
11			/**
12			* @var string
13			*/
14			private $type;
15			/**
16			* @var array
17			*/
18			private $parameters = [];
19
20			/**
21			* @return string
22			*/
23			public function getType(): ?string
24			{
25			return $this->type;
26			}
27
28			/**
29			* @param string $type
30			* @return $this
31			*/
32			public function setType(string $type)
33			{
34			$this->type = $type;
35			return $this;
36			}
37
38			/**
39			* @return array
40			*/
41			public function getParameters(): array
42			{
43			return $this->parameters;
44			}
45
46			public function setParameter(string $parameter, $value): ClassMappingViewInterface
47			{
48			$this->parameters[$parameter] = $value;
49			return $this;
50			}
51
52			/**
53			* @param array $parameters
54			* @return $this
55			*/
56			public function setParameters(array $parameters)
57			{
58			$this->parameters = $parameters;
59			return $this;
60			}
61
62			public static function merge(ClassMappingViewInterface ...$mappings): ClassMappingView
63			{
64			$target = new ClassMappingView();
65			$parameters = [];
66			foreach ($mappings as $mapping) {
67			if ($mapping->getType()) {
			0 ignored issues – show Bug Best Practice introduced 2017-11-20 18:39 UTC by Report Bug Copy Issue Report The expression `$mapping->getType()` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
68			$target->setType($mapping->getType());
69			}
70			foreach ($mapping->getParameters() as $parameter => $value) {
71			$parameters[$parameter] = $value;
72			}
73			}
74			$target->setParameters($parameters);
75			return $target;
76			}
77
78			public static function from(ClassMappingViewInterface $mapping): ClassMappingView
79			{
80			return static::merge($mapping);
81			}
82			}
83

ama-team / php-elasticsearch

Push — feature/initial-implementation ( 79751f...3b7c72 )

ClassMappingView::merge() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like