Converter - Code Metrics - Inspection of "Saving yet another WIP" - ama-team/php-elasticsearch - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/initial-implementation ( 79751f...3b7c72 )

by Fike

created 2017-11-21 19:16 UTC

Converter A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Importance

Changes

Metric	Value
wmc	11
dl	0
loc	62
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
B	renderPropertyMapping()	23	6
A	convert()	4	1
A	renderDocumentMapping()	16	3
A	__construct()	3	1

<?php

declare(strict_types=1);

namespace AmaTeam\ElasticSearch\Mapping\Conversion;

use AmaTeam\ElasticSearch\API\Entity\Mapping\ClassMappingInterface;
use AmaTeam\ElasticSearch\API\Entity\ProviderInterface;
use AmaTeam\ElasticSearch\API\Mapping\MappingInterface;
use AmaTeam\ElasticSearch\API\Entity\Mapping\PropertyMappingInterface;
use AmaTeam\ElasticSearch\API\Mapping\Conversion\ConverterInterface;
use AmaTeam\ElasticSearch\API\Mapping\Conversion\ContextInterface;
use AmaTeam\ElasticSearch\API\Mapping\Conversion\DefaultContext;
use AmaTeam\ElasticSearch\Entity\Mapping\ClassMappingView;
use AmaTeam\ElasticSearch\Entity\Provider;
use AmaTeam\ElasticSearch\Mapping\Mapping;
use AmaTeam\ElasticSearch\Entity\Mapping\PropertyMappingView;

class Converter implements ConverterInterface
{
    /**
     * @var ProviderInterface
     */
    private $provider;

    /**
     * @param ProviderInterface $provider
     */
    public function __construct(ProviderInterface $provider = null)
    {
        $this->provider = $provider ?? new Provider();
    }

    public function convert(ClassMappingInterface $source, ContextInterface $context = null): MappingInterface
    {
        $context = $context ?? new DefaultContext();
        return $this->renderDocumentMapping($source, $context->getViews());
    }

    private function renderDocumentMapping(ClassMappingInterface $document, array $viewNames): MappingInterface
    {
        $views = array_map([$document, 'getView'], $viewNames);
        array_unshift($views, $document->getDefaultView());
        $view = ClassMappingView::merge(...array_filter($views));
        $mapping = new Mapping();
        if ($view->getType()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $mapping->setType($view->getType());
        }
        $properties = [];
        foreach ($document->getProperties() as $property => $definition) {
            $properties[$property] = $this->renderPropertyMapping($definition, $viewNames);
        }
        $mapping->setProperties($properties);
        $mapping->setParameters($view->getParameters());
        return $mapping;
    }

    private function renderPropertyMapping(PropertyMappingInterface $property, array $viewNames): MappingInterface
    {
        $views = array_map([$property, 'getView'], $viewNames);
        array_unshift($views, $property->getDefaultView());
        $view = PropertyMappingView::merge(...array_filter($views));
        $mapping = new Mapping();
        if ($view->getTargetClass()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $localViewNames = $viewNames;
            if (!empty($property->getForcedViewNames())) {
                $forcedViews = $property->getForcedViewNames();
                $append = $property->getAppendForcedViews();
                $localViewNames = $append ? array_merge($localViewNames, $forcedViews) : $forcedViews;
            }
            $source = $this->provider->get($view->getTargetClass());
            $mapping = $this->renderDocumentMapping($source->getMapping(), $localViewNames);
        }
        foreach ($view->getParameters() as $parameter => $value) {
            $mapping->setParameter($parameter, $value);
        }
        if ($view->getType()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $mapping->setType($view->getType());
        }
        return $mapping;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace AmaTeam\ElasticSearch\Mapping\Conversion;
6
7			use AmaTeam\ElasticSearch\API\Entity\Mapping\ClassMappingInterface;
8			use AmaTeam\ElasticSearch\API\Entity\ProviderInterface;
9			use AmaTeam\ElasticSearch\API\Mapping\MappingInterface;
10			use AmaTeam\ElasticSearch\API\Entity\Mapping\PropertyMappingInterface;
11			use AmaTeam\ElasticSearch\API\Mapping\Conversion\ConverterInterface;
12			use AmaTeam\ElasticSearch\API\Mapping\Conversion\ContextInterface;
13			use AmaTeam\ElasticSearch\API\Mapping\Conversion\DefaultContext;
14			use AmaTeam\ElasticSearch\Entity\Mapping\ClassMappingView;
15			use AmaTeam\ElasticSearch\Entity\Provider;
16			use AmaTeam\ElasticSearch\Mapping\Mapping;
17			use AmaTeam\ElasticSearch\Entity\Mapping\PropertyMappingView;
18
19			class Converter implements ConverterInterface
20			{
21			/**
22			* @var ProviderInterface
23			*/
24			private $provider;
25
26			/**
27			* @param ProviderInterface $provider
28			*/
29			public function __construct(ProviderInterface $provider = null)
30			{
31			$this->provider = $provider ?? new Provider();
32			}
33
34			public function convert(ClassMappingInterface $source, ContextInterface $context = null): MappingInterface
35			{
36			$context = $context ?? new DefaultContext();
37			return $this->renderDocumentMapping($source, $context->getViews());
38			}
39
40			private function renderDocumentMapping(ClassMappingInterface $document, array $viewNames): MappingInterface
41			{
42			$views = array_map([$document, 'getView'], $viewNames);
43			array_unshift($views, $document->getDefaultView());
44			$view = ClassMappingView::merge(...array_filter($views));
45			$mapping = new Mapping();
46			if ($view->getType()) {
			0 ignored issues – show Bug Best Practice introduced 2017-11-20 18:39 UTC by Report Bug Copy Issue Report The expression `$view->getType()` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
47			$mapping->setType($view->getType());
48			}
49			$properties = [];
50			foreach ($document->getProperties() as $property => $definition) {
51			$properties[$property] = $this->renderPropertyMapping($definition, $viewNames);
52			}
53			$mapping->setProperties($properties);
54			$mapping->setParameters($view->getParameters());
55			return $mapping;
56			}
57
58			private function renderPropertyMapping(PropertyMappingInterface $property, array $viewNames): MappingInterface
59			{
60			$views = array_map([$property, 'getView'], $viewNames);
61			array_unshift($views, $property->getDefaultView());
62			$view = PropertyMappingView::merge(...array_filter($views));
63			$mapping = new Mapping();
64			if ($view->getTargetClass()) {
			0 ignored issues – show Bug Best Practice introduced 2017-11-20 18:39 UTC by Report Bug Copy Issue Report The expression `$view->getTargetClass()` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
65			$localViewNames = $viewNames;
66			if (!empty($property->getForcedViewNames())) {
67			$forcedViews = $property->getForcedViewNames();
68			$append = $property->getAppendForcedViews();
69			$localViewNames = $append ? array_merge($localViewNames, $forcedViews) : $forcedViews;
70			}
71			$source = $this->provider->get($view->getTargetClass());
72			$mapping = $this->renderDocumentMapping($source->getMapping(), $localViewNames);
73			}
74			foreach ($view->getParameters() as $parameter => $value) {
75			$mapping->setParameter($parameter, $value);
76			}
77			if ($view->getType()) {
			0 ignored issues – show Bug Best Practice introduced 2017-11-20 18:39 UTC by Report Bug Copy Issue Report The expression `$view->getType()` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
78			$mapping->setType($view->getType());
79			}
80			return $mapping;
81			}
82			}
83

ama-team / php-elasticsearch

Push — feature/initial-implementation ( 79751f...3b7c72 )

Converter A

Complexity

Size/Duplication

Importance

4 Methods

Duplication Side-by-Side

Filter issues like