Validator::validateInternal() - Code Metrics - Inspection of "Initial implementation" - ama-team/php-elasticsearch - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev ( 40f0b5...3a2e98 )

by Fike

created 2017-11-26 23:17 UTC

Validator::validateInternal() A

↳ Parent: Validator

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	3

<?php

namespace AmaTeam\ElasticSearch\Mapping;

use AmaTeam\ElasticSearch\API\Mapping\Validation\Context;
use AmaTeam\ElasticSearch\API\Mapping\Validation\ContextInterface;
use AmaTeam\ElasticSearch\Mapping\Type\Parameter\Infrastructure\Registry as Parameters;
use AmaTeam\ElasticSearch\Mapping\Validation\Constraint\ApplicableParameter;
use AmaTeam\ElasticSearch\Mapping\Validation\Constraint\ValidParameterName;
use AmaTeam\ElasticSearch\Mapping\Validation\Constraint\ValidTypeName;
use AmaTeam\ElasticSearch\API\Mapping\ValidatorInterface;
use AmaTeam\ElasticSearch\API\MappingInterface;
use Symfony\Component\Validator\Constraints\NotNull;
use Symfony\Component\Validator\ConstraintViolationListInterface;
use Symfony\Component\Validator\Validation;
use Symfony\Component\Validator\Validator\ContextualValidatorInterface;

class Validator implements ValidatorInterface
{
    public function validate(
        MappingInterface $mapping,
        ContextInterface $context = null
    ): ConstraintViolationListInterface {
        $context = $context ? Context::from($context) : new Context();
        $validator = Validation::createValidator()->startContext();
        $this->validateInternal($mapping, $validator, $context);
        return $validator->getViolations();
    }

    private function validateInternal(
        MappingInterface $mapping,
        ContextualValidatorInterface $validator,
        Context $context
    ): void {
        $this->validateType($mapping, $validator, $context);
        $this->validateParameters($mapping, $validator, $context);
        $this->validateProperties($mapping, $validator, $context);
    }

    private function validateType(
        MappingInterface $mapping,
        ContextualValidatorInterface $validator,
        Context $context
    ): void {
        $segments = array_merge($context->getPath(), ['type']);
        $path = implode('.', $segments);
        $validator->atPath($path);
        $validator->validate($mapping->getType(), [new ValidTypeName()]);
    }

    private function validateParameters(
        MappingInterface $mapping,
        ContextualValidatorInterface $validator,
        Context $context
    ): void {
        foreach ($mapping->getParameters() as $name => $value) {
            $segments = array_merge($context->getPath(), [$name]);
            $validator->atPath(implode('.', $segments));
            $parameter = Parameters::getInstance()->find($name);
            if ($parameter || !$context->shouldPreserveUnknownParameters()) {
                $validator->validate($name, new ValidParameterName());
            }
            if (!$parameter) {
                continue;
            }
            if ($mapping->getType()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $validator->validate($name, new ApplicableParameter(['type' => $mapping->getType()]));
            }
            $constraints = $parameter->getConstraints();
            if (!$parameter->nullValueAllowed()) {
                $constraints[] = new NotNull();
            }
            $validator->validate($value, $constraints);
        }
    }

    private function validateProperties(
        MappingInterface $mapping,
        ContextualValidatorInterface $validator,
        Context $context
    ): void {
        foreach ($mapping->getProperties() as $name => $property) {
            $innerContext = $context->withAppendedPath('properties', $name);
            $this->validateInternal($property, $validator, $innerContext);
        }
    }
}


1			<?php
2
3			namespace AmaTeam\ElasticSearch\Mapping;
4
5			use AmaTeam\ElasticSearch\API\Mapping\Validation\Context;
6			use AmaTeam\ElasticSearch\API\Mapping\Validation\ContextInterface;
7			use AmaTeam\ElasticSearch\Mapping\Type\Parameter\Infrastructure\Registry as Parameters;
8			use AmaTeam\ElasticSearch\Mapping\Validation\Constraint\ApplicableParameter;
9			use AmaTeam\ElasticSearch\Mapping\Validation\Constraint\ValidParameterName;
10			use AmaTeam\ElasticSearch\Mapping\Validation\Constraint\ValidTypeName;
11			use AmaTeam\ElasticSearch\API\Mapping\ValidatorInterface;
12			use AmaTeam\ElasticSearch\API\MappingInterface;
13			use Symfony\Component\Validator\Constraints\NotNull;
14			use Symfony\Component\Validator\ConstraintViolationListInterface;
15			use Symfony\Component\Validator\Validation;
16			use Symfony\Component\Validator\Validator\ContextualValidatorInterface;
17
18			class Validator implements ValidatorInterface
19			{
20			public function validate(
21			MappingInterface $mapping,
22			ContextInterface $context = null
23			): ConstraintViolationListInterface {
24			$context = $context ? Context::from($context) : new Context();
25			$validator = Validation::createValidator()->startContext();
26			$this->validateInternal($mapping, $validator, $context);
27			return $validator->getViolations();
28			}
29
30			private function validateInternal(
31			MappingInterface $mapping,
32			ContextualValidatorInterface $validator,
33			Context $context
34			): void {
35			$this->validateType($mapping, $validator, $context);
36			$this->validateParameters($mapping, $validator, $context);
37			$this->validateProperties($mapping, $validator, $context);
38			}
39
40			private function validateType(
41			MappingInterface $mapping,
42			ContextualValidatorInterface $validator,
43			Context $context
44			): void {
45			$segments = array_merge($context->getPath(), ['type']);
46			$path = implode('.', $segments);
47			$validator->atPath($path);
48			$validator->validate($mapping->getType(), [new ValidTypeName()]);
49			}
50
51			private function validateParameters(
52			MappingInterface $mapping,
53			ContextualValidatorInterface $validator,
54			Context $context
55			): void {
56			foreach ($mapping->getParameters() as $name => $value) {
57			$segments = array_merge($context->getPath(), [$name]);
58			$validator->atPath(implode('.', $segments));
59			$parameter = Parameters::getInstance()->find($name);
60			if ($parameter \|\| !$context->shouldPreserveUnknownParameters()) {
61			$validator->validate($name, new ValidParameterName());
62			}
63			if (!$parameter) {
64			continue;
65			}
66			if ($mapping->getType()) {
			0 ignored issues – show Bug Best Practice introduced 2017-11-26 10:04 UTC by Report Bug Copy Issue Report The expression `$mapping->getType()` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
67			$validator->validate($name, new ApplicableParameter(['type' => $mapping->getType()]));
68			}
69			$constraints = $parameter->getConstraints();
70			if (!$parameter->nullValueAllowed()) {
71			$constraints[] = new NotNull();
72			}
73			$validator->validate($value, $constraints);
74			}
75			}
76
77			private function validateProperties(
78			MappingInterface $mapping,
79			ContextualValidatorInterface $validator,
80			Context $context
81			): void {
82			foreach ($mapping->getProperties() as $name => $property) {
83			$innerContext = $context->withAppendedPath('properties', $name);
84			$this->validateInternal($property, $validator, $innerContext);
85			}
86			}
87			}
88

ama-team / php-elasticsearch

Push — dev ( 40f0b5...3a2e98 )

Validator::validateInternal() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like