PropertyMappingView::merge() - Code Metrics - Inspection of "Small package refactoring: separated annotations a..." - ama-team/php-elasticsearch - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/initial-implementation ( fb0c51...553b70 )

by Fike

created 2017-11-23 12:10 UTC

PropertyMappingView::merge() B

↳ Parent: PropertyMappingView

Complexity

Conditions	5
Paths	9

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
eloc	9
nc	9
nop	1
dl	0
loc	15
rs	8.8571
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace AmaTeam\ElasticSearch\API\Entity\Mapping;

class PropertyMappingView implements PropertyMappingViewInterface
{
    /**
     * @var string|null
     */
    private $type;
    /**
     * @var string|null
     */
    private $targetClass;
    /**
     * @var array
     */
    private $parameters = [];

    /**
     * @return null|string
     */
    public function getType(): ?string
    {
        return $this->type;
    }

    /**
     * @param null|string $type
     * @return $this
     */
    public function setType(string $type)
    {
        $this->type = $type;
        return $this;
    }

    /**
     * @return null|string
     */
    public function getTargetClass(): ?string
    {
        return $this->targetClass;
    }

    /**
     * @param null|string $targetClass
     * @return $this
     */
    public function setTargetClass(string $targetClass)
    {
        $this->targetClass = $targetClass;
        return $this;
    }

    /**
     * @return array
     */
    public function getParameters(): array
    {
        return $this->parameters;
    }

    /**
     * @param array $parameters
     * @return $this
     */
    public function setParameters(array $parameters)
    {
        $this->parameters = $parameters;
        return $this;
    }

    public function setParameter(string $name, $value): PropertyMappingView
    {
        $this->parameters[$name] = $value;
        return $this;
    }

    public static function merge(PropertyMappingViewInterface ...$views): PropertyMappingView
    {
        $target = new PropertyMappingView();
        foreach ($views as $view) {
            if ($view->getType()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $target->setType($view->getType());
            }
            if ($view->getTargetClass()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $target->setTargetClass($view->getTargetClass());
            }
            foreach ($view->getParameters() as $parameter => $value) {
                $target->setParameter($parameter, $value);
            }
        }
        return $target;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace AmaTeam\ElasticSearch\API\Entity\Mapping;
6
7			class PropertyMappingView implements PropertyMappingViewInterface
8			{
9			/**
10			* @var string\|null
11			*/
12			private $type;
13			/**
14			* @var string\|null
15			*/
16			private $targetClass;
17			/**
18			* @var array
19			*/
20			private $parameters = [];
21
22			/**
23			* @return null\|string
24			*/
25			public function getType(): ?string
26			{
27			return $this->type;
28			}
29
30			/**
31			* @param null\|string $type
32			* @return $this
33			*/
34			public function setType(string $type)
35			{
36			$this->type = $type;
37			return $this;
38			}
39
40			/**
41			* @return null\|string
42			*/
43			public function getTargetClass(): ?string
44			{
45			return $this->targetClass;
46			}
47
48			/**
49			* @param null\|string $targetClass
50			* @return $this
51			*/
52			public function setTargetClass(string $targetClass)
53			{
54			$this->targetClass = $targetClass;
55			return $this;
56			}
57
58			/**
59			* @return array
60			*/
61			public function getParameters(): array
62			{
63			return $this->parameters;
64			}
65
66			/**
67			* @param array $parameters
68			* @return $this
69			*/
70			public function setParameters(array $parameters)
71			{
72			$this->parameters = $parameters;
73			return $this;
74			}
75
76			public function setParameter(string $name, $value): PropertyMappingView
77			{
78			$this->parameters[$name] = $value;
79			return $this;
80			}
81
82			public static function merge(PropertyMappingViewInterface ...$views): PropertyMappingView
83			{
84			$target = new PropertyMappingView();
85			foreach ($views as $view) {
86			if ($view->getType()) {
			0 ignored issues – show Bug Best Practice introduced 2017-11-20 18:39 UTC by Report Bug Copy Issue Report The expression `$view->getType()` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
87			$target->setType($view->getType());
88			}
89			if ($view->getTargetClass()) {
			0 ignored issues – show Bug Best Practice introduced 2017-11-20 18:39 UTC by Report Bug Copy Issue Report The expression `$view->getTargetClass()` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
90			$target->setTargetClass($view->getTargetClass());
91			}
92			foreach ($view->getParameters() as $parameter => $value) {
93			$target->setParameter($parameter, $value);
94			}
95			}
96			return $target;
97			}
98			}
99

ama-team / php-elasticsearch

Push — feature/initial-implementation ( fb0c51...553b70 )

PropertyMappingView::merge() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like