ClassMapping::setClassName() - Code Metrics - Inspection of "Small package refactoring: separated annotations a..." - ama-team/php-elasticsearch - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/initial-implementation ( fb0c51...553b70 )

by Fike

created 2017-11-23 12:10 UTC

ClassMapping::setClassName() A

↳ Parent: ClassMapping

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace AmaTeam\ElasticSearch\API\Entity\Mapping;

use AmaTeam\ElasticSearch\API\Entity\Mapping\PropertyMapping as PropertyDescriptor;
use AmaTeam\ElasticSearch\Utility\Classes;

class ClassMapping implements ClassMappingInterface
{
    /**
     * @var string
     */
    private $className;
    /**
     * @var PropertyDescriptor[]
     */
    private $properties = [];
    /**
     * @var ClassMappingView
     */
    private $defaultView;
    /**
     * @var ClassMappingView[]
     */
    private $views = [];

    /**
     * @param string $className
     */
    public function __construct(string $className = null)
    {
        if ($className) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->setClassName($className);
        }
        $this->defaultView = new ClassMappingView();
    }

    /**
     * @return string
     */
    public function getClassName(): string
    {
        return $this->className;
    }

    /**
     * @param string $className
     * @return $this
     */
    public function setClassName(string $className)
    {
        $this->className = Classes::normalizeAbsoluteName($className);
        return $this;
    }

    /**
     * @return PropertyDescriptor[]
     */
    public function getProperties(): array
    {
        return $this->properties;
    }

    /**
     * @param PropertyDescriptor[] $properties
     * @return $this
     */
    public function setProperties(array $properties)
    {
        $this->properties = $properties;
        return $this;
    }

    /**
     * @return ClassMappingViewInterface
     */
    public function getDefaultView(): ClassMappingViewInterface
    {
        return $this->defaultView;
    }

    /**
     * @param ClassMappingView $defaultView
     * @return $this
     */
    public function setDefaultView(ClassMappingView $defaultView)
    {
        $this->defaultView = $defaultView;
        return $this;
    }

    /**
     * @return ClassMappingView[]
     */
    public function getViews(): array
    {
        return $this->views;
    }

    public function getView(string $name): ?ClassMappingViewInterface
    {
        return $this->views[$name] ?? null;
    }

    public function requestView(string $name): ClassMappingViewInterface
    {
        if (!isset($this->views[$name])) {
            $this->views[$name] = new ClassMappingView();
        }
        return $this->views[$name];
    }

    /**
     * @param string[] ...$names
     * @return ClassMappingView[]
     */
    public function requestViews(string ...$names): array
    {
        return array_map([$this, 'requestView'], $names);
    }

    /**
     * @param ClassMappingView[] $views
     * @return $this
     */
    public function setViews(array $views)
    {
        $this->views = $views;
        return $this;
    }

    public function getProperty(string $name): PropertyMappingInterface
    {
        return $this->properties[$name] ?? null;

    }

    public function requestProperty(string $name): PropertyMappingInterface
    {
        if (!isset($this->properties[$name])) {
            $this->properties[$name] = new PropertyMapping($this->className, $name);
        }
        return $this->properties[$name];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace AmaTeam\ElasticSearch\API\Entity\Mapping;
6
7			use AmaTeam\ElasticSearch\API\Entity\Mapping\PropertyMapping as PropertyDescriptor;
8			use AmaTeam\ElasticSearch\Utility\Classes;
9
10			class ClassMapping implements ClassMappingInterface
11			{
12			/**
13			* @var string
14			*/
15			private $className;
16			/**
17			* @var PropertyDescriptor[]
18			*/
19			private $properties = [];
20			/**
21			* @var ClassMappingView
22			*/
23			private $defaultView;
24			/**
25			* @var ClassMappingView[]
26			*/
27			private $views = [];
28
29			/**
30			* @param string $className
31			*/
32			public function __construct(string $className = null)
33			{
34			if ($className) {
			0 ignored issues – show Bug Best Practice introduced 2017-11-21 19:18 UTC by Report Bug Copy Issue Report The expression `$className` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
35			$this->setClassName($className);
36			}
37			$this->defaultView = new ClassMappingView();
38			}
39
40			/**
41			* @return string
42			*/
43			public function getClassName(): string
44			{
45			return $this->className;
46			}
47
48			/**
49			* @param string $className
50			* @return $this
51			*/
52			public function setClassName(string $className)
53			{
54			$this->className = Classes::normalizeAbsoluteName($className);
55			return $this;
56			}
57
58			/**
59			* @return PropertyDescriptor[]
60			*/
61			public function getProperties(): array
62			{
63			return $this->properties;
64			}
65
66			/**
67			* @param PropertyDescriptor[] $properties
68			* @return $this
69			*/
70			public function setProperties(array $properties)
71			{
72			$this->properties = $properties;
73			return $this;
74			}
75
76			/**
77			* @return ClassMappingViewInterface
78			*/
79			public function getDefaultView(): ClassMappingViewInterface
80			{
81			return $this->defaultView;
82			}
83
84			/**
85			* @param ClassMappingView $defaultView
86			* @return $this
87			*/
88			public function setDefaultView(ClassMappingView $defaultView)
89			{
90			$this->defaultView = $defaultView;
91			return $this;
92			}
93
94			/**
95			* @return ClassMappingView[]
96			*/
97			public function getViews(): array
98			{
99			return $this->views;
100			}
101
102			public function getView(string $name): ?ClassMappingViewInterface
103			{
104			return $this->views[$name] ?? null;
105			}
106
107			public function requestView(string $name): ClassMappingViewInterface
108			{
109			if (!isset($this->views[$name])) {
110			$this->views[$name] = new ClassMappingView();
111			}
112			return $this->views[$name];
113			}
114
115			/**
116			* @param string[] ...$names
117			* @return ClassMappingView[]
118			*/
119			public function requestViews(string ...$names): array
120			{
121			return array_map([$this, 'requestView'], $names);
122			}
123
124			/**
125			* @param ClassMappingView[] $views
126			* @return $this
127			*/
128			public function setViews(array $views)
129			{
130			$this->views = $views;
131			return $this;
132			}
133
134			public function getProperty(string $name): PropertyMappingInterface
135			{
136			return $this->properties[$name] ?? null;
			0 ignored issues – show Bug Best Practice introduced 2017-11-21 19:18 UTC by Report Bug Copy Issue Report The expression `return $this->properties[$name] ?? null` could return the type `null` which is incompatible with the type-hinted return `AmaTeam\ElasticSearch\AP...ropertyMappingInterface`. Consider adding an additional type-check to rule them out. Loading history...
137			}
138
139			public function requestProperty(string $name): PropertyMappingInterface
140			{
141			if (!isset($this->properties[$name])) {
142			$this->properties[$name] = new PropertyMapping($this->className, $name);
143			}
144			return $this->properties[$name];
145			}
146			}
147

ama-team / php-elasticsearch

Push — feature/initial-implementation ( fb0c51...553b70 )

ClassMapping::setClassName() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like