EntityProviderWrapperMappingProvider::find() - Code Metrics - Inspection of "Implemented dirty but working mapping extraction p..." - ama-team/php-elasticsearch - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/initial-implementation ( 70fbec...2d1ee1 )

by Fike

created 2017-11-23 16:10 UTC

EntityProviderWrapperMappingProvider::find() A

↳ Parent: EntityProviderWrapperMappingProvider

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	2
nc	2
nop	1
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace AmaTeam\ElasticSearch\Entity\Mapping;

use AmaTeam\ElasticSearch\API\Entity\Mapping\ClassMappingInterface;
use AmaTeam\ElasticSearch\API\Entity\Mapping\ProviderInterface;
use AmaTeam\ElasticSearch\API\Entity\ProviderInterface as EntityProviderInterface;

class EntityProviderWrapperMappingProvider implements ProviderInterface
{
    /**
     * @var EntityProviderInterface
     */
    private $provider;

    /**
     * @param EntityProviderInterface $provider
     */
    public function __construct(EntityProviderInterface $provider)
    {
        $this->provider = $provider;
    }

    public function exists(string $name): bool
    {
        return $this->provider->exists($name);
    }

    public function get(string $name): ClassMappingInterface
    {
        return $this->provider->getResolved($name)->getMapping();

    }

    public function find(string $name): ?ClassMappingInterface
    {
        $entity = $this->provider->findResolved($name);
        return $entity ? $entity->getMapping() : null;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace AmaTeam\ElasticSearch\Entity\Mapping;
6
7			use AmaTeam\ElasticSearch\API\Entity\Mapping\ClassMappingInterface;
8			use AmaTeam\ElasticSearch\API\Entity\Mapping\ProviderInterface;
9			use AmaTeam\ElasticSearch\API\Entity\ProviderInterface as EntityProviderInterface;
10
11			class EntityProviderWrapperMappingProvider implements ProviderInterface
12			{
13			/**
14			* @var EntityProviderInterface
15			*/
16			private $provider;
17
18			/**
19			* @param EntityProviderInterface $provider
20			*/
21			public function __construct(EntityProviderInterface $provider)
22			{
23			$this->provider = $provider;
24			}
25
26			public function exists(string $name): bool
27			{
28			return $this->provider->exists($name);
29			}
30
31			public function get(string $name): ClassMappingInterface
32			{
33			return $this->provider->getResolved($name)->getMapping();
			0 ignored issues – show Bug Best Practice introduced 2017-11-23 16:12 UTC by Report Bug Copy Issue Report The expression `return $this->provider->...ed($name)->getMapping()` could return the type `null` which is incompatible with the type-hinted return `AmaTeam\ElasticSearch\AP...g\ClassMappingInterface`. Consider adding an additional type-check to rule them out. Loading history...
34			}
35
36			public function find(string $name): ?ClassMappingInterface
37			{
38			$entity = $this->provider->findResolved($name);
39			return $entity ? $entity->getMapping() : null;
40			}
41			}
42

ama-team / php-elasticsearch

Push — feature/initial-implementation ( 70fbec...2d1ee1 )

EntityProviderWrapperMappingProvider::find() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like