Resolver::combine() - Code Metrics - Inspection of "Implemented dirty but working mapping extraction p..." - ama-team/php-elasticsearch - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/initial-implementation ( 70fbec...2d1ee1 )

by Fike

created 2017-11-23 16:10 UTC

Resolver::combine() A

↳ Parent: Resolver

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	7
nc	2
nop	2
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace AmaTeam\ElasticSearch\Entity\Inheritance;

use AmaTeam\ElasticSearch\API\Entity\EntityInterface;
use AmaTeam\ElasticSearch\Entity\Entity;
use AmaTeam\ElasticSearch\Entity\Mapping\Inheritance\Combiner;

class Resolver
{
    public static function resolve(EntityInterface ...$hierarchy): EntityInterface
    {
        $cursor = new Entity('-');
        foreach ($hierarchy as $entry) {
            $cursor = static::combine($cursor, $entry);
        }
        return $cursor;
    }

    public static function combine(EntityInterface $parent, EntityInterface $child): EntityInterface
    {
        $result = (new Entity($child->getName()))
            ->setRootLevelDocument($child->isRootLevelDocument())
            // TODO: proper indexing merging scheme
            ->setIndexing($child->getIndexing())
            ->setMapping(Combiner::combine($parent->getMapping(), $child->getMapping()));
        if ($child->getParentName()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $result->setParentName($child->getParentName());
        }
        return $result;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace AmaTeam\ElasticSearch\Entity\Inheritance;
6
7			use AmaTeam\ElasticSearch\API\Entity\EntityInterface;
8			use AmaTeam\ElasticSearch\Entity\Entity;
9			use AmaTeam\ElasticSearch\Entity\Mapping\Inheritance\Combiner;
10
11			class Resolver
12			{
13			public static function resolve(EntityInterface ...$hierarchy): EntityInterface
14			{
15			$cursor = new Entity('-');
16			foreach ($hierarchy as $entry) {
17			$cursor = static::combine($cursor, $entry);
18			}
19			return $cursor;
20			}
21
22			public static function combine(EntityInterface $parent, EntityInterface $child): EntityInterface
23			{
24			$result = (new Entity($child->getName()))
25			->setRootLevelDocument($child->isRootLevelDocument())
26			// TODO: proper indexing merging scheme
27			->setIndexing($child->getIndexing())
28			->setMapping(Combiner::combine($parent->getMapping(), $child->getMapping()));
29			if ($child->getParentName()) {
			0 ignored issues – show Bug Best Practice introduced 2017-11-23 16:12 UTC by Report Bug Copy Issue Report The expression `$child->getParentName()` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
30			$result->setParentName($child->getParentName());
31			}
32			return $result;
33			}
34			}
35

ama-team / php-elasticsearch

Push — feature/initial-implementation ( 70fbec...2d1ee1 )

Resolver::combine() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like