ClassMappingView::from() - Code Metrics - Inspection of "Implemented dirty but working mapping extraction p..." - ama-team/php-elasticsearch - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/initial-implementation ( 70fbec...2d1ee1 )

by Fike

created 2017-11-23 16:10 UTC

ClassMappingView::from() A

↳ Parent: ClassMappingView::setIgnoredProperties()

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace AmaTeam\ElasticSearch\API\Entity\Mapping;

class ClassMappingView implements ClassMappingViewInterface
{
    /**
     * @var string
     */
    private $type;
    /**
     * @var array
     */
    private $parameters = [];
    /**
     * @var string[]
     */
    private $ignoredProperties = [];

    /**
     * @return string
     */
    public function getType(): ?string
    {
        return $this->type;
    }

    /**
     * @param string $type
     * @return $this
     */
    public function setType(string $type)
    {
        $this->type = $type;
        return $this;
    }

    /**
     * @return array
     */
    public function getParameters(): array
    {
        return $this->parameters;
    }

    public function setParameter(string $parameter, $value): ClassMappingViewInterface
    {
        $this->parameters[$parameter] = $value;
        return $this;
    }

    /**
     * @param array $parameters
     * @return $this
     */
    public function setParameters(array $parameters)
    {
        $this->parameters = $parameters;
        return $this;
    }

    /**
     * @return string[]
     */
    public function getIgnoredProperties(): array
    {
        return $this->ignoredProperties;
    }

    /**
     * @param string[] $ignoredProperties
     * @return $this
     */
    public function setIgnoredProperties(array $ignoredProperties)
    {
        $this->ignoredProperties = $ignoredProperties;
        return $this;
    }

    public function addIgnoredProperty(string $property): ClassMappingViewInterface
    {
        $this->ignoredProperties[$property] = $property;
        return $this;
    }

    public function removeIgnoredProperty(string $property): ClassMappingView
    {
        unset($this->ignoredProperties[$property]);
        return $this;
    }

    public function hasIgnoredProperty(string $property): bool
    {
        return isset($this->ignoredProperties[$property]);
    }

    public static function merge(ClassMappingViewInterface ...$mappings): ClassMappingView
    {
        $target = new ClassMappingView();
        $parameters = [];
        foreach ($mappings as $mapping) {
            if ($mapping->getType()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $target->setType($mapping->getType());
            }
            foreach ($mapping->getParameters() as $parameter => $value) {
                $parameters[$parameter] = $value;
            }
            $target->setIgnoredProperties($mapping->getIgnoredProperties());
        }
        $target->setParameters($parameters);
        return $target;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace AmaTeam\ElasticSearch\API\Entity\Mapping;
6
7			class ClassMappingView implements ClassMappingViewInterface
8			{
9			/**
10			* @var string
11			*/
12			private $type;
13			/**
14			* @var array
15			*/
16			private $parameters = [];
17			/**
18			* @var string[]
19			*/
20			private $ignoredProperties = [];
21
22			/**
23			* @return string
24			*/
25			public function getType(): ?string
26			{
27			return $this->type;
28			}
29
30			/**
31			* @param string $type
32			* @return $this
33			*/
34			public function setType(string $type)
35			{
36			$this->type = $type;
37			return $this;
38			}
39
40			/**
41			* @return array
42			*/
43			public function getParameters(): array
44			{
45			return $this->parameters;
46			}
47
48			public function setParameter(string $parameter, $value): ClassMappingViewInterface
49			{
50			$this->parameters[$parameter] = $value;
51			return $this;
52			}
53
54			/**
55			* @param array $parameters
56			* @return $this
57			*/
58			public function setParameters(array $parameters)
59			{
60			$this->parameters = $parameters;
61			return $this;
62			}
63
64			/**
65			* @return string[]
66			*/
67			public function getIgnoredProperties(): array
68			{
69			return $this->ignoredProperties;
70			}
71
72			/**
73			* @param string[] $ignoredProperties
74			* @return $this
75			*/
76			public function setIgnoredProperties(array $ignoredProperties)
77			{
78			$this->ignoredProperties = $ignoredProperties;
79			return $this;
80			}
81
82			public function addIgnoredProperty(string $property): ClassMappingViewInterface
83			{
84			$this->ignoredProperties[$property] = $property;
85			return $this;
86			}
87
88			public function removeIgnoredProperty(string $property): ClassMappingView
89			{
90			unset($this->ignoredProperties[$property]);
91			return $this;
92			}
93
94			public function hasIgnoredProperty(string $property): bool
95			{
96			return isset($this->ignoredProperties[$property]);
97			}
98
99			public static function merge(ClassMappingViewInterface ...$mappings): ClassMappingView
100			{
101			$target = new ClassMappingView();
102			$parameters = [];
103			foreach ($mappings as $mapping) {
104			if ($mapping->getType()) {
			0 ignored issues – show Bug Best Practice introduced 2017-11-20 18:39 UTC by Report Bug Copy Issue Report The expression `$mapping->getType()` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
105			$target->setType($mapping->getType());
106			}
107			foreach ($mapping->getParameters() as $parameter => $value) {
108			$parameters[$parameter] = $value;
109			}
110			$target->setIgnoredProperties($mapping->getIgnoredProperties());
111			}
112			$target->setParameters($parameters);
113			return $target;
114			}
115			}
116

ama-team / php-elasticsearch

Push — feature/initial-implementation ( 70fbec...2d1ee1 )

ClassMappingView::from() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like