Mappings::conflicts() - Code Metrics - Inspection of "Added E2E tests" - ama-team/php-elasticsearch - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/initial-implementation ( f3915b...fbd338 )

by Fike

created 2017-11-24 14:44 UTC

Mappings::conflicts() B

↳ Parent: Mappings

Complexity

Conditions	10
Paths	8

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	10
eloc	9
nc	8
nop	2
dl	0
loc	16
rs	7.2765
c	0
b	0
f	0

How to fix Complexity

<?php

declare(strict_types=1);

namespace AmaTeam\ElasticSearch\Mapping;

use AmaTeam\ElasticSearch\API\Mapping\MappingInterface;

class Mappings
{
    public static function conflict(MappingInterface ...$mappings): bool
    {
        $mappings = array_values($mappings);
        for ($i = 0; $i < sizeof($mappings) - 1; $i++) {
            $subject = $mappings[$i];
            for ($j = $i + 1; $j < sizeof($mappings); $j++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                if (static::conflicts($subject, $mappings[$j])) {
                    return true;
                }
            }
        }
        return false;
    }

    private static function conflicts(MappingInterface $subject, MappingInterface $opponent): bool
    {
        if ($subject->getType() && $opponent->getType() && $subject->getType() !== $opponent->getType()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return true;
        }
        foreach ($subject->getParameters() as $parameter => $value) {
            if ($opponent->hasParameter($parameter) && $opponent->getParameter($parameter) != $value) {
                return true;
            }
        }
        foreach ($subject->getProperties() as $name => $property) {
            if ($opponent->hasProperty($name) && static::conflicts($property, $opponent->getProperty($name))) {
                return true;
            }
        }
        return false;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace AmaTeam\ElasticSearch\Mapping;
6
7			use AmaTeam\ElasticSearch\API\Mapping\MappingInterface;
8
9			class Mappings
10			{
11			public static function conflict(MappingInterface ...$mappings): bool
12			{
13			$mappings = array_values($mappings);
14			for ($i = 0; $i < sizeof($mappings) - 1; $i++) {
15			$subject = $mappings[$i];
16			for ($j = $i + 1; $j < sizeof($mappings); $j++) {
			0 ignored issues – show Performance Best Practice introduced 2017-11-24 14:46 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `sizeof()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
17			if (static::conflicts($subject, $mappings[$j])) {
18			return true;
19			}
20			}
21			}
22			return false;
23			}
24
25			private static function conflicts(MappingInterface $subject, MappingInterface $opponent): bool
26			{
27			if ($subject->getType() && $opponent->getType() && $subject->getType() !== $opponent->getType()) {
			0 ignored issues – show Bug Best Practice introduced 2017-11-24 14:46 UTC by Report Bug Copy Issue Report The expression `$opponent->getType()` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history... Bug Best Practice introduced 2017-11-24 14:46 UTC by Report Bug Copy Issue Report The expression `$subject->getType()` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
28			return true;
29			}
30			foreach ($subject->getParameters() as $parameter => $value) {
31			if ($opponent->hasParameter($parameter) && $opponent->getParameter($parameter) != $value) {
32			return true;
33			}
34			}
35			foreach ($subject->getProperties() as $name => $property) {
36			if ($opponent->hasProperty($name) && static::conflicts($property, $opponent->getProperty($name))) {
37			return true;
38			}
39			}
40			return false;
41			}
42			}
43

ama-team / php-elasticsearch

Push — feature/initial-implementation ( f3915b...fbd338 )

Mappings::conflicts() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like