AmaTeam\ElasticSearch\Mapping\Mappings

Complexity

Total Complexity

18

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	conflict()	0	12	4
A	haveConflicts()	0	9	3
A	havePropertyConflicts()	0	8	4
A	haveParameterConflicts()	0	8	4
A	haveTypeConflict()	0	3	3

<?php

declare(strict_types=1);

namespace AmaTeam\ElasticSearch\Mapping;

use AmaTeam\ElasticSearch\API\Mapping\MappingInterface;

class Mappings
{
    public static function conflict(MappingInterface ...$mappings): bool
    {
        $mappings = array_values($mappings);
        for ($i = 0; $i < sizeof($mappings) - 1; $i++) {
            $subject = $mappings[$i];
            for ($j = $i + 1; $j < sizeof($mappings); $j++) {

It seems like you are calling the size function sizeof() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                if (static::haveConflicts($subject, $mappings[$j])) {
                    return true;
                }
            }
        }
        return false;
    }

    private static function haveConflicts(MappingInterface $subject, MappingInterface $opponent): bool
    {
        if (static::haveTypeConflict($subject, $opponent)) {
            return true;
        }
        if (static::haveParameterConflicts($subject, $opponent)) {
            return true;
        }
        return static::havePropertyConflicts($subject, $opponent);
    }

    private static function haveTypeConflict(MappingInterface $subject, MappingInterface $opponent): bool
    {
        return $subject->getType() && $opponent->getType() && $subject->getType() !== $opponent->getType();

The expression $opponent->getType() of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

The expression $subject->getType() of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

    }

    private static function haveParameterConflicts(MappingInterface $subject, MappingInterface $opponent): bool
    {
        foreach ($subject->getParameters() as $parameter => $value) {
            if ($opponent->hasParameter($parameter) && $opponent->getParameter($parameter) != $value) {
                return true;
            }
        }
        return false;
    }

    private static function havePropertyConflicts(MappingInterface $subject, MappingInterface $opponent): bool
    {
        foreach ($subject->getProperties() as $name => $property) {
            if ($opponent->hasProperty($name) && static::haveConflicts($property, $opponent->getProperty($name))) {
                return true;
            }
        }
        return false;
    }
}